From a0ac8c25f0c153da5fa7125cbcba2670beb8fa1b Mon Sep 17 00:00:00 2001
From: syasonik <syasonik@gitlab.com>
Date: Mon, 8 Apr 2019 23:58:42 +0800
Subject: Fix static analysis and false positive test

---
 spec/javascripts/monitoring/utils_spec.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/spec/javascripts/monitoring/utils_spec.js b/spec/javascripts/monitoring/utils_spec.js
index 688dced6d89..e3c455d1686 100644
--- a/spec/javascripts/monitoring/utils_spec.js
+++ b/spec/javascripts/monitoring/utils_spec.js
@@ -15,10 +15,14 @@ describe('getTimeDiff', () => {
   });
 
   it('returns a value for every defined time window', () => {
-    Object.keys(timeWindows).forEach(window => {
-      const params = getTimeDiff(timeWindows.window);
+    const nonDefaultWindows = Object.keys(timeWindows).filter(window => window !== 'eightHours');
+
+    nonDefaultWindows.forEach(window => {
+      const params = getTimeDiff(timeWindows[window]);
       const diff = params.end - params.start;
 
+      // Ensure we're not returning the default, 28800 (the # of seconds in 8 hrs)
+      expect(diff).not.toEqual(28800);
       expect(typeof diff).toEqual('number');
     });
   });
-- 
cgit v1.2.1