From 80e1dad19737a1322dc8a8b3d1c67f73309a72db Mon Sep 17 00:00:00 2001 From: Bryce Johnson Date: Fri, 25 Aug 2017 18:58:42 -0400 Subject: WIP: Check in current progress, with notes on next steps. --- app/assets/javascripts/repo/components/repo.vue | 8 +++---- .../repo/components/repo_file_buttons.vue | 13 ++++------- .../javascripts/repo/components/repo_preview.vue | 18 ++------------- .../javascripts/repo/mixins/blob_viewer_mixin.js | 27 ++++++++++++++++++++++ app/assets/javascripts/repo/stores/repo_store.js | 3 +++ 5 files changed, 40 insertions(+), 29 deletions(-) create mode 100644 app/assets/javascripts/repo/mixins/blob_viewer_mixin.js diff --git a/app/assets/javascripts/repo/components/repo.vue b/app/assets/javascripts/repo/components/repo.vue index 54bf3a568fe..a162aaceb82 100644 --- a/app/assets/javascripts/repo/components/repo.vue +++ b/app/assets/javascripts/repo/components/repo.vue @@ -36,8 +36,6 @@ export default { this.toggleDialogOpen(false); this.dialog.status = status; }, - - toggleBlobView: Store.toggleBlobView, }, }; @@ -59,12 +57,14 @@ export default { diff --git a/app/assets/javascripts/repo/components/repo_file_buttons.vue b/app/assets/javascripts/repo/components/repo_file_buttons.vue index 09fd3592b6e..ce6c677ecc6 100644 --- a/app/assets/javascripts/repo/components/repo_file_buttons.vue +++ b/app/assets/javascripts/repo/components/repo_file_buttons.vue @@ -2,20 +2,17 @@ import Store from '../stores/repo_store'; import Helper from '../helpers/repo_helper'; import RepoMixin from '../mixins/repo_mixin'; +import BlobViewerMixin from '../mixins/blob_viewer_mixin'; -const RepoFileButtons = { +export default { data: () => Store, props: { activeBlobViewers: { type: Object, required: false }, + selectedBlobViewerType: { type: String, required: false }, }, - mixins: [RepoMixin], + mixins: [RepoMixin, BlobViewerMixin], computed: { - viewerIsSimple() {}, - viewerIsRich() {} - canDisplayRichViewer() { - // duplicate - } rawDownloadButtonLabel() { return this.binary ? 'Download' : 'Raw'; }, @@ -37,8 +34,6 @@ const RepoFileButtons = { rawPreviewToggle: Store.toggleRawPreview, }, }; - -export default RepoFileButtons;