From 6ef86756254b246f025acd55140ac056efe746a6 Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Wed, 20 Dec 2017 10:25:41 +0100 Subject: Rename QA factory alias to improve readability --- qa/qa/factory/base.rb | 4 ++-- qa/spec/factory/base_spec.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qa/qa/factory/base.rb b/qa/qa/factory/base.rb index 7c03611dc0d..cfd16d209a0 100644 --- a/qa/qa/factory/base.rb +++ b/qa/qa/factory/base.rb @@ -21,8 +21,8 @@ module QA @dependencies ||= {} end - def self.dependency(factory, name: nil, &block) - (name || factory.name.split('::').last.downcase).tap do |name| + def self.dependency(factory, as: nil, &block) + (as || factory.name.split('::').last.downcase).tap do |name| class_eval { attr_accessor name } Dependency::Signature.new(factory, block).tap do |signature| diff --git a/qa/spec/factory/base_spec.rb b/qa/spec/factory/base_spec.rb index d3b7711f99b..ea10f06becd 100644 --- a/qa/spec/factory/base_spec.rb +++ b/qa/spec/factory/base_spec.rb @@ -67,7 +67,7 @@ describe QA::Factory::Base do context 'when using explicit resource name' do subject do Class.new(described_class) do - dependency Some::MyDependency, name: :otherdep do |factory| + dependency Some::MyDependency, as: :otherdep do |factory| factory.something! end end -- cgit v1.2.1