From 348e44ef06c3ebc89ada47c64d7bec5bf56dfd54 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Tue, 11 Feb 2014 15:49:39 +0200 Subject: Dont use avatars for user select if avatar is disabled Signed-off-by: Dmitriy Zaporozhets --- app/assets/javascripts/users_select.js.coffee | 4 +++- app/controllers/application_controller.rb | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/users_select.js.coffee b/app/assets/javascripts/users_select.js.coffee index 92cd3a9905b..c1fa16ca89c 100644 --- a/app/assets/javascripts/users_select.js.coffee +++ b/app/assets/javascripts/users_select.js.coffee @@ -2,10 +2,12 @@ $ -> userFormatResult = (user) -> if user.avatar avatar = user.avatar.url - else + else if gon.gravatar_enabled avatar = gon.gravatar_url avatar = avatar.replace('%{hash}', md5(user.email)) avatar = avatar.replace('%{size}', '24') + else + avatar = gon.relative_url_root + "/assets/no_avatar.png" "
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 442b1b65ce8..5f6485e57c5 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -171,6 +171,7 @@ class ApplicationController < ActionController::Base gon.api_token = current_user.private_token if current_user gon.gravatar_url = request.ssl? || Gitlab.config.gitlab.https ? Gitlab.config.gravatar.ssl_url : Gitlab.config.gravatar.plain_url gon.relative_url_root = Gitlab.config.gitlab.relative_url_root + gon.gravatar_enabled = Gitlab.config.gravatar.enabled end def check_password_expiration -- cgit v1.2.1