From 9e3f9f751b78efe8dbe70f07cd583be3eea3c56d Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Tue, 25 Dec 2018 14:44:16 -0800 Subject: Fix clone dropdown parent inheritance issues in HAML The change in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24015 caused some parent relationships to be incorrect. This caused a failure in the EE failure the Geo button was added because the modal stopped showing. --- app/views/projects/buttons/_clone.html.haml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/app/views/projects/buttons/_clone.html.haml b/app/views/projects/buttons/_clone.html.haml index 53d427ec40a..159d9e44e17 100644 --- a/app/views/projects/buttons/_clone.html.haml +++ b/app/views/projects/buttons/_clone.html.haml @@ -5,18 +5,18 @@ %span.append-right-4.js-clone-dropdown-label = _('Clone') = sprite_icon("arrow-down", css_class: "icon") - %form.p-3.dropdown-menu.dropdown-menu-right.dropdown-menu-large.dropdown-menu-selectable.clone-options-dropdown.qa-clone-options - - if ssh_enabled? - %li.pb-2 - %label.label-bold - = _('Clone with SSH') - .input-group - = text_field_tag :ssh_project_clone, project.ssh_url_to_repo, class: "js-select-on-focus form-control qa-ssh-clone-url", readonly: true, aria: { label: 'Project clone URL' } - .input-group-append - = clipboard_button(target: '#ssh_project_clone', title: _("Copy URL to clipboard"), class: "input-group-text btn-default btn-clipboard") - = render_if_exists 'projects/buttons/geo' - %li - - if http_enabled? + %ul.p-3.dropdown-menu.dropdown-menu-right.dropdown-menu-large.dropdown-menu-selectable.clone-options-dropdown.qa-clone-options + - if ssh_enabled? + %li.pb-2 + %label.label-bold + = _('Clone with SSH') + .input-group + = text_field_tag :ssh_project_clone, project.ssh_url_to_repo, class: "js-select-on-focus form-control qa-ssh-clone-url", readonly: true, aria: { label: 'Project clone URL' } + .input-group-append + = clipboard_button(target: '#ssh_project_clone', title: _("Copy URL to clipboard"), class: "input-group-text btn-default btn-clipboard") + = render_if_exists 'projects/buttons/geo' + - if http_enabled? + %li %label.label-bold = _('Clone with %{http_label}') % { http_label: gitlab_config.protocol.upcase } .input-group -- cgit v1.2.1 From 70d155e87f3871cc0a87660e37d9daa6ef5320ea Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Wed, 26 Dec 2018 15:22:27 +0530 Subject: Add changelog entry --- changelogs/unreleased/sh-fix-clone-geo-dropdown.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/sh-fix-clone-geo-dropdown.yml diff --git a/changelogs/unreleased/sh-fix-clone-geo-dropdown.yml b/changelogs/unreleased/sh-fix-clone-geo-dropdown.yml new file mode 100644 index 00000000000..1c0cbdc3a2c --- /dev/null +++ b/changelogs/unreleased/sh-fix-clone-geo-dropdown.yml @@ -0,0 +1,5 @@ +--- +title: Fix clone dropdown parent inheritance issues in HAML +merge_request: 24029 +author: +type: fixed -- cgit v1.2.1