From 615ba0071a8bcd3da93f6c27e45128af865cc7bb Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Mon, 11 Sep 2017 16:05:14 +0200 Subject: Eager load namespace owners for project dashboards This solves an N+1 query problem where we'd run multiple queries when getting the namespace owners of the displayed projects. --- app/controllers/dashboard/projects_controller.rb | 2 +- changelogs/unreleased/dashboards-projects-controller.yml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/dashboards-projects-controller.yml diff --git a/app/controllers/dashboard/projects_controller.rb b/app/controllers/dashboard/projects_controller.rb index f71ab702e71..cd94a36a6e7 100644 --- a/app/controllers/dashboard/projects_controller.rb +++ b/app/controllers/dashboard/projects_controller.rb @@ -48,7 +48,7 @@ class Dashboard::ProjectsController < Dashboard::ApplicationController ProjectsFinder .new(params: finder_params, current_user: current_user) .execute - .includes(:route, :creator, namespace: :route) + .includes(:route, :creator, namespace: [:route, :owner]) end def load_events diff --git a/changelogs/unreleased/dashboards-projects-controller.yml b/changelogs/unreleased/dashboards-projects-controller.yml new file mode 100644 index 00000000000..8b350f70a80 --- /dev/null +++ b/changelogs/unreleased/dashboards-projects-controller.yml @@ -0,0 +1,5 @@ +--- +title: Eager load namespace owners for project dashboards +merge_request: +author: +type: other -- cgit v1.2.1