From 5e0d859e38256e5b9840eb47edc145e3c58eb188 Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Fri, 15 Jun 2018 16:26:01 -0500 Subject: Remove .files --- .babelrc | 25 - .codeclimate.yml | 40 - .csscomb.json | 20 - .eslintignore | 12 - .eslintrc.yml | 75 -- .flayignore | 25 - .foreman | 1 - .github/ISSUE_TEMPLATE.md | 3 - .github/PULL_REQUEST_TEMPLATE.md | 3 - .gitignore | 79 -- .gitlab-ci.yml | 885 --------------------- .gitlab/issue_templates/Bug.md | 87 -- .gitlab/issue_templates/Feature Proposal.md | 15 - .gitlab/issue_templates/Research Proposal.md | 17 - .../issue_templates/Security Developer Workflow.md | 70 -- .../merge_request_templates/Database Changes.md | 50 -- .gitlab/merge_request_templates/Documentation.md | 29 - .gitlab/route-map.yml | 3 - .haml-lint.yml | 121 --- .mailmap | 35 - .nvmrc | 1 - .pkgr.yml | 49 -- .prettierignore | 5 - .prettierrc | 13 - .rubocop.yml | 135 ---- .rubocop_todo.yml | 845 -------------------- .ruby-version | 1 - .scss-lint.yml | 273 ------- 28 files changed, 2917 deletions(-) delete mode 100644 .babelrc delete mode 100644 .codeclimate.yml delete mode 100644 .csscomb.json delete mode 100644 .eslintignore delete mode 100644 .eslintrc.yml delete mode 100644 .flayignore delete mode 100644 .foreman delete mode 100644 .github/ISSUE_TEMPLATE.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE.md delete mode 100644 .gitignore delete mode 100644 .gitlab-ci.yml delete mode 100644 .gitlab/issue_templates/Bug.md delete mode 100644 .gitlab/issue_templates/Feature Proposal.md delete mode 100644 .gitlab/issue_templates/Research Proposal.md delete mode 100644 .gitlab/issue_templates/Security Developer Workflow.md delete mode 100644 .gitlab/merge_request_templates/Database Changes.md delete mode 100644 .gitlab/merge_request_templates/Documentation.md delete mode 100644 .gitlab/route-map.yml delete mode 100644 .haml-lint.yml delete mode 100644 .mailmap delete mode 100644 .nvmrc delete mode 100644 .pkgr.yml delete mode 100644 .prettierignore delete mode 100644 .prettierrc delete mode 100644 .rubocop.yml delete mode 100644 .rubocop_todo.yml delete mode 100644 .ruby-version delete mode 100644 .scss-lint.yml diff --git a/.babelrc b/.babelrc deleted file mode 100644 index 50d85f58d69..00000000000 --- a/.babelrc +++ /dev/null @@ -1,25 +0,0 @@ -{ - "presets": [["latest", { "es2015": { "modules": false } }], "stage-2"], - "env": { - "karma": { - "plugins": ["rewire"] - }, - "coverage": { - "plugins": [ - [ - "istanbul", - { - "exclude": ["spec/javascripts/**/*", "app/assets/javascripts/locale/**/app.js"] - } - ], - [ - "transform-define", - { - "process.env.BABEL_ENV": "coverage" - } - ], - "rewire" - ] - } - } -} diff --git a/.codeclimate.yml b/.codeclimate.yml deleted file mode 100644 index 9998ddba643..00000000000 --- a/.codeclimate.yml +++ /dev/null @@ -1,40 +0,0 @@ ---- -engines: - bundler-audit: - enabled: true - duplication: - enabled: true - config: - languages: - - ruby - - javascript -ratings: - paths: - - Gemfile.lock - - "**.erb" - - "**.haml" - - "**.rb" - - "**.rhtml" - - "**.slim" - - "**.inc" - - "**.js" - - "**.jsx" - - "**.module" -exclude_paths: -- config/ -- db/ -- features/ -- node_modules/ -- spec/ -- vendor/ -- .yarn-cache/ -- tmp/ -- builds/ -- coverage/ -- public/ -- shared/ -- webpack-report/ -- log/ -- backups/ -- coverage-javascript/ -- plugins/ diff --git a/.csscomb.json b/.csscomb.json deleted file mode 100644 index aa6a17f7517..00000000000 --- a/.csscomb.json +++ /dev/null @@ -1,20 +0,0 @@ -{ - "exclude": [ - "app/assets/stylesheets/framework/tw_bootstrap_variables.scss", - "app/assets/stylesheets/framework/fonts.scss" - ], - "always-semicolon": true, - "color-case": "lower", - "block-indent": " ", - "color-shorthand": false, - "element-case": "lower", - "space-before-colon": "", - "space-after-colon": " ", - "space-before-combinator": " ", - "space-after-combinator": " ", - "space-between-declarations": "\n", - "space-before-opening-brace": " ", - "space-after-opening-brace": "\n", - "space-before-closing-brace": "\n", - "unitless-zero": true -} diff --git a/.eslintignore b/.eslintignore deleted file mode 100644 index 33a8186fade..00000000000 --- a/.eslintignore +++ /dev/null @@ -1,12 +0,0 @@ -/app/assets/javascripts/locale/**/app.js -/config/ -/builds/ -/coverage/ -/coverage-javascript/ -/node_modules/ -/public/ -/scripts/ -/tmp/ -/vendor/ -karma.config.js -webpack.config.js diff --git a/.eslintrc.yml b/.eslintrc.yml deleted file mode 100644 index 5b416c9bf1b..00000000000 --- a/.eslintrc.yml +++ /dev/null @@ -1,75 +0,0 @@ ---- -env: - browser: true - es6: true -extends: - - airbnb-base - - plugin:vue/recommended -globals: - __webpack_public_path__: true - gl: false - gon: false - localStorage: false -parserOptions: - parser: babel-eslint -plugins: - - filenames - - import - - html - - promise -settings: - html/html-extensions: - - ".html" - - ".html.raw" - import/resolver: - webpack: - config: "./config/webpack.config.js" -rules: - filenames/match-regex: - - error - - "^[a-z0-9_]+$" - import/no-commonjs: error - no-multiple-empty-lines: - - error - - max: 1 - promise/catch-or-return: error - no-underscore-dangle: - - error - - allow: - - __ - - _links - no-mixed-operators: off - vue/html-self-closing: - - error - - html: - void: always - normal: never - component: always - svg: always - math: always - ## Conflicting rules with prettier: - space-before-function-paren: off - curly: off - arrow-parens: off - function-paren-newline: off - object-curly-newline: off - padded-blocks: off - # Disabled for now, to make the eslint 3 -> eslint 4 update smoother - ## Indent rule. We are using the old for now: https://eslint.org/docs/user-guide/migrating-to-4.0.0#indent-rewrite - indent: off - indent-legacy: - - error - - 2 - - SwitchCase: 1 - VariableDeclarator: 1 - outerIIFEBody: 1 - FunctionDeclaration: - parameters: 1 - body: 1 - FunctionExpression: - parameters: 1 - body: 1 - ## Destructuring: https://eslint.org/docs/rules/prefer-destructuring - prefer-destructuring: off - ## no-multi-assign: https://eslint.org/docs/rules/no-multi-assign - no-multi-assign: off diff --git a/.flayignore b/.flayignore deleted file mode 100644 index 3e5063674ff..00000000000 --- a/.flayignore +++ /dev/null @@ -1,25 +0,0 @@ -*.erb -lib/gitlab/sanitizers/svg/whitelist.rb -lib/gitlab/diff/position_tracer.rb -app/policies/project_policy.rb -app/models/concerns/relative_positioning.rb -app/workers/stuck_merge_jobs_worker.rb -lib/gitlab/redis/*.rb -lib/gitlab/gitaly_client/operation_service.rb -lib/gitlab/background_migration/* -app/models/project_services/kubernetes_service.rb -lib/gitlab/workhorse.rb -lib/gitlab/ci/trace/chunked_io.rb -lib/gitlab/gitaly_client/ref_service.rb -lib/gitlab/gitaly_client/commit_service.rb -lib/gitlab/git/commit.rb -lib/gitlab/git/tag.rb - -ee/db/**/* -ee/app/serializers/ee/merge_request_widget_entity.rb -ee/lib/api/epics.rb -ee/lib/api/geo_nodes.rb -ee/lib/ee/gitlab/ldap/sync/admin_users.rb -ee/app/workers/geo/file_download_dispatch_worker/job_artifact_job_finder.rb -ee/app/workers/geo/file_download_dispatch_worker/lfs_object_job_finder.rb -ee/spec/**/* diff --git a/.foreman b/.foreman deleted file mode 100644 index 87c3f5a1c15..00000000000 --- a/.foreman +++ /dev/null @@ -1 +0,0 @@ -port: 3000 diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index 2e88b7aa0a9..00000000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,3 +0,0 @@ -We’re closing our issue tracker on GitHub so we can focus on the GitLab.com project and respond to issues more quickly. - -We encourage you to open an issue on the [GitLab.com issue tracker](https://gitlab.com/gitlab-org/gitlab-ce/issues). You can log into GitLab.com using your GitHub account. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index c3b04026440..00000000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,3 +0,0 @@ -Thank you for taking the time to contribute back to GitLab! - -Please open a merge request [on GitLab.com](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests), we look forward to reviewing your contribution! You can log into GitLab.com using your GitHub account. diff --git a/.gitignore b/.gitignore deleted file mode 100644 index 21dc67384aa..00000000000 --- a/.gitignore +++ /dev/null @@ -1,79 +0,0 @@ -*.log -*.swp -*.mo -*.edit.po -*.rej -.DS_Store -.bundle -.chef -.directory -/.envrc -eslint-report.html -/.gitlab_shell_secret -.idea -/.vscode/* -/.rbenv-version -.rbx/ -/.ruby-gemset -/.ruby-version -/.rvmrc -.sass-cache/ -/.secret -/.vagrant -/.yarn-cache -/.byebug_history -/Vagrantfile -/app/assets/images/icons.json -/app/assets/images/icons.svg -/app/assets/images/illustrations/ -/app/assets/javascripts/locale/**/app.js -/backups/* -/config/aws.yml -/config/database.yml -/config/gitlab.yml -/config/gitlab_ci.yml -/config/initializers/rack_attack.rb -/config/initializers/smtp_settings.rb -/config/initializers/relative_url.rb -/config/resque.yml -/config/redis.cache.yml -/config/redis.queues.yml -/config/redis.shared_state.yml -/config/unicorn.rb -/config/secrets.yml -/config/sidekiq.yml -/config/registry.key -/coverage/* -/coverage-javascript/ -/db/*.sqlite3 -/db/*.sqlite3-journal -/db/data.yml -/doc/code/* -/dump.rdb -/jsconfig.json -/log/*.log* -/node_modules/ -/nohup.out -/public/assets/ -/public/uploads.* -/public/uploads/ -/shared/artifacts/ -/spec/javascripts/fixtures/blob/pdf/ -/spec/javascripts/fixtures/blob/balsamiq/ -/rails_best_practices_output.html -/tags -/tmp/* -/vendor/bundle/* -/vendor/gitaly-ruby -/builds* -/shared/* -/.gitlab_workhorse_secret -/webpack-report/ -/knapsack/ -/rspec_flaky/ -/locale/**/LC_MESSAGES -/locale/**/*.time_stamp -/.rspec -/plugins/* -/.gitlab_pages_secret -package-lock.json diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml deleted file mode 100644 index e7304b9c057..00000000000 --- a/.gitlab-ci.yml +++ /dev/null @@ -1,885 +0,0 @@ -image: "dev.gitlab.org:5005/gitlab/gitlab-build-images:ruby-2.4.4-golang-1.9-git-2.17-chrome-67.0-node-8.x-yarn-1.2-postgresql-9.6-graphicsmagick-1.3.29" - -.dedicated-runner: &dedicated-runner - retry: 1 - tags: - - gitlab-org - -.default-cache: &default-cache - key: "ruby-2.4.4-debian-stretch-with-yarn" - paths: - - vendor/ruby - - .yarn-cache/ - - vendor/gitaly-ruby - -.push-cache: &push-cache - cache: - <<: *default-cache - policy: push - -.pull-cache: &pull-cache - cache: - <<: *default-cache - policy: pull - -variables: - MYSQL_ALLOW_EMPTY_PASSWORD: "1" - RAILS_ENV: "test" - NODE_ENV: "test" - SIMPLECOV: "true" - GIT_DEPTH: "20" - GIT_SUBMODULE_STRATEGY: "none" - GET_SOURCES_ATTEMPTS: "3" - KNAPSACK_RSPEC_SUITE_REPORT_PATH: knapsack/${CI_PROJECT_NAME}/rspec_report-master.json - FLAKY_RSPEC_SUITE_REPORT_PATH: rspec_flaky/report-suite.json - -before_script: - - bundle --version - - date - - source scripts/utils.sh - - date - - source scripts/prepare_build.sh - - date - -after_script: - - date - -stages: - - build - - prepare - - test - - post-test - - pages - - post-cleanup - -# Predefined scopes -.tests-metadata-state: &tests-metadata-state - <<: *dedicated-runner - variables: - TESTS_METADATA_S3_BUCKET: "gitlab-ce-cache" - before_script: - - source scripts/utils.sh - artifacts: - expire_in: 31d - paths: - - knapsack/ - - rspec_flaky/ - -.use-pg: &use-pg - services: - # As of Jan 2018, we don't have a strong reason to upgrade to 9.6 for CI yet, - # so using the least common denominator ensures backwards compatibility - # (as many users are still using 9.2). - - postgres:9.2 - - redis:alpine - -.use-mysql: &use-mysql - services: - - mysql:5.7 - - redis:alpine - -.rails5-variables: &rails5-variables - script: - - export RAILS5=${RAILS5} - - export BUNDLE_GEMFILE=${BUNDLE_GEMFILE} - -.rails5: &rails5 - allow_failure: true - only: - - /rails5/ - variables: - BUNDLE_GEMFILE: "Gemfile.rails5" - RAILS5: "true" - -# Skip all jobs except the ones that begin with 'docs/'. -# Used for commits including ONLY documentation changes. -# https://docs.gitlab.com/ce/development/writing_documentation.html#testing -.except-docs: &except-docs - except: - - /(^docs[\/-].*|.*-docs$)/ - -.except-qa: &except-qa - except: - - /(^qa[\/-].*|.*-qa$)/ - -.except-docs-and-qa: &except-docs-and-qa - except: - - /(^docs[\/-].*|.*-docs$)/ - - /(^qa[\/-].*|.*-qa$)/ - -# Jobs that only need to pull cache -.dedicated-no-docs-pull-cache-job: &dedicated-no-docs-pull-cache-job - <<: *dedicated-runner - <<: *except-docs - <<: *pull-cache - dependencies: - - setup-test-env - stage: test - -# Jobs that do not need a DB -.dedicated-no-docs-no-db-pull-cache-job: &dedicated-no-docs-no-db-pull-cache-job - <<: *dedicated-no-docs-pull-cache-job - variables: - SETUP_DB: "false" - -.dedicated-no-docs-and-no-qa-pull-cache-job: &dedicated-no-docs-and-no-qa-pull-cache-job - <<: *dedicated-no-docs-pull-cache-job - <<: *except-docs-and-qa - -.single-script-job: &single-script-job - image: ruby:2.4-alpine - before_script: [] - stage: build - cache: {} - dependencies: [] - variables: &single-script-job-variables - GIT_STRATEGY: none - before_script: - # We need to download the script rather than clone the repo since the - # package-and-qa job will not be able to run when the branch gets - # deleted (when merging the MR). - - export SCRIPT_NAME="${SCRIPT_NAME:-$CI_JOB_NAME}" - - apk add --update openssl - - wget $CI_PROJECT_URL/raw/$CI_COMMIT_SHA/scripts/$SCRIPT_NAME - - chmod 755 $SCRIPT_NAME - -.rake-exec: &rake-exec - <<: *dedicated-no-docs-no-db-pull-cache-job - script: - - bundle exec rake $CI_JOB_NAME - -.rspec-metadata: &rspec-metadata - <<: *dedicated-runner - <<: *except-docs-and-qa - <<: *pull-cache - <<: *rails5-variables - stage: test - script: - - JOB_NAME=( $CI_JOB_NAME ) - - export CI_NODE_INDEX=${JOB_NAME[-2]} - - export CI_NODE_TOTAL=${JOB_NAME[-1]} - - export KNAPSACK_REPORT_PATH=knapsack/${CI_PROJECT_NAME}/${JOB_NAME[0]}_node_${CI_NODE_INDEX}_${CI_NODE_TOTAL}_report.json - - export KNAPSACK_GENERATE_REPORT=true - - export SUITE_FLAKY_RSPEC_REPORT_PATH=${FLAKY_RSPEC_SUITE_REPORT_PATH} - - export FLAKY_RSPEC_REPORT_PATH=rspec_flaky/all_${JOB_NAME[0]}_${CI_NODE_INDEX}_${CI_NODE_TOTAL}_report.json - - export NEW_FLAKY_RSPEC_REPORT_PATH=rspec_flaky/new_${JOB_NAME[0]}_${CI_NODE_INDEX}_${CI_NODE_TOTAL}_report.json - - export FLAKY_RSPEC_GENERATE_REPORT=true - - export CACHE_CLASSES=true - - cp ${KNAPSACK_RSPEC_SUITE_REPORT_PATH} ${KNAPSACK_REPORT_PATH} - - '[[ -f $FLAKY_RSPEC_REPORT_PATH ]] || echo "{}" > ${FLAKY_RSPEC_REPORT_PATH}' - - '[[ -f $NEW_FLAKY_RSPEC_REPORT_PATH ]] || echo "{}" > ${NEW_FLAKY_RSPEC_REPORT_PATH}' - - scripts/gitaly-test-spawn - - knapsack rspec "--color --format documentation" - artifacts: - expire_in: 31d - when: always - paths: - - coverage/ - - knapsack/ - - rspec_flaky/ - - tmp/capybara/ - -.rspec-metadata-pg: &rspec-metadata-pg - <<: *rspec-metadata - <<: *use-pg - -.rspec-metadata-pg-rails5: &rspec-metadata-pg-rails5 - <<: *rspec-metadata-pg - <<: *rails5 - -.rspec-metadata-mysql: &rspec-metadata-mysql - <<: *rspec-metadata - <<: *use-mysql - -.rspec-metadata-mysql-rails5: &rspec-metadata-mysql-rails5 - <<: *rspec-metadata-mysql - <<: *rails5 - -.only-canonical-masters: &only-canonical-masters - only: - - master@gitlab-org/gitlab-ce - - master@gitlab-org/gitlab-ee - - master@gitlab/gitlabhq - - master@gitlab/gitlab-ee - -.gitlab-setup: &gitlab-setup - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - <<: *use-pg - variables: - SETUP_DB: "false" - script: - # Manually clone gitlab-test and only seed this project in - # db/fixtures/development/04_project.rb thanks to SIZE=1 below - - git clone https://gitlab.com/gitlab-org/gitlab-test.git - /home/git/repositories/gitlab-org/gitlab-test.git - - scripts/gitaly-test-spawn - - force=yes SIZE=1 FIXTURE_PATH="db/fixtures/development" bundle exec rake gitlab:setup - artifacts: - when: on_failure - expire_in: 1d - paths: - - log/development.log - -# Review docs base -.review-docs: &review-docs - <<: *dedicated-runner - <<: *except-qa - <<: *single-script-job - variables: - <<: *single-script-job-variables - SCRIPT_NAME: trigger-build-docs - when: manual - only: - - branches - -# DB migration, rollback, and seed jobs -.db-migrate-reset: &db-migrate-reset - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - script: - - bundle exec rake db:migrate:reset - -.migration-paths: &migration-paths - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - variables: - SETUP_DB: "false" - script: - - git fetch https://gitlab.com/gitlab-org/gitlab-ce.git v9.3.0 - - git checkout -f FETCH_HEAD - - bundle install $BUNDLE_INSTALL_FLAGS - - date - - cp config/gitlab.yml.example config/gitlab.yml - - bundle exec rake db:drop db:create db:schema:load db:seed_fu - - date - - git checkout -f $CI_COMMIT_SHA - - bundle install $BUNDLE_INSTALL_FLAGS - - date - - . scripts/prepare_build.sh - - date - - bundle exec rake db:migrate - -## -# Trigger a package build in omnibus-gitlab repository -# -package-and-qa: - <<: *single-script-job - variables: - <<: *single-script-job-variables - SCRIPT_NAME: trigger-build - retry: 0 - script: - - ./$SCRIPT_NAME omnibus - when: manual - only: - - //@gitlab-org/gitlab-ce - - //@gitlab-org/gitlab-ee - -# Trigger a docs build in gitlab-docs -# Useful to preview the docs changes live -review-docs-deploy: - <<: *review-docs - stage: build - environment: - name: review-docs/$CI_COMMIT_REF_NAME - # DOCS_REVIEW_APPS_DOMAIN and DOCS_GITLAB_REPO_SUFFIX are secret variables - # Discussion: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14236/diffs#note_40140693 - url: http://$DOCS_GITLAB_REPO_SUFFIX-$CI_COMMIT_REF_SLUG.$DOCS_REVIEW_APPS_DOMAIN/$DOCS_GITLAB_REPO_SUFFIX - on_stop: review-docs-cleanup - script: - - gem install gitlab --no-ri --no-rdoc - - ./$SCRIPT_NAME deploy - -# Cleanup remote environment of gitlab-docs -review-docs-cleanup: - <<: *review-docs - stage: post-cleanup - environment: - name: review-docs/$CI_COMMIT_REF_NAME - action: stop - script: - - gem install gitlab --no-ri --no-rdoc - - ./SCRIPT_NAME cleanup - -## -# Trigger a docker image build in CNG (Cloud Native GitLab) repository -# -cloud-native-image: - image: ruby:2.4-alpine - before_script: [] - stage: build - allow_failure: true - variables: - GIT_DEPTH: "1" - cache: {} - before_script: - - gem install gitlab --no-rdoc --no-ri - - chmod 755 ./scripts/trigger-build-cloud-native - script: - - ./scripts/trigger-build-cloud-native - only: - - tags@gitlab-org/gitlab-ce - - tags@gitlab-org/gitlab-ee - -# Retrieve knapsack and rspec_flaky reports -retrieve-tests-metadata: - <<: *tests-metadata-state - <<: *except-docs-and-qa - stage: prepare - cache: - key: tests_metadata - policy: pull - script: - - mkdir -p knapsack/${CI_PROJECT_NAME}/ - - wget -O $KNAPSACK_RSPEC_SUITE_REPORT_PATH http://${TESTS_METADATA_S3_BUCKET}.s3.amazonaws.com/$KNAPSACK_RSPEC_SUITE_REPORT_PATH || rm $KNAPSACK_RSPEC_SUITE_REPORT_PATH - - '[[ -f $KNAPSACK_RSPEC_SUITE_REPORT_PATH ]] || echo "{}" > ${KNAPSACK_RSPEC_SUITE_REPORT_PATH}' - - mkdir -p rspec_flaky/ - - wget -O $FLAKY_RSPEC_SUITE_REPORT_PATH http://${TESTS_METADATA_S3_BUCKET}.s3.amazonaws.com/$FLAKY_RSPEC_SUITE_REPORT_PATH || rm $FLAKY_RSPEC_SUITE_REPORT_PATH - - '[[ -f $FLAKY_RSPEC_SUITE_REPORT_PATH ]] || echo "{}" > ${FLAKY_RSPEC_SUITE_REPORT_PATH}' - -update-tests-metadata: - <<: *tests-metadata-state - <<: *only-canonical-masters - stage: post-test - cache: - key: tests_metadata - paths: - - knapsack/ - - rspec_flaky/ - policy: push - script: - - retry gem install fog-aws mime-types activesupport --no-ri --no-rdoc - - scripts/merge-reports ${KNAPSACK_RSPEC_SUITE_REPORT_PATH} knapsack/${CI_PROJECT_NAME}/rspec-pg_node_*.json - - scripts/merge-reports ${FLAKY_RSPEC_SUITE_REPORT_PATH} rspec_flaky/all_*_*.json - - FLAKY_RSPEC_GENERATE_REPORT=1 scripts/prune-old-flaky-specs ${FLAKY_RSPEC_SUITE_REPORT_PATH} - - '[[ -z ${TESTS_METADATA_S3_BUCKET} ]] || scripts/sync-reports put $TESTS_METADATA_S3_BUCKET $KNAPSACK_RSPEC_SUITE_REPORT_PATH' - - '[[ -z ${TESTS_METADATA_S3_BUCKET} ]] || scripts/sync-reports put $TESTS_METADATA_S3_BUCKET $FLAKY_RSPEC_SUITE_REPORT_PATH' - - rm -f knapsack/${CI_PROJECT_NAME}/*_node_*.json - - rm -f rspec_flaky/all_*.json rspec_flaky/new_*.json - -flaky-examples-check: - <<: *dedicated-runner - image: ruby:2.4-alpine - services: [] - before_script: [] - variables: - SETUP_DB: "false" - USE_BUNDLE_INSTALL: "false" - NEW_FLAKY_SPECS_REPORT: rspec_flaky/report-new.json - stage: post-test - allow_failure: true - retry: 0 - only: - - branches - except: - - master - - /(^docs[\/-].*|.*-docs$)/ - - /(^qa[\/-].*|.*-qa$)/ - artifacts: - expire_in: 30d - paths: - - rspec_flaky/ - script: - - '[[ -f $NEW_FLAKY_SPECS_REPORT ]] || echo "{}" > ${NEW_FLAKY_SPECS_REPORT}' - - scripts/merge-reports ${NEW_FLAKY_SPECS_REPORT} rspec_flaky/new_*_*.json - - scripts/detect-new-flaky-examples $NEW_FLAKY_SPECS_REPORT - -compile-assets: - <<: *dedicated-runner - <<: *except-docs - <<: *use-pg - stage: prepare - cache: - <<: *default-cache - script: - - node --version - - date - - yarn install --frozen-lockfile --cache-folder .yarn-cache - - date - - free -m - - bundle exec rake gitlab:assets:compile - variables: - # we override the max_old_space_size to prevent OOM errors - NODE_OPTIONS: --max_old_space_size=3584 - artifacts: - expire_in: 7d - paths: - - node_modules - - public/assets - -setup-test-env: - <<: *dedicated-runner - <<: *except-docs - <<: *use-pg - stage: prepare - cache: - <<: *default-cache - script: - - bundle exec ruby -Ispec -e 'require "spec_helper" ; TestEnv.init' - - scripts/gitaly-test-build # Do not use 'bundle exec' here - - BUNDLE_GEMFILE=Gemfile.rails5 bundle install $BUNDLE_INSTALL_FLAGS - artifacts: - expire_in: 7d - paths: - - tmp/tests - - config/secrets.yml - - vendor/gitaly-ruby - -rspec-pg 0 30: *rspec-metadata-pg -rspec-pg 1 30: *rspec-metadata-pg -rspec-pg 2 30: *rspec-metadata-pg -rspec-pg 3 30: *rspec-metadata-pg -rspec-pg 4 30: *rspec-metadata-pg -rspec-pg 5 30: *rspec-metadata-pg -rspec-pg 6 30: *rspec-metadata-pg -rspec-pg 7 30: *rspec-metadata-pg -rspec-pg 8 30: *rspec-metadata-pg -rspec-pg 9 30: *rspec-metadata-pg -rspec-pg 10 30: *rspec-metadata-pg -rspec-pg 11 30: *rspec-metadata-pg -rspec-pg 12 30: *rspec-metadata-pg -rspec-pg 13 30: *rspec-metadata-pg -rspec-pg 14 30: *rspec-metadata-pg -rspec-pg 15 30: *rspec-metadata-pg -rspec-pg 16 30: *rspec-metadata-pg -rspec-pg 17 30: *rspec-metadata-pg -rspec-pg 18 30: *rspec-metadata-pg -rspec-pg 19 30: *rspec-metadata-pg -rspec-pg 20 30: *rspec-metadata-pg -rspec-pg 21 30: *rspec-metadata-pg -rspec-pg 22 30: *rspec-metadata-pg -rspec-pg 23 30: *rspec-metadata-pg -rspec-pg 24 30: *rspec-metadata-pg -rspec-pg 25 30: *rspec-metadata-pg -rspec-pg 26 30: *rspec-metadata-pg -rspec-pg 27 30: *rspec-metadata-pg -rspec-pg 28 30: *rspec-metadata-pg -rspec-pg 29 30: *rspec-metadata-pg - -rspec-mysql 0 30: *rspec-metadata-mysql -rspec-mysql 1 30: *rspec-metadata-mysql -rspec-mysql 2 30: *rspec-metadata-mysql -rspec-mysql 3 30: *rspec-metadata-mysql -rspec-mysql 4 30: *rspec-metadata-mysql -rspec-mysql 5 30: *rspec-metadata-mysql -rspec-mysql 6 30: *rspec-metadata-mysql -rspec-mysql 7 30: *rspec-metadata-mysql -rspec-mysql 8 30: *rspec-metadata-mysql -rspec-mysql 9 30: *rspec-metadata-mysql -rspec-mysql 10 30: *rspec-metadata-mysql -rspec-mysql 11 30: *rspec-metadata-mysql -rspec-mysql 12 30: *rspec-metadata-mysql -rspec-mysql 13 30: *rspec-metadata-mysql -rspec-mysql 14 30: *rspec-metadata-mysql -rspec-mysql 15 30: *rspec-metadata-mysql -rspec-mysql 16 30: *rspec-metadata-mysql -rspec-mysql 17 30: *rspec-metadata-mysql -rspec-mysql 18 30: *rspec-metadata-mysql -rspec-mysql 19 30: *rspec-metadata-mysql -rspec-mysql 20 30: *rspec-metadata-mysql -rspec-mysql 21 30: *rspec-metadata-mysql -rspec-mysql 22 30: *rspec-metadata-mysql -rspec-mysql 23 30: *rspec-metadata-mysql -rspec-mysql 24 30: *rspec-metadata-mysql -rspec-mysql 25 30: *rspec-metadata-mysql -rspec-mysql 26 30: *rspec-metadata-mysql -rspec-mysql 27 30: *rspec-metadata-mysql -rspec-mysql 28 30: *rspec-metadata-mysql -rspec-mysql 29 30: *rspec-metadata-mysql - -rspec-pg-rails5 0 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 1 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 2 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 3 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 4 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 5 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 6 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 7 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 8 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 9 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 10 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 11 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 12 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 13 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 14 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 15 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 16 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 17 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 18 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 19 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 20 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 21 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 22 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 23 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 24 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 25 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 26 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 27 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 28 30: *rspec-metadata-pg-rails5 -rspec-pg-rails5 29 30: *rspec-metadata-pg-rails5 - -rspec-mysql-rails5 0 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 1 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 2 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 3 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 4 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 5 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 6 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 7 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 8 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 9 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 10 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 11 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 12 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 13 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 14 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 15 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 16 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 17 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 18 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 19 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 20 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 21 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 22 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 23 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 24 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 25 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 26 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 27 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 28 30: *rspec-metadata-mysql-rails5 -rspec-mysql-rails5 29 30: *rspec-metadata-mysql-rails5 - -static-analysis: - <<: *dedicated-no-docs-no-db-pull-cache-job - dependencies: - - compile-assets - - setup-test-env - script: - - scripts/static-analysis - cache: - key: "ruby-2.4.4-debian-stretch-with-yarn-and-rubocop" - paths: - - vendor/ruby - - .yarn-cache/ - - tmp/rubocop_cache - -# Documentation checks: -# - Check validity of relative links -# - Make sure cURL examples in API docs use the full switches -docs lint: - <<: *dedicated-runner - <<: *except-qa - image: "registry.gitlab.com/gitlab-org/gitlab-build-images:nanoc-bootstrap-ruby-2.4-alpine" - stage: test - cache: {} - dependencies: [] - before_script: [] - script: - - scripts/lint-doc.sh - - scripts/lint-changelog-yaml - - mv doc/ /nanoc/content/ - - cd /nanoc - # Build HTML from Markdown - - bundle exec nanoc - # Check the internal links - - bundle exec nanoc check internal_links - -downtime_check: - <<: *rake-exec - except: - - master - - tags - - /^[\d-]+-stable(-ee)?$/ - - /(^docs[\/-].*|.*-docs$)/ - - /(^qa[\/-].*|.*-qa$)/ - -rails5_gemfile_lock_check: - <<: *dedicated-no-docs-no-db-pull-cache-job - <<: *except-docs-and-qa - script: - - scripts/rails5-gemfile-lock-check - -ee_compat_check: - <<: *rake-exec - except: - - master - - tags - - /[\d-]+-stable(-ee)?/ - - /^security-/ - - branches@gitlab-org/gitlab-ee - - branches@gitlab/gitlab-ee - retry: 0 - artifacts: - name: "${CI_JOB_NAME}_${CI_COMIT_REF_NAME}_${CI_COMMIT_SHA}" - when: always - expire_in: 10d - paths: - - ee_compat_check/patches/*.patch - -db:migrate:reset-pg: - <<: *db-migrate-reset - <<: *use-pg - -db:migrate:reset-mysql: - <<: *db-migrate-reset - <<: *use-mysql - -db:check-schema-pg: - <<: *db-migrate-reset - <<: *use-pg - script: - - source scripts/schema_changed.sh - -migration:path-pg: - <<: *migration-paths - <<: *use-pg - -migration:path-mysql: - <<: *migration-paths - <<: *use-mysql - -.db-rollback: &db-rollback - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - script: - - bundle exec rake db:migrate VERSION=20170523121229 - - bundle exec rake db:migrate - -db:rollback-pg: - <<: *db-rollback - <<: *use-pg - -db:rollback-mysql: - <<: *db-rollback - <<: *use-mysql - -gitlab:setup-pg: - <<: *gitlab-setup - <<: *use-pg - -gitlab:setup-mysql: - <<: *gitlab-setup - <<: *use-mysql - -# Frontend-related jobs -gitlab:assets:compile: - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - dependencies: [] - variables: - NODE_ENV: "production" - RAILS_ENV: "production" - SETUP_DB: "false" - SKIP_STORAGE_VALIDATION: "true" - WEBPACK_REPORT: "true" - NO_COMPRESSION: "true" - # we override the max_old_space_size to prevent OOM errors - NODE_OPTIONS: --max_old_space_size=3584 - script: - - date - - yarn install --frozen-lockfile --production --cache-folder .yarn-cache - - date - - free -m - - bundle exec rake gitlab:assets:compile - artifacts: - name: webpack-report - expire_in: 31d - paths: - - webpack-report/ - -karma: - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - <<: *use-pg - dependencies: - - compile-assets - - setup-test-env - script: - - export BABEL_ENV=coverage CHROME_LOG_FILE=chrome_debug.log - - date - - scripts/gitaly-test-spawn - - date - - bundle exec rake karma - coverage: '/^Statements *: (\d+\.\d+%)/' - artifacts: - name: coverage-javascript - expire_in: 31d - when: always - paths: - - chrome_debug.log - - coverage-javascript/ - -codequality: - <<: *dedicated-no-docs-no-db-pull-cache-job - image: docker:stable - allow_failure: true - # gitlab-org runners set `privileged: false` but we need to have it set to true - # since we're using Docker in Docker - tags: [] - before_script: [] - services: - - docker:stable-dind - variables: - SETUP_DB: "false" - DOCKER_DRIVER: overlay2 - cache: {} - dependencies: [] - script: - # Extract "MAJOR.MINOR" from CI_SERVER_VERSION and generate "MAJOR-MINOR-stable" for Security Products - - export SP_VERSION=$(echo "$CI_SERVER_VERSION" | sed 's/^\([0-9]*\)\.\([0-9]*\).*/\1-\2-stable/') - - docker run --env SOURCE_CODE="$PWD" --volume "$PWD":/code --volume /var/run/docker.sock:/var/run/docker.sock "registry.gitlab.com/gitlab-org/security-products/codequality:$SP_VERSION" /code - artifacts: - paths: [codeclimate.json] - expire_in: 1 week - -sast: - <<: *dedicated-no-docs-no-db-pull-cache-job - image: docker:stable - variables: - SAST_CONFIDENCE_LEVEL: 2 - DOCKER_DRIVER: overlay2 - allow_failure: true - tags: [] - before_script: [] - cache: {} - dependencies: [] - services: - - docker:stable-dind - script: - - export SP_VERSION=$(echo "$CI_SERVER_VERSION" | sed 's/^\([0-9]*\)\.\([0-9]*\).*/\1-\2-stable/') - - docker run - --env SAST_CONFIDENCE_LEVEL="${SAST_CONFIDENCE_LEVEL:-3}" - --volume "$PWD:/code" - --volume /var/run/docker.sock:/var/run/docker.sock - "registry.gitlab.com/gitlab-org/security-products/sast:$SP_VERSION" /app/bin/run /code - artifacts: - paths: [gl-sast-report.json] - -dependency_scanning: - <<: *dedicated-no-docs-no-db-pull-cache-job - image: docker:stable - variables: - DOCKER_DRIVER: overlay2 - allow_failure: true - tags: [] - before_script: [] - cache: {} - dependencies: [] - services: - - docker:stable-dind - script: - - export SP_VERSION=$(echo "$CI_SERVER_VERSION" | sed 's/^\([0-9]*\)\.\([0-9]*\).*/\1-\2-stable/') - - docker run - --env DEP_SCAN_DISABLE_REMOTE_CHECKS="${DEP_SCAN_DISABLE_REMOTE_CHECKS:-false}" - --volume "$PWD:/code" - --volume /var/run/docker.sock:/var/run/docker.sock - "registry.gitlab.com/gitlab-org/security-products/dependency-scanning:$SP_VERSION" /code - artifacts: - paths: [gl-dependency-scanning-report.json] - -qa:internal: - <<: *dedicated-no-docs-no-db-pull-cache-job - services: [] - script: - - cd qa/ - - bundle install - - bundle exec rspec - -qa:selectors: - <<: *dedicated-no-docs-no-db-pull-cache-job - services: [] - script: - - cd qa/ - - bundle install - - bundle exec bin/qa Test::Sanity::Selectors - -coverage: - # Don't include dedicated-no-docs-no-db-pull-cache-job here since we need to - # download artifacts from all the rspec jobs instead of from setup-test-env only - <<: *dedicated-runner - <<: *except-docs-and-qa - <<: *pull-cache - variables: - SETUP_DB: "false" - stage: post-test - script: - - bundle exec scripts/merge-simplecov - coverage: '/LOC \((\d+\.\d+%)\) covered.$/' - artifacts: - name: coverage - expire_in: 31d - paths: - - coverage/index.html - - coverage/assets/ - -lint:javascript:report: - <<: *dedicated-no-docs-and-no-qa-pull-cache-job - stage: post-test - dependencies: - - compile-assets - - setup-test-env - before_script: [] - script: - - date - - find app/ spec/ -name '*.js' -exec sed --in-place 's|/\* eslint-disable .*\*/||' {} \; # run report over all files - - date - - yarn run eslint-report || true # ignore exit code - artifacts: - name: eslint-report - expire_in: 31d - paths: - - eslint-report.html - -pages: - <<: *dedicated-no-docs-no-db-pull-cache-job - before_script: [] - stage: pages - dependencies: - - coverage - - karma - - gitlab:assets:compile - - lint:javascript:report - script: - - mv public/ .public/ - - mkdir public/ - - mv coverage/ public/coverage-ruby/ || true - - mv coverage-javascript/ public/coverage-javascript/ || true - - mv eslint-report.html public/ || true - - mv webpack-report/ public/webpack-report/ || true - artifacts: - paths: - - public - only: - - master@gitlab-org/gitlab-ce - - master@gitlab-org/gitlab-ee - -# Insurance in case a gem needed by one of our releases gets yanked from -# rubygems.org in the future. -cache gems: - <<: *dedicated-no-docs-no-db-pull-cache-job - script: - - bundle package --all --all-platforms - artifacts: - paths: - - vendor/cache - only: - - master@gitlab-org/gitlab-ce - - master@gitlab-org/gitlab-ee - - tags - -gitlab_git_test: - <<: *dedicated-runner - <<: *except-docs-and-qa - variables: - SETUP_DB: "false" - before_script: [] - cache: {} - script: - - spec/support/prepare-gitlab-git-test-for-commit --check-for-changes - -no_ee_check: - <<: *dedicated-runner - <<: *except-docs-and-qa - variables: - SETUP_DB: "false" - before_script: [] - cache: {} - script: - - scripts/no-ee-check - only: - - //@gitlab-org/gitlab-ce diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md deleted file mode 100644 index 3e58d2a867e..00000000000 --- a/.gitlab/issue_templates/Bug.md +++ /dev/null @@ -1,87 +0,0 @@ - - -### Summary - -(Summarize the bug encountered concisely) - -### Steps to reproduce - -(How one can reproduce the issue - this is very important) - -### Example Project - -(If possible, please create an example project here on GitLab.com that exhibits the problematic behaviour, and link to it here in the bug report) - -(If you are using an older version of GitLab, this will also determine whether the bug has been fixed in a more recent version) - -### What is the current *bug* behavior? - -(What actually happens) - -### What is the expected *correct* behavior? - -(What you should see instead) - -### Relevant logs and/or screenshots - -(Paste any relevant logs - please use code blocks (```) to format console output, -logs, and code as it's very hard to read otherwise.) - -### Output of checks - -(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com) - -#### Results of GitLab environment info - -
-Expand for output related to GitLab environment info -
-
-(For installations with omnibus-gitlab package run and paste the output of:
-`sudo gitlab-rake gitlab:env:info`)
-
-(For installations from source run and paste the output of:
-`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
-
-
-
- -#### Results of GitLab application Check - -
-Expand for output related to the GitLab application check -
-
-(For installations with omnibus-gitlab package run and paste the output of:
-`sudo gitlab-rake gitlab:check SANITIZE=true`)
-
-(For installations from source run and paste the output of:
-`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
-
-(we will only investigate if the tests are passing)
-
-
-
- -### Possible fixes - -(If you can, link to the line of code that might be responsible for the problem) - -/label ~bug diff --git a/.gitlab/issue_templates/Feature Proposal.md b/.gitlab/issue_templates/Feature Proposal.md deleted file mode 100644 index c4065d3c4ea..00000000000 --- a/.gitlab/issue_templates/Feature Proposal.md +++ /dev/null @@ -1,15 +0,0 @@ -### Problem to solve - -### Further details - -(Include use cases, benefits, and/or goals) - -### Proposal - -### What does success look like, and how can we measure that? - -(If no way to measure success, link to an issue that will implement a way to measure this) - -### Links / references - -/label ~"feature proposal" diff --git a/.gitlab/issue_templates/Research Proposal.md b/.gitlab/issue_templates/Research Proposal.md deleted file mode 100644 index 5676656793d..00000000000 --- a/.gitlab/issue_templates/Research Proposal.md +++ /dev/null @@ -1,17 +0,0 @@ -### Background: - -(Include problem, use cases, benefits, and/or goals) - -**What questions are you trying to answer?** - -**Are you looking to verify an existing hypothesis or uncover new issues you should be exploring?** - -**What is the backstory of this project and how does it impact the approach?** - -**What do you already know about the areas you are exploring?** - -**What does success look like at the end of the project?** - -### Links / references: - -/label ~"UX research" diff --git a/.gitlab/issue_templates/Security Developer Workflow.md b/.gitlab/issue_templates/Security Developer Workflow.md deleted file mode 100644 index 0c878dbf64c..00000000000 --- a/.gitlab/issue_templates/Security Developer Workflow.md +++ /dev/null @@ -1,70 +0,0 @@ - - -### Prior to the security release - -- [ ] Read the [security process for developers] if you are not familiar with it. -- [ ] Link to the original issue adding it to the [links section](#links) -- [ ] Run `scripts/security-harness` in the CE, EE, and/or Omnibus to prevent pushing to any remote besides `dev.gitlab.org` -- [ ] Create an MR targetting `org` `master`, prefixing your branch with `security-` -- [ ] Label your MR with the ~security label, prefix the title with `WIP: [master]` -- [ ] Add a link to the MR to the [links section](#links) -- [ ] Add a link to an EE MR if required -- [ ] Make sure the MR remains in-progress and gets approved after the review cycle, **but never merged**. -- [ ] Assign the MR to a RM once is reviewed and ready to be merged. Check the [RM list] to see who to ping. - -#### Backports - -- [ ] Once the MR is ready to be merged, create MRs targetting the last 3 releases - - [ ] At this point, it might be easy to squash the commits from the MR into one - - You can use the script `bin/secpick` instead of the following steps, to help you cherry-picking. See the [seckpick documentation] - - [ ] Create the branch `security-X-Y` from `X-Y-stable` if it doesn't exist (and make sure it's up to date with stable) - - [ ] Create each MR targetting the security branch `security-X-Y` - - [ ] Add the ~security label and prefix with the version `WIP: [X.Y]` the title of the MR -- [ ] Make sure all MRs have a link in the [links section](#links) and are assigned to a Release Manager. - -[seckpick documentation]: https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md#secpick-script - -#### Documentation and final details - -- [ ] Check the topic on #security to see when the next release is going to happen and add a link to the [links section](#links) -- [ ] Find out the versions affected (the Git history of the files affected may help you with this) and add them to the [details section](#details) -- [ ] Fill in any upgrade notes that users may need to take into account in the [details section](#details) -- [ ] Add Yes/No and further details if needed to the migration and settings columns in the [details section](#details) -- [ ] Add the nickname of the external user who found the issue (and/or HackerOne profile) to the Thanks row in the [details section](#details) - -### Summary -#### Links - -| Description | Link | -| -------- | -------- | -| Original issue | #TODO | -| Security release issue | #TODO | -| `master` MR | !TODO | -| `master` MR (EE) | !TODO | -| `Backport X.Y` MR | !TODO | -| `Backport X.Y` MR | !TODO | -| `Backport X.Y` MR | !TODO | -| `Backport X.Y` MR (EE) | !TODO | -| `Backport X.Y` MR (EE) | !TODO | -| `Backport X.Y` MR (EE) | !TODO | - -#### Details - -| Description | Details | Further details| -| -------- | -------- | -------- | -| Versions affected | X.Y | | -| Upgrade notes | | | -| GitLab Settings updated | Yes/No| | -| Migration required | Yes/No | | -| Thanks | | | - -[security process for developers]: https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md -[RM list]: https://about.gitlab.com/release-managers/ - -/label ~security diff --git a/.gitlab/merge_request_templates/Database Changes.md b/.gitlab/merge_request_templates/Database Changes.md deleted file mode 100644 index 1c4f30d9320..00000000000 --- a/.gitlab/merge_request_templates/Database Changes.md +++ /dev/null @@ -1,50 +0,0 @@ -Add a description of your merge request here. Merge requests without an adequate -description will not be reviewed until one is added. - -## Database Checklist - -When adding migrations: - -- [ ] Updated `db/schema.rb` -- [ ] Added a `down` method so the migration can be reverted -- [ ] Added the output of the migration(s) to the MR body -- [ ] Added tests for the migration in `spec/migrations` if necessary (e.g. when migrating data) - -When adding or modifying queries to improve performance: - -- [ ] Included data that shows the performance improvement, preferably in the form of a benchmark -- [ ] Included the output of `EXPLAIN (ANALYZE, BUFFERS)` of the relevant queries - -When adding foreign keys to existing tables: - -- [ ] Included a migration to remove orphaned rows in the source table before adding the foreign key -- [ ] Removed any instances of `dependent: ...` that may no longer be necessary - -When adding tables: - -- [ ] Ordered columns based on the [Ordering Table Columns](https://docs.gitlab.com/ee/development/ordering_table_columns.html#ordering-table-columns) guidelines -- [ ] Added foreign keys to any columns pointing to data in other tables -- [ ] Added indexes for fields that are used in statements such as WHERE, ORDER BY, GROUP BY, and JOINs - -When removing columns, tables, indexes or other structures: - -- [ ] Removed these in a post-deployment migration -- [ ] Made sure the application no longer uses (or ignores) these structures - -## General Checklist - -- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary -- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html) -- [ ] API support added -- [ ] Tests added for this feature/bug -- Conform by the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html) - - [ ] Has been reviewed by a Backend maintainer - - [ ] Has been reviewed by a Database specialist -- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html) -- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides) -- [ ] If you have multiple commits, please combine them into a few logically organized commits by [squashing them](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) -- [ ] Internationalization required/considered -- [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -- [ ] End-to-end tests pass (`package-and-qa` manual pipeline job) - -/label ~database diff --git a/.gitlab/merge_request_templates/Documentation.md b/.gitlab/merge_request_templates/Documentation.md deleted file mode 100644 index da38a703c3c..00000000000 --- a/.gitlab/merge_request_templates/Documentation.md +++ /dev/null @@ -1,29 +0,0 @@ - - -## What does this MR do? - - - -## Related issues - - - -Closes - -## Moving docs to a new location? - -Read the guidelines: -https://docs.gitlab.com/ce/development/writing_documentation.html#changing-document-location - -- [ ] Make sure the old link is not removed and has its contents replaced with - a link to the new location. -- [ ] Make sure internal links pointing to the document in question are not broken. -- [ ] Search and replace any links referring to old docs in GitLab Rails app, - specifically under the `app/views/` and `ee/app/views` (for GitLab EE) directories. -- [ ] Make sure to add [`redirect_from`](https://docs.gitlab.com/ce/development/writing_documentation.html#redirections-for-pages-with-disqus-comments) - to the new document if there are any Disqus comments on the old document thread. -- [ ] If working on CE and the `ee-compat-check` jobs fails, submit an MR to EE - with the changes as well (https://docs.gitlab.com/ce/development/writing_documentation.html#cherry-picking-from-ce-to-ee). -- [ ] Ping one of the technical writers for review. - -/label ~Documentation diff --git a/.gitlab/route-map.yml b/.gitlab/route-map.yml deleted file mode 100644 index 0b37dc68f8b..00000000000 --- a/.gitlab/route-map.yml +++ /dev/null @@ -1,3 +0,0 @@ -# Documentation -- source: /doc/(.+?)\.md/ # doc/administration/build_artifacts.md - public: '\1.html' # doc/administration/build_artifacts.html diff --git a/.haml-lint.yml b/.haml-lint.yml deleted file mode 100644 index 32c7de0fb78..00000000000 --- a/.haml-lint.yml +++ /dev/null @@ -1,121 +0,0 @@ -# Whether to ignore frontmatter at the beginning of HAML documents for -# frameworks such as Jekyll/Middleman -skip_frontmatter: false -exclude: - - 'vendor/**/*' - - 'spec/**/*' - -linters: - AltText: - enabled: true - - ClassAttributeWithStaticValue: - enabled: true - - ClassesBeforeIds: - enabled: false - - ConsecutiveComments: - enabled: false - - ConsecutiveSilentScripts: - enabled: false - max_consecutive: 2 - - EmptyObjectReference: - enabled: true - - EmptyScript: - enabled: true - - FinalNewline: - enabled: true - present: true - - HtmlAttributes: - enabled: true - - IdNames: - enabled: false - - ImplicitDiv: - enabled: true - - InlineJavaScript: - enabled: true - - InlineStyles: - enabled: false - - InstanceVariables: - enabled: false - - LeadingCommentSpace: - enabled: false - - LineLength: - enabled: false - max: 80 - - MultilinePipe: - enabled: true - - MultilineScript: - enabled: true - - ObjectReferenceAttributes: - enabled: true - - RepeatedId: - enabled: false - - RuboCop: - enabled: false - # These cops are incredibly noisy when it comes to HAML templates, so we - # ignore them. - ignored_cops: - - Lint/BlockAlignment - - Lint/EndAlignment - - Lint/Void - - Metrics/LineLength - - Style/AlignParameters - - Style/BlockNesting - - Style/ElseAlignment - - Style/FileName - - Style/FinalNewline - - Style/FrozenStringLiteralComment - - Style/IfUnlessModifier - - Style/IndentationWidth - - Style/Next - - Style/TrailingBlankLines - - Style/TrailingWhitespace - - Style/WhileUntilModifier - - RubyComments: - enabled: true - - SpaceBeforeScript: - enabled: true - - SpaceInsideHashAttributes: - enabled: true - style: space - - Indentation: - enabled: true - character: space # or tab - - TagName: - enabled: true - - TrailingWhitespace: - enabled: true - - UnnecessaryInterpolation: - enabled: true - - UnnecessaryStringOutput: - enabled: true - - ViewLength: - enabled: false diff --git a/.mailmap b/.mailmap deleted file mode 100644 index bd5ac22132c..00000000000 --- a/.mailmap +++ /dev/null @@ -1,35 +0,0 @@ -# -# This list is used by git-shortlog to make contributions from the -# same person appearing to be so. -# - -Achilleas Pipinellis -Achilleas Pipinellis -Dmitriy Zaporozhets -Dmitriy Zaporozhets -Douwe Maan -Douwe Maan -Grzegorz Bizon -Grzegorz Bizon -Jacob Vosmaer -Jacob Vosmaer Jacob Vosmaer (GitLab) -Jacob Schatz -Jacob Schatz -Jacob Schatz -James Lopez -James Lopez -Kamil Trzciński -Marin Jankovski -Phil Hughes -Rémy Coutable -Robert Schilling -Robert Schilling -Robert Speicher -Stan Hu -Stan Hu -Stan Hu -Stan Hu stanhu -Sytse Sijbrandij -Sytse Sijbrandij -Sytse Sijbrandij -Sytse Sijbrandij dosire diff --git a/.nvmrc b/.nvmrc deleted file mode 100644 index f7ee06693c1..00000000000 --- a/.nvmrc +++ /dev/null @@ -1 +0,0 @@ -9.0.0 diff --git a/.pkgr.yml b/.pkgr.yml deleted file mode 100644 index 10bcd7bd4bd..00000000000 --- a/.pkgr.yml +++ /dev/null @@ -1,49 +0,0 @@ -user: git -group: git -services: - - postgres -before_precompile: ./bin/pkgr_before_precompile.sh -env: - - SKIP_STORAGE_VALIDATION=true -targets: - debian-7: &wheezy - build_dependencies: - - libkrb5-dev - - libicu-dev - - cmake - - pkg-config - dependencies: - - libicu48 - - libpcre3 - - git - ubuntu-12.04: *wheezy - ubuntu-14.04: - build_dependencies: - - libkrb5-dev - - libicu-dev - - cmake - - pkg-config - dependencies: - - libicu52 - - libpcre3 - - git - ubuntu-16.04: - build_dependencies: - - libkrb5-dev - - libicu-dev - - cmake - - pkg-config - dependencies: - - libicu55 - - libpcre3 - - git - centos-6: - build_dependencies: - - krb5-devel - - libicu-devel - - cmake - - pkgconfig - dependencies: - - libicu - - pcre - - git diff --git a/.prettierignore b/.prettierignore deleted file mode 100644 index b674ccd50cf..00000000000 --- a/.prettierignore +++ /dev/null @@ -1,5 +0,0 @@ -/app/assets/javascripts/locale/**/app.js -/node_modules/ -/public/ -/vendor/ -/tmp/ diff --git a/.prettierrc b/.prettierrc deleted file mode 100644 index 3384551aea5..00000000000 --- a/.prettierrc +++ /dev/null @@ -1,13 +0,0 @@ -{ - "printWidth": 100, - "singleQuote": true, - "trailingComma": "es5", - "overrides": [ - { - "files": ["**/app/**/*", "**/spec/**/*"], - "options": { - "trailingComma": "all" - } - } - ] -} diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index 0582bfe8d70..00000000000 --- a/.rubocop.yml +++ /dev/null @@ -1,135 +0,0 @@ -inherit_gem: - gitlab-styles: - - rubocop-default.yml - -inherit_from: .rubocop_todo.yml -require: ./rubocop/rubocop - -AllCops: - TargetRailsVersion: 4.2 - Exclude: - - 'vendor/**/*' - - 'node_modules/**/*' - - 'db/**/*' - - 'db/fixtures/**/*' - - 'ee/db/**/*' - - 'tmp/**/*' - - 'bin/**/*' - - 'generator_templates/**/*' - - 'builds/**/*' - - 'plugins/**/*' - CacheRootDirectory: tmp - -# This cop checks whether some constant value isn't a -# mutable literal (e.g. array or hash). -Style/MutableConstant: - Enabled: true - Exclude: - - 'db/migrate/**/*' - - 'db/post_migrate/**/*' - - 'ee/db/migrate/**/*' - - 'ee/db/post_migrate/**/*' - - 'ee/db/geo/migrate/**/*' - -Naming/FileName: - ExpectMatchingDefinition: true - Exclude: - - 'spec/**/*' - - 'features/**/*' - - 'ee/spec/**/*' - - 'qa/spec/**/*' - - 'qa/qa/specs/**/*' - - 'qa/bin/*' - - 'config/**/*' - - 'lib/generators/**/*' - - 'ee/lib/generators/**/*' - IgnoreExecutableScripts: true - AllowedAcronyms: - - EE - - JSON - - LDAP - - IO - - HMAC - - QA - - ENV - - STL - - PDF - - SVG - - CTE - - DN - - RSA - - CI - - CD - - OAuth - # default ones: - - CLI - - DSL - - ACL - - API - - ASCII - - CPU - - CSS - - DNS - - EOF - - GUID - - HTML - - HTTP - - HTTPS - - ID - - IP - - JSON - - LHS - - QPS - - RAM - - RHS - - RPC - - SLA - - SMTP - - SQL - - SSH - - TCP - - TLS - - TTL - - UDP - - UI - - UID - - UUID - - URI - - URL - - UTF8 - - VM - - XML - - XMPP - - XSRF - - XSS - -# Gitlab ################################################################### - -Gitlab/ModuleWithInstanceVariables: - Enable: true - Exclude: - # We ignore Rails helpers right now because it's hard to workaround it - - app/helpers/**/*_helper.rb - - ee/app/helpers/**/*_helper.rb - # We ignore Rails mailers right now because it's hard to workaround it - - app/mailers/emails/**/*.rb - - ee/**/emails/**/*.rb - # We ignore spec helpers because it usually doesn't matter - - spec/support/**/*.rb - - features/steps/**/*.rb - -Gitlab/HTTParty: - Enabled: true - -GitlabSecurity/PublicSend: - Enabled: true - Exclude: - - 'config/**/*' - - 'db/**/*' - - 'features/**/*' - - 'lib/**/*.rake' - - 'qa/**/*' - - 'spec/**/*' - - 'ee/db/**/*' - - 'ee/lib/**/*.rake' - - 'ee/spec/**/*' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index ccf301e6c78..00000000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,845 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2018-01-18 18:23:26 +0100 using RuboCop version 0.52.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 181 -Capybara/CurrentPathExpectation: - Enabled: false - -# Offense count: 956 -Capybara/FeatureMethods: - Enabled: false - -# Offense count: 23 -FactoryBot/DynamicAttributeDefinedStatically: - Exclude: - - 'spec/factories/broadcast_messages.rb' - - 'spec/factories/ci/builds.rb' - - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - - 'spec/factories/clusters/platforms/kubernetes.rb' - - 'spec/factories/emails.rb' - - 'spec/factories/gpg_keys.rb' - - 'spec/factories/group_members.rb' - - 'spec/factories/merge_requests.rb' - - 'spec/factories/notes.rb' - - 'spec/factories/oauth_access_grants.rb' - - 'spec/factories/project_members.rb' - - 'spec/factories/todos.rb' - - 'spec/factories/uploads.rb' - -# Offense count: 167 -# Cop supports --auto-correct. -Layout/EmptyLinesAroundArguments: - Enabled: false - -# Offense count: 253 -# Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. -Layout/ExtraSpacing: - Enabled: false - -# Offense count: 83 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_brackets -Layout/IndentArray: - Enabled: false - -# Offense count: 237 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/IndentHash: - Enabled: false - -# Offense count: 11 -# Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment. -Layout/SpaceBeforeFirstArg: - Exclude: - - 'config/routes/project.rb' - - 'db/migrate/20170506185517_add_foreign_key_pipeline_schedules_and_pipelines.rb' - - 'features/steps/project/source/browse_files.rb' - - 'features/steps/project/source/markdown_render.rb' - - 'lib/api/runners.rb' - - 'spec/features/search/user_uses_search_filters_spec.rb' - - 'spec/routing/project_routing_spec.rb' - - 'spec/services/system_note_service_spec.rb' - -# Offense count: 93 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: require_no_space, require_space -Layout/SpaceInLambdaLiteral: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBrackets: space, no_space -Layout/SpaceInsideArrayLiteralBrackets: - Exclude: - - 'spec/lib/gitlab/import_export/relation_factory_spec.rb' - -# Offense count: 327 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -# SupportedStyles: space, no_space -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceInsideBlockBraces: - Enabled: false - -# Offense count: 156 -# Cop supports --auto-correct. -Layout/SpaceInsideParens: - Enabled: false - -# Offense count: 14 -# Cop supports --auto-correct. -Layout/SpaceInsidePercentLiteralDelimiters: - Exclude: - - 'lib/gitlab/git_access.rb' - - 'lib/gitlab/health_checks/fs_shards_check.rb' - - 'spec/lib/gitlab/health_checks/fs_shards_check_spec.rb' - -# Offense count: 26 -Lint/DuplicateMethods: - Exclude: - - 'app/models/application_setting.rb' - - 'app/models/commit.rb' - - 'app/models/note.rb' - - 'app/services/merge_requests/merge_service.rb' - - 'lib/bitbucket/representation/repo.rb' - - 'lib/declarative_policy/base.rb' - - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - - 'lib/gitlab/cycle_analytics/base_event_fetcher.rb' - - 'lib/gitlab/diff/formatters/base_formatter.rb' - - 'lib/gitlab/git/blob.rb' - - 'lib/gitlab/git/repository.rb' - - 'lib/gitlab/git/tree.rb' - - 'lib/gitlab/git/wiki_page.rb' - - 'lib/gitlab/auth/ldap/person.rb' - - 'lib/gitlab/auth/o_auth/user.rb' - -# Offense count: 4 -Lint/InterpolationCheck: - Exclude: - - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - - 'spec/features/users_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' - -# Offense count: 206 -# Configuration parameters: MaximumRangeSize. -Lint/MissingCopEnableDirective: - Enabled: false - -# Offense count: 2 -Lint/NestedPercentLiteral: - Exclude: - - 'lib/gitlab/git/repository.rb' - - 'spec/support/shared_examples/email_format_shared_examples.rb' - -# Offense count: 1 -Lint/ReturnInVoidContext: - Exclude: - - 'app/models/project.rb' - -# Offense count: 1 -# Configuration parameters: IgnoreImplicitReferences. -Lint/ShadowedArgument: - Exclude: - - 'lib/gitlab/database/sha_attribute.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -Lint/UnneededRequireStatement: - Exclude: - - 'db/post_migrate/20161221153951_rename_reserved_project_names.rb' - - 'db/post_migrate/20170313133418_rename_more_reserved_project_names.rb' - - 'lib/declarative_policy.rb' - -# Offense count: 9 -Lint/UriEscapeUnescape: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/models/project_services/drone_ci_service.rb' - - 'spec/lib/google_api/auth_spec.rb' - - 'spec/requests/api/files_spec.rb' - - 'spec/requests/api/internal_spec.rb' - - 'spec/requests/api/issues_spec.rb' - -# Offense count: 1 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1310 - -# Offense count: 2 -Naming/ConstantName: - Exclude: - - 'lib/gitlab/import_sources.rb' - - 'lib/gitlab/ssh_public_key.rb' - -# Offense count: 11 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: lowercase, uppercase -Naming/HeredocDelimiterCase: - Exclude: - - 'spec/lib/gitlab/diff/parser_spec.rb' - - 'spec/lib/json_web_token/rsa_token_spec.rb' - - 'spec/models/commit_spec.rb' - - 'spec/support/helpers/repo_helpers.rb' - - 'spec/support/helpers/seed_repo.rb' - -# Offense count: 112 -# Configuration parameters: Blacklist. -# Blacklist: END, (?-mix:EO[A-Z]{1}) -Naming/HeredocDelimiterNaming: - Enabled: false - -# Offense count: 27 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect. -Performance/HashEachMethods: - Enabled: false - -# Offense count: 1 -Performance/UnfreezeString: - Exclude: - - 'features/steps/project/commits/commits.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Performance/UriDefaultParser: - Exclude: - - 'lib/gitlab/url_sanitizer.rb' - -# Offense count: 3821 -# Configuration parameters: Prefixes. -# Prefixes: when, with, without -RSpec/ContextWording: - Enabled: false - -# Offense count: 293 -RSpec/EmptyLineAfterFinalLet: - Enabled: false - -# Offense count: 188 -RSpec/EmptyLineAfterSubject: - Enabled: false - -# Offense count: 258 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: method_call, block -RSpec/ExpectChange: - Enabled: false - -# Offense count: 221 -RSpec/ExpectInHook: - Enabled: false - -# Offense count: 7 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: implicit, each, example -RSpec/HookArgument: - Exclude: - - 'spec/spec_helper.rb' - - 'spec/support/carrierwave.rb' - - 'spec/support/db_cleaner.rb' - - 'spec/support/gitaly.rb' - - 'spec/support/setup_builds_storage.rb' - -# Offense count: 19 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: it_behaves_like, it_should_behave_like -RSpec/ItBehavesLike: - Exclude: - - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/shell_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/workers/git_garbage_collect_worker_spec.rb' - -# Offense count: 5 -RSpec/IteratedExpectation: - Exclude: - - 'spec/features/admin/admin_settings_spec.rb' - - 'spec/features/merge_requests/diff_notes_resolve_spec.rb' - - 'spec/features/projects/awards/user_interacts_with_awards_in_issue_spec.rb' - - 'spec/lib/gitlab/gitlab_import/client_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - -# Offense count: 75 -RSpec/LetBeforeExamples: - Exclude: - - 'spec/controllers/projects/commit_controller_spec.rb' - - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/user_reference_filter_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/models/commit_range_spec.rb' - - 'spec/models/milestone_spec.rb' - - 'spec/models/project_services/packagist_service_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/views/ci/lints/show.html.haml_spec.rb' - -# Offense count: 1 -RSpec/MultipleSubjects: - Exclude: - - 'spec/services/merge_requests/create_from_issue_service_spec.rb' - -# Offense count: 4 -RSpec/OverwritingSetup: - Exclude: - - 'spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb' - - 'spec/models/email_spec.rb' - - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - - 'spec/services/notes/quick_actions_service_spec.rb' - -# Offense count: 965 -# Configuration parameters: Strict, EnforcedStyle. -# SupportedStyles: inflected, explicit -RSpec/PredicateMatcher: - Enabled: false - -# Offense count: 35 -RSpec/RepeatedExample: - Enabled: false - -# Offense count: 140 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: and_return, block -RSpec/ReturnFromStub: - Enabled: false - -# Offense count: 112 -RSpec/ScatteredLet: - Enabled: false - -# Offense count: 22 -RSpec/ScatteredSetup: - Exclude: - - 'spec/controllers/projects/templates_controller_spec.rb' - - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - - 'spec/lib/gitlab/git/env_spec.rb' - - 'spec/requests/api/jobs_spec.rb' - - 'spec/services/projects/create_service_spec.rb' - -# Offense count: 1 -RSpec/SharedContext: - Exclude: - - 'spec/features/admin/admin_groups_spec.rb' - -# Offense count: 5 -RSpec/VoidExpect: - Exclude: - - 'spec/features/projects/artifacts/download_spec.rb' - - 'spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb' - - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/runner_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - -# Offense count: 41 -# Configuration parameters: Include. -# Include: db/migrate/*.rb -Rails/CreateTableWithTimestamps: - Enabled: false - -# Offense count: 155 -Rails/FilePath: - Enabled: false - -# Offense count: 121 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/HasManyOrHasOneDependent: - Enabled: false - -# Offense count: 157 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/InverseOf: - Enabled: false - -# Offense count: 48 -# Configuration parameters: Include. -# Include: app/controllers/**/*.rb -Rails/LexicallyScopedActionFilter: - Enabled: false - -# Offense count: 14 -# Cop supports --auto-correct. -Rails/Presence: - Exclude: - - 'app/controllers/projects/blob_controller.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/clusters/platforms/kubernetes.rb' - - 'app/models/concerns/mentionable.rb' - - 'app/models/concerns/token_authenticatable.rb' - - 'app/models/project_services/hipchat_service.rb' - - 'app/models/project_services/irker_service.rb' - - 'app/models/project_services/jira_service.rb' - - 'app/models/project_services/kubernetes_service.rb' - - 'app/models/project_services/packagist_service.rb' - - 'app/models/wiki_page.rb' - - 'lib/gitlab/git/hook.rb' - - 'lib/gitlab/github_import/importer/releases_importer.rb' - -# Offense count: 2 -# Configuration parameters: Include. -# Include: db/migrate/*.rb -Rails/ReversibleMigration: - Exclude: - - 'db/migrate/20160824103857_drop_unused_ci_tables.rb' - -# Offense count: 446 -# Configuration parameters: Blacklist. -# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters -Rails/SkipsModelValidations: - Enabled: false - -# Offense count: 1 -# Configuration parameters: Environments. -# Environments: development, test, production -Rails/UnknownEnv: - Exclude: - - 'db/migrate/20171124125748_populate_missing_merge_request_statuses.rb' - -# Offense count: 13 -# Cop supports --auto-correct. -Security/YAMLLoad: - Exclude: - - 'config/initializers/carrierwave.rb' - - 'lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits.rb' - - 'lib/gitlab/redis/wrapper.rb' - - 'lib/system_check/incoming_email/imap_authentication_check.rb' - - 'spec/config/mail_room_spec.rb' - - 'spec/initializers/secret_token_spec.rb' - - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/project_services/kubernetes_service_spec.rb' - -# Offense count: 64 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: percent_q, bare_percent -Style/BarePercentLiterals: - Enabled: false - -# Offense count: 5 -Style/CommentedKeyword: - Exclude: - - 'lib/tasks/gitlab/backup.rake' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - -# Offense count: 30 -Style/DateTime: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/Dir: - Exclude: - - 'qa/qa.rb' - -# Offense count: 9 -# Cop supports --auto-correct. -Style/EachWithObject: - Exclude: - - 'config/initializers/gollum.rb' - - 'lib/expand_variables.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ee_compat_check.rb' - - 'lib/gitlab/hook_data/issuable_builder.rb' - - 'lib/gitlab/i18n/po_linter.rb' - - 'lib/gitlab/import_export/members_mapper.rb' - - 'lib/gitlab/import_export/relation_factory.rb' - - 'scripts/static-analysis' - -# Offense count: 24 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty, nil, both -Style/EmptyElse: - Enabled: false - -# Offense count: 14 -# Cop supports --auto-correct. -Style/EmptyLambdaParameter: - Exclude: - - 'app/models/ci/build.rb' - - 'app/models/ci/runner.rb' - -# Offense count: 12 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Exclude: - - 'features/steps/project/commits/commits.rb' - - 'lib/gitlab/fogbugz_import/importer.rb' - - 'lib/gitlab/git/diff_collection.rb' - - 'lib/gitlab/gitaly_client.rb' - - 'scripts/trigger-build' - - 'spec/features/merge_requests/versions_spec.rb' - - 'spec/helpers/merge_requests_helper_spec.rb' - - 'spec/lib/gitlab/request_context_spec.rb' - - 'spec/lib/gitlab/workhorse_spec.rb' - - 'spec/requests/api/jobs_spec.rb' - - 'spec/support/shared_examples/chat_slash_commands_shared_examples.rb' - -# Offense count: 102 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: compact, expanded -Style/EmptyMethod: - Enabled: false - -# Offense count: 23 -# Cop supports --auto-correct. -Style/Encoding: - Enabled: false - -# Offense count: 2 -Style/EvalWithLocation: - Exclude: - - 'app/models/service.rb' - -# Offense count: 35 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: format, sprintf, percent -Style/FormatString: - Enabled: false - -# Offense count: 384 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false - -# Offense count: 22 -Style/IfInsideElse: - Enabled: false - -# Offense count: 809 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Enabled: false - -# Offense count: 75 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: line_count_dependent, lambda, literal -Style/Lambda: - Enabled: false - -# Offense count: 11 -# Cop supports --auto-correct. -Style/LineEndConcatenation: - Exclude: - - 'app/helpers/tree_helper.rb' - - 'spec/features/issuables/markdown_references_spec.rb' - - 'spec/lib/gitlab/checks/project_moved_spec.rb' - - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - -# Offense count: 39 -# Cop supports --auto-correct. -Style/MethodCallWithoutArgsParentheses: - Enabled: false - -# Offense count: 18 -Style/MethodMissing: - Enabled: false - -# Offense count: 7 -Style/MixinUsage: - Exclude: - - 'features/support/env.rb' - - 'spec/factories/ci/builds.rb' - - 'spec/factories/ci/job_artifacts.rb' - - 'spec/factories/lfs_objects.rb' - - 'spec/factories/notes.rb' - - 'spec/lib/gitlab/import_export/project_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/version_checker_spec.rb' - -# Offense count: 6 -# Cop supports --auto-correct. -Style/MultilineIfModifier: - Exclude: - - 'app/helpers/snippets_helper.rb' - - 'app/models/project_wiki.rb' - - 'app/services/ci/process_pipeline_service.rb' - - 'app/services/create_deployment_service.rb' - - 'lib/api/commit_statuses.rb' - - 'lib/gitlab/ci/trace.rb' - -# Offense count: 25 -# Cop supports --auto-correct. -# Configuration parameters: Whitelist. -# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with -Style/NestedParenthesizedCalls: - Enabled: false - -# Offense count: 19 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, MinBodyLength. -# SupportedStyles: skip_modifier_ifs, always -Style/Next: - Enabled: false - -# Offense count: 61 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedOctalStyle. -# SupportedOctalStyles: zero_with_o, zero_only -Style/NumericLiteralPrefix: - Enabled: false - -# Offense count: 114 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle. -# SupportedStyles: predicate, comparison -Style/NumericPredicate: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -Style/OrAssignment: - Exclude: - - 'app/models/concerns/token_authenticatable.rb' - - 'lib/api/commit_statuses.rb' - - 'lib/gitlab/project_transfer.rb' - -# Offense count: 50 -# Cop supports --auto-correct. -Style/ParallelAssignment: - Enabled: false - -# Offense count: 917 -# Cop supports --auto-correct. -# Configuration parameters: PreferredDelimiters. -Style/PercentLiteralDelimiters: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Exclude: - - 'app/controllers/projects/application_controller.rb' - - 'app/helpers/submodule_helper.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/abstract_reference_filter.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/emoji_filter.rb' - - 'lib/banzai/filter/gollum_tags_filter.rb' - - 'lib/expand_variables.rb' - - 'lib/gitlab/diff/highlight.rb' - - 'lib/gitlab/search_results.rb' - - 'lib/gitlab/sherlock/query.rb' - -# Offense count: 87 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Style/RedundantBegin: - Exclude: - - 'app/controllers/projects/clusters/gcp_controller.rb' - - 'app/models/merge_request.rb' - - 'app/services/projects/import_service.rb' - - 'lib/api/branches.rb' - - 'lib/gitlab/current_settings.rb' - - 'lib/gitlab/git/commit.rb' - - 'lib/gitlab/health_checks/base_abstract_check.rb' - - 'lib/tasks/gitlab/task_helpers.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/RedundantConditional: - Exclude: - - 'lib/system_check/helpers.rb' - -# Offense count: 57 -# Cop supports --auto-correct. -Style/RedundantFreeze: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/groups/application_controller.rb' - - 'app/controllers/omniauth_callbacks_controller.rb' - - 'app/controllers/profiles/keys_controller.rb' - - 'app/controllers/projects/application_controller.rb' - - 'app/services/access_token_validation_service.rb' - - 'lib/gitlab/utils.rb' - - 'lib/google_api/auth.rb' - -# Offense count: 460 -# Cop supports --auto-correct. -Style/RedundantSelf: - Enabled: false - -# Offense count: 142 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: - Enabled: true - EnforcedStyle: mixed - AllowInnerSlashes: false - -# Offense count: 36 -# Cop supports --auto-correct. -Style/RescueModifier: - Enabled: false - -# Offense count: 107 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: implicit, explicit -Style/RescueStandardError: - Enabled: false - -# Offense count: 92 -# Cop supports --auto-correct. -# Configuration parameters: ConvertCodeThatCanStartToReturnNil. -Style/SafeNavigation: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -Style/SelfAssignment: - Exclude: - - 'app/models/concerns/bulk_member_access_load.rb' - - 'app/serializers/base_serializer.rb' - - 'app/services/notification_service.rb' - - 'lib/api/runners.rb' - - 'spec/features/merge_requests/diff_notes_resolve_spec.rb' - - 'spec/features/projects/clusters/interchangeability_spec.rb' - - 'spec/support/import_export/configuration_helper.rb' - -# Offense count: 50 -# Cop supports --auto-correct. -# Configuration parameters: AllowIfMethodIsEmpty. -Style/SingleLineMethods: - Exclude: - - 'lib/gitlab/ci/ansi2html.rb' - -# Offense count: 66 -# Cop supports --auto-correct. -# Configuration parameters: . -# SupportedStyles: use_perl_names, use_english_names -Style/SpecialGlobalVars: - EnforcedStyle: use_perl_names - -# Offense count: 1 -# Cop supports --auto-correct. -Style/StderrPuts: - Exclude: - - 'config/initializers/rspec_profiling.rb' - -# Offense count: 45 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiteralsInInterpolation: - Enabled: false - -# Offense count: 106 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -# IgnoredMethods: respond_to, define_method -Style/SymbolProc: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, AllowSafeAssignment. -# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex -Style/TernaryParentheses: - Exclude: - - 'app/finders/projects_finder.rb' - - 'app/helpers/namespaces_helper.rb' - - 'features/support/capybara.rb' - - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - - 'spec/requests/api/pipeline_schedules_spec.rb' - - 'spec/support/capybara.rb' - -# Offense count: 17 -# Cop supports --auto-correct. -# Configuration parameters: AllowNamedUnderscoreVariables. -Style/TrailingUnderscoreVariable: - Exclude: - - 'app/controllers/admin/background_jobs_controller.rb' - - 'app/controllers/invites_controller.rb' - - 'app/helpers/tab_helper.rb' - - 'lib/backup/manager.rb' - - 'lib/gitlab/logger.rb' - - 'lib/gitlab/upgrader.rb' - - 'lib/system_check/app/migrations_are_up_check.rb' - - 'lib/system_check/incoming_email/mail_room_running_check.rb' - - 'lib/tasks/gitlab/check.rake' - - 'lib/tasks/gitlab/task_helpers.rb' - - 'spec/lib/gitlab/etag_caching/middleware_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' - -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. -# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym -Style/TrivialAccessors: - Exclude: - - 'app/models/external_issue.rb' - - 'app/serializers/base_serializer.rb' - - 'lib/gitlab/auth/ldap/person.rb' - - 'lib/system_check/base_check.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -Style/UnlessElse: - Exclude: - - 'lib/backup/manager.rb' - - 'lib/gitlab/project_search_results.rb' - - 'lib/tasks/gitlab/check.rake' - - 'spec/features/issues/award_emoji_spec.rb' - -# Offense count: 31 -# Cop supports --auto-correct. -Style/UnneededInterpolation: - Enabled: false - -# Offense count: 11 -# Cop supports --auto-correct. -Style/ZeroLengthPredicate: - Exclude: - - 'app/models/deploy_key.rb' - - 'app/models/network/commit.rb' - - 'app/models/network/graph.rb' - - 'app/models/project_services/asana_service.rb' - - 'app/services/boards/create_service.rb' - - 'app/services/merge_requests/conflicts/list_service.rb' - - 'lib/declarative_policy/dsl.rb' - - 'lib/extracts_path.rb' - - 'lib/gitlab/git/repository.rb' - -# Offense count: 22840 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1310 diff --git a/.ruby-version b/.ruby-version deleted file mode 100644 index 79a614418f7..00000000000 --- a/.ruby-version +++ /dev/null @@ -1 +0,0 @@ -2.4.4 diff --git a/.scss-lint.yml b/.scss-lint.yml deleted file mode 100644 index 3df66033fa8..00000000000 --- a/.scss-lint.yml +++ /dev/null @@ -1,273 +0,0 @@ -# Linter Documentation: -# https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md - -scss_files: 'app/assets/stylesheets/**/*.scss' - -exclude: - - 'app/assets/stylesheets/pages/emojis.scss' - -linters: - # Reports when you use improper spacing around ! (the "bang") in !default, - # !global, !important, and !optional flags. - BangFormat: - enabled: true - - # Whether or not to prefer `border: 0` over `border: none`. - BorderZero: - enabled: true - - # Reports when you define a rule set using a selector with chained classes - # (a.k.a. adjoining classes). - ChainedClasses: - enabled: false - - # Prefer hexadecimal color codes over color keywords. - # (e.g. `color: green` is a color keyword) - ColorKeyword: - enabled: false - - # Prefer color literals (keywords or hexadecimal codes) to be used only in - # variable declarations. They should be referred to via variables everywhere - # else. - ColorVariable: - enabled: true - - # Which form of comments to prefer in CSS. - Comment: - enabled: false - - # Reports @debug statements (which you probably left behind accidentally). - DebugStatement: - enabled: false - - # Rule sets should be ordered as follows: - # - @extend declarations - # - @include declarations without inner @content - # - properties - # - @include declarations with inner @content - # - nested rule sets. - # Disabled to minimize Bootstrap migration footprint - DeclarationOrder: - enabled: false - - # `scss-lint:disable` control comments should be preceded by a comment - # explaining why these linters are being disabled for this file. - # See https://github.com/brigade/scss-lint#disabling-linters-via-source for - # more information. - DisableLinterReason: - enabled: true - - # Reports when you define the same property twice in a single rule set. - DuplicateProperty: - enabled: true - ignore_consecutive: - - cursor - - # Separate rule, function, and mixin declarations with empty lines. - EmptyLineBetweenBlocks: - enabled: true - - # Reports when you have an empty rule set. - EmptyRule: - enabled: true - - # Reports when you have an @extend directive. - ExtendDirective: - enabled: false - - # Files should always have a final newline. This results in better diffs - # when adding lines to the file, since SCM systems such as git won't - # think that you touched the last line. - FinalNewline: - enabled: true - - # HEX colors should use three-character values where possible. - HexLength: - enabled: false - - # HEX color values should use lower-case colors to differentiate between - # letters and numbers, e.g. `#E3E3E3` vs. `#e3e3e3`. - HexNotation: - enabled: true - - # Avoid using ID selectors. - IdSelector: - enabled: false - - # The basenames of @imported SCSS partials should not begin with an - # underscore and should not include the filename extension. - ImportPath: - enabled: true - - # Avoid using !important in properties. It is usually indicative of a - # misunderstanding of CSS specificity and can lead to brittle code. - ImportantRule: - enabled: false - - # Indentation should always be done in increments of 2 spaces. - Indentation: - enabled: true - width: 2 - - # Don't write leading zeros for numeric values with a decimal point. - LeadingZero: - enabled: false - - # Reports when you define the same selector twice in a single sheet. - MergeableSelector: - enabled: true - - # Functions, mixins, variables, and placeholders should be declared - # with all lowercase letters and hyphens instead of underscores. - NameFormat: - enabled: false - - # Avoid nesting selectors too deeply. - NestingDepth: - enabled: true - max_depth: 6 - - # Always use placeholder selectors in @extend. - PlaceholderInExtend: - enabled: false - - # Sort properties in a strict order. - PropertySortOrder: - enabled: false - - # Reports when you use an unknown or disabled CSS property - # (ignoring vendor-prefixed properties). - PropertySpelling: - enabled: true - - # Configure which units are allowed for property values. - PropertyUnits: - enabled: false - - # Pseudo-elements, like ::before, and ::first-letter, should be declared - # with two colons. Pseudo-classes, like :hover and :first-child, should - # be declared with one colon. - PseudoElement: - enabled: true - - # Avoid qualifying elements in selectors (also known as "tag-qualifying"). - QualifyingElement: - enabled: false - - # Don't write selectors with a depth of applicability greater than 3. - SelectorDepth: - enabled: false - - # Selectors should always use hyphenated-lowercase, rather than camelCase or - # snake_case. - SelectorFormat: - enabled: false - convention: hyphenated_lowercase - - # Prefer the shortest shorthand form possible for properties that support it. - Shorthand: - enabled: true - - # Each property should have its own line, except in the special case of - # single line rulesets. - SingleLinePerProperty: - enabled: true - allow_single_line_rule_sets: true - - # Split selectors onto separate lines after each comma, and have each - # individual selector occupy a single line. - SingleLinePerSelector: - enabled: true - - # Commas in lists should be followed by a space. - SpaceAfterComma: - enabled: true - - # Comment literals should be followed by a space. - SpaceAfterComment: - enabled: false - - # Properties should be formatted with a single space separating the colon - # from the property's value. - SpaceAfterPropertyColon: - enabled: true - - # Properties should be formatted with no space between the name and the - # colon. - SpaceAfterPropertyName: - enabled: true - - # Variables should be formatted with a single space separating the colon - # from the variable's value. - SpaceAfterVariableColon: - enabled: true - - # Variables should be formatted with no space between the name and the - # colon. - SpaceAfterVariableName: - enabled: false - - # Operators should be formatted with a single space on both sides of an - # infix operator. - SpaceAroundOperator: - enabled: true - - # Opening braces should be preceded by a single space. - SpaceBeforeBrace: - enabled: true - - # Parentheses should not be padded with spaces. - SpaceBetweenParens: - enabled: false - - # Enforces that string literals should be written with a consistent form - # of quotes (single or double). - StringQuotes: - enabled: false - - # Property values, @extend, @include, and @import directives, and variable - # declarations should always end with a semicolon. - TrailingSemicolon: - enabled: true - - # Reports lines containing trailing whitespace. - TrailingWhitespace: - enabled: true - - # Don't write trailing zeros for numeric values with a decimal point. - TrailingZero: - enabled: false - - # Don't use the `all` keyword to specify transition properties. - TransitionAll: - enabled: false - - # Numeric values should not contain unnecessary fractional portions. - UnnecessaryMantissa: - enabled: true - - # Do not use parent selector references (&) when they would otherwise - # be unnecessary. - UnnecessaryParentReference: - enabled: true - - # URLs should be valid and not contain protocols or domain names. - UrlFormat: - enabled: true - - # URLs should always be enclosed within quotes. - UrlQuotes: - enabled: true - - # Properties, like color and font, are easier to read and maintain - # when defined using variables rather than literals. - VariableForProperty: - enabled: false - - # Avoid vendor prefixes. Or rather: don't write them yourself. - VendorPrefix: - enabled: false - - # Omit length units on zero values, e.g. `0px` vs. `0`. - ZeroUnit: - enabled: true -- cgit v1.2.1