From 54a50bf81d7bb304adaedffd8eb3e0bc0fc348a9 Mon Sep 17 00:00:00 2001 From: James Lopez Date: Fri, 1 Jul 2016 09:02:45 +0200 Subject: refactor url validator to use sanitizer for check --- app/validators/addressable_url_validator.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/validators/addressable_url_validator.rb b/app/validators/addressable_url_validator.rb index 63761c81721..09bfa613cbe 100644 --- a/app/validators/addressable_url_validator.rb +++ b/app/validators/addressable_url_validator.rb @@ -35,9 +35,7 @@ class AddressableUrlValidator < ActiveModel::EachValidator end def valid_uri?(value) - Addressable::URI.parse(value).is_a?(Addressable::URI) - rescue Addressable::URI::InvalidURIError - false + Gitlab::UrlSanitizer.valid?(value) end def valid_protocol?(value) -- cgit v1.2.1