From 3f5eea56a56d0b989d3c29731ff72333ae3f337f Mon Sep 17 00:00:00 2001 From: Simon Knox Date: Fri, 8 Sep 2017 09:21:19 +1000 Subject: correctly format boolean props Don't use standard attribute names --- .../vue_merge_request_widget/components/mr_widget_status_icon.js | 4 ++-- .../components/states/mr_widget_archived.js | 5 ++++- .../components/states/mr_widget_auto_merge_failed.js | 5 ++++- .../components/states/mr_widget_conflicts.js | 6 +++++- .../components/states/mr_widget_missing_branch.js | 6 +++++- .../components/states/mr_widget_pipeline_blocked.js | 6 +++++- .../components/states/mr_widget_pipeline_failed.js | 6 +++++- .../components/states/mr_widget_sha_mismatch.js | 6 +++++- .../components/states/mr_widget_unresolved_discussions.js | 6 +++++- .../vue_merge_request_widget/components/states/mr_widget_wip.js | 6 +++++- 10 files changed, 45 insertions(+), 11 deletions(-) diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.js b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.js index e0e3ab0e5ab..cfa29b97f5b 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.js +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.js @@ -4,7 +4,7 @@ import loadingIcon from '../../vue_shared/components/loading_icon.vue'; export default { props: { status: { type: String, required: true }, - disabled: { type: Boolean, required: false }, + iconDisabled: { type: Boolean, required: false }, showDisabledButton: { type: Boolean, required: false }, }, components: { @@ -14,7 +14,7 @@ export default { computed: { statusObj() { return { - group: this.disabled ? 'disabled' : this.status, + group: this.iconDisabled ? 'disabled' : this.status, icon: `icon_status_${this.status}`, }; }, diff --git a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_archived.js b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_archived.js index 9b1a2f638d4..b25f8519c0a 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_archived.js +++ b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_archived.js @@ -8,7 +8,10 @@ export default { template: `
- +