From 3b8286b1d1ccfac835a889975a953695f72f5991 Mon Sep 17 00:00:00 2001
From: Constance Okoghenun <cokoghenun@gitlab.com>
Date: Thu, 21 Dec 2017 15:28:54 +0100
Subject: Fixed broken lint rules in milestone_select.js

---
 app/assets/javascripts/milestone_select.js | 94 ++++++++++++++----------------
 1 file changed, 44 insertions(+), 50 deletions(-)

diff --git a/app/assets/javascripts/milestone_select.js b/app/assets/javascripts/milestone_select.js
index 3dd51c26120..b6af3f86d67 100644
--- a/app/assets/javascripts/milestone_select.js
+++ b/app/assets/javascripts/milestone_select.js
@@ -52,51 +52,49 @@ export default class MilestoneSelect {
       }
       return $dropdown.glDropdown({
         showMenuAbove: showMenuAbove,
-        data: (term, callback) => {
-          return $.ajax({
-            url: milestonesUrl
-          }).done((data) => {
-            const extraOptions = [];
-            if (showAny) {
-              extraOptions.push({
-                id: 0,
-                name: '',
-                title: 'Any Milestone'
-              });
-            }
-            if (showNo) {
-              extraOptions.push({
-                id: -1,
-                name: 'No Milestone',
-                title: 'No Milestone'
-              });
-            }
-            if (showUpcoming) {
-              extraOptions.push({
-                id: -2,
-                name: '#upcoming',
-                title: 'Upcoming'
-              });
-            }
-            if (showStarted) {
-              extraOptions.push({
-                id: -3,
-                name: '#started',
-                title: 'Started'
-              });
-            }
-            if (extraOptions.length) {
-              extraOptions.push('divider');
-            }
+        data: (term, callback) => $.ajax({
+          url: milestonesUrl
+        }).done((data) => {
+          const extraOptions = [];
+          if (showAny) {
+            extraOptions.push({
+              id: 0,
+              name: '',
+              title: 'Any Milestone'
+            });
+          }
+          if (showNo) {
+            extraOptions.push({
+              id: -1,
+              name: 'No Milestone',
+              title: 'No Milestone'
+            });
+          }
+          if (showUpcoming) {
+            extraOptions.push({
+              id: -2,
+              name: '#upcoming',
+              title: 'Upcoming'
+            });
+          }
+          if (showStarted) {
+            extraOptions.push({
+              id: -3,
+              name: '#started',
+              title: 'Started'
+            });
+          }
+          if (extraOptions.length) {
+            extraOptions.push('divider');
+          }
 
-            callback(extraOptions.concat(data));
-            if (showMenuAbove) {
-              $dropdown.data('glDropdown').positionMenuAbove();
-            }
-            $(`[data-milestone-id="${selectedMilestone}"] > a`).addClass('is-active');
-          });
-        },
-        renderRow: (milestone) => `
+          callback(extraOptions.concat(data));
+          if (showMenuAbove) {
+            $dropdown.data('glDropdown').positionMenuAbove();
+          }
+          $(`[data-milestone-id="${selectedMilestone}"] > a`).addClass('is-active');
+        }),
+        renderRow: milestone => `
           <li data-milestone-id="${milestone.name}">
             <a href='#' class='dropdown-menu-milestone-link'>
               ${_.escape(milestone.title)}
@@ -117,9 +115,7 @@ export default class MilestoneSelect {
         },
         defaultLabel: defaultLabel,
         fieldName: $dropdown.data('field-name'),
-        text: (milestone) => {
-          return _.escape(milestone.title);
-        },
+        text: milestone => _.escape(milestone.title),
         id: (milestone) => {
           if (!useId && !$dropdown.is('.js-issuable-form-dropdown')) {
             return milestone.name;
@@ -127,9 +123,7 @@ export default class MilestoneSelect {
             return milestone.id;
           }
         },
-        isSelected: (milestone) => {
-          return milestone.name === selectedMilestone;
-        },
+        isSelected: milestone => milestone.name === selectedMilestone,
         hidden: () => {
           $selectBox.hide();
           // display:block overrides the hide-collapse rule
-- 
cgit v1.2.1