From 53f83f2939226b01065a886921d59e459e5d0da4 Mon Sep 17 00:00:00 2001 From: Sanad Liaquat Date: Mon, 29 Oct 2018 14:55:48 +0500 Subject: Update definition of done with e2e tests requirement --- doc/development/contributing/merge_request_workflow.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index 1764e2d8b21..162d325e9b7 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -171,6 +171,7 @@ the feature you contribute through all of these steps. 1. Added to [the website](https://gitlab.com/gitlab-com/www-gitlab-com/), if relevant 1. Community questions answered 1. Answers to questions radiated (in docs/wiki/support etc.) +1. [Black-box tests or end-to-end tests][e2e-tests] added if required. Please contact [the dev stage quality team][dev-stage-quality-team] with any questions If you add a dependency in GitLab (such as an operating system package) please consider updating the following and note the applicability of each in your @@ -186,6 +187,8 @@ merge request: [definition-of-done]: http://guide.agilealliance.org/guide/definition-of-done.html [testing]: ../testing_guide/index.md +[e2e-tests]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/testing_guide/testing_levels.md#black-box-tests-or-end-to-end-tests +[dev-stage-quality-team]: https://about.gitlab.com/handbook/engineering/quality/dev-stage-team --- -- cgit v1.2.1 From fb49ee439a1d22195bba11f2e11fd1a66e2cade8 Mon Sep 17 00:00:00 2001 From: Sanad Liaquat Date: Thu, 1 Nov 2018 11:04:55 +0500 Subject: Changed dev stage team to quality team --- doc/development/contributing/merge_request_workflow.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index 162d325e9b7..bc94b4f9240 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -171,7 +171,7 @@ the feature you contribute through all of these steps. 1. Added to [the website](https://gitlab.com/gitlab-com/www-gitlab-com/), if relevant 1. Community questions answered 1. Answers to questions radiated (in docs/wiki/support etc.) -1. [Black-box tests or end-to-end tests][e2e-tests] added if required. Please contact [the dev stage quality team][dev-stage-quality-team] with any questions +1. [Black-box tests/end-to-end tests][e2e-tests] added if required. Please contact [the quality team][quality-team] with any questions If you add a dependency in GitLab (such as an operating system package) please consider updating the following and note the applicability of each in your @@ -188,7 +188,7 @@ merge request: [definition-of-done]: http://guide.agilealliance.org/guide/definition-of-done.html [testing]: ../testing_guide/index.md [e2e-tests]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/testing_guide/testing_levels.md#black-box-tests-or-end-to-end-tests -[dev-stage-quality-team]: https://about.gitlab.com/handbook/engineering/quality/dev-stage-team +[quality-team]: https://about.gitlab.com/handbook/engineering/quality/#teams --- -- cgit v1.2.1 From 2d973572e904a4c8da2894a250d2975940f3b546 Mon Sep 17 00:00:00 2001 From: Sanad Liaquat Date: Fri, 2 Nov 2018 18:09:35 +0500 Subject: Using inline links per review feedback --- doc/development/contributing/merge_request_workflow.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index bc94b4f9240..5b32b5cd46f 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -171,7 +171,7 @@ the feature you contribute through all of these steps. 1. Added to [the website](https://gitlab.com/gitlab-com/www-gitlab-com/), if relevant 1. Community questions answered 1. Answers to questions radiated (in docs/wiki/support etc.) -1. [Black-box tests/end-to-end tests][e2e-tests] added if required. Please contact [the quality team][quality-team] with any questions +1. [Black-box tests/end-to-end tests](../testing_guide/testing_levels.md#black-box-tests-or-end-to-end-tests) added if required. Please contact [the quality team](https://about.gitlab.com/handbook/engineering/quality/#teams) with any questions If you add a dependency in GitLab (such as an operating system package) please consider updating the following and note the applicability of each in your @@ -186,9 +186,7 @@ merge request: 1. Omnibus package creator https://gitlab.com/gitlab-org/omnibus-gitlab [definition-of-done]: http://guide.agilealliance.org/guide/definition-of-done.html -[testing]: ../testing_guide/index.md -[e2e-tests]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/testing_guide/testing_levels.md#black-box-tests-or-end-to-end-tests -[quality-team]: https://about.gitlab.com/handbook/engineering/quality/#teams +[testing]: ../testing_guide/index.md --- -- cgit v1.2.1