From 3581c6dbcc177429cb50f30e2315a8d82b3f14ec Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Wed, 18 Oct 2017 11:53:01 +0200 Subject: Improve spec --- spec/features/merge_requests/diff_notes_resolve_spec.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spec/features/merge_requests/diff_notes_resolve_spec.rb b/spec/features/merge_requests/diff_notes_resolve_spec.rb index 0ad40ca3fab..3db0729cafb 100644 --- a/spec/features/merge_requests/diff_notes_resolve_spec.rb +++ b/spec/features/merge_requests/diff_notes_resolve_spec.rb @@ -98,8 +98,6 @@ feature 'Diff notes resolve', :js do end describe 'timeline view' do - before do - end it 'hides when resolve discussion is clicked' do expect(page).to have_selector('.discussion-body', visible: false) end @@ -118,7 +116,7 @@ feature 'Diff notes resolve', :js do end it 'hides when resolve discussion is clicked' do - expect(find('.diffs .diff-file .notes_holder', visible: false)).not_to be_visible + expect(page).to have_selector('.diffs .diff-file .notes_holder', visible: false) end it 'shows resolved discussion when toggled' do -- cgit v1.2.1