From 34420f42b31dca02ba2fc9b4d35d40a6236cd692 Mon Sep 17 00:00:00 2001
From: Ezekiel Kigbo <ekigbo@gitlab.com>
Date: Fri, 28 Jun 2019 12:19:43 +1000
Subject: Moved feature access arrays to constants

---
 .../components/project_feature_setting.vue         |  6 ++---
 .../permissions/components/settings_panel.vue      | 15 ++++++++----
 .../pages/projects/shared/permissions/constants.js | 27 ++++++++++++++++++++++
 3 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
index bb2f080e4a2..533065b2d4d 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
@@ -1,6 +1,6 @@
 <script>
-import { __ } from '~/locale';
-import projectFeatureToggle from '../../../../../vue_shared/components/toggle_button.vue';
+import projectFeatureToggle from '~/vue_shared/components/toggle_button.vue';
+import { featureAccessLevelNone } from '../constants';
 
 export default {
   components: {
@@ -44,7 +44,7 @@ export default {
       if (this.featureEnabled) {
         return this.options;
       }
-      return [[0, __('Enable feature to choose access level')]];
+      return [featureAccessLevelNone];
     },
 
     displaySelectInput() {
diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
index 0078f483498..b4d24f3aa36 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
@@ -4,9 +4,16 @@ import { __ } from '~/locale';
 import projectFeatureSetting from './project_feature_setting.vue';
 import projectFeatureToggle from '~/vue_shared/components/toggle_button.vue';
 import projectSettingRow from './project_setting_row.vue';
-import { visibilityOptions, visibilityLevelDescriptions } from '../constants';
+import {
+  visibilityOptions,
+  visibilityLevelDescriptions,
+  featureAccessLevelMembers,
+  featureAccessLevelEveryone,
+} from '../constants';
 import { toggleHiddenClassBySelector } from '../external';
 
+const PAGE_FEATURE_ACCESS_LEVEL = __('Everyone');
+
 export default {
   components: {
     projectFeatureSetting,
@@ -103,9 +110,9 @@ export default {
 
   computed: {
     featureAccessLevelOptions() {
-      const options = [[10, __('Only Project Members')]];
+      const options = [featureAccessLevelMembers];
       if (this.visibilityLevel !== visibilityOptions.PRIVATE) {
-        options.push([20, __('Everyone With Access')]);
+        options.push(featureAccessLevelEveryone);
       }
       return options;
     },
@@ -118,7 +125,7 @@ export default {
 
     pagesFeatureAccessLevelOptions() {
       if (this.visibilityLevel !== visibilityOptions.PUBLIC) {
-        return this.featureAccessLevelOptions.concat([[30, __('Everyone')]]);
+        return this.featureAccessLevelOptions.concat([[30, PAGE_FEATURE_ACCESS_LEVEL]]);
       }
       return this.featureAccessLevelOptions;
     },
diff --git a/app/assets/javascripts/pages/projects/shared/permissions/constants.js b/app/assets/javascripts/pages/projects/shared/permissions/constants.js
index ac0dca31c37..73269c6f3ba 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/constants.js
+++ b/app/assets/javascripts/pages/projects/shared/permissions/constants.js
@@ -15,3 +15,30 @@ export const visibilityLevelDescriptions = {
     'The project can be accessed by anyone, regardless of authentication.',
   ),
 };
+
+const featureAccessLevel = {
+  NOT_ENABLED: 0,
+  PROJECT_MEMBERS: 10,
+  EVERYONE: 20,
+};
+
+const featureAccessLevelDescriptions = {
+  [featureAccessLevel.NOT_ENABLED]: __('Enable feature to choose access level'),
+  [featureAccessLevel.PROJECT_MEMBERS]: __('Only Project Members'),
+  [featureAccessLevel.EVERYONE]: __('Everyone With Access'),
+};
+
+export const featureAccessLevelNone = [
+  featureAccessLevel.NOT_ENABLED,
+  featureAccessLevelDescriptions[featureAccessLevel.NOT_ENABLED],
+];
+
+export const featureAccessLevelMembers = [
+  featureAccessLevel.PROJECT_MEMBERS,
+  featureAccessLevelDescriptions[featureAccessLevel.PROJECT_MEMBERS],
+];
+
+export const featureAccessLevelEveryone = [
+  featureAccessLevel.EVERYONE,
+  featureAccessLevelDescriptions[featureAccessLevel.EVERYONE],
+];
-- 
cgit v1.2.1