From 3129cbd555ef6770eb859614c08cc854ec07175f Mon Sep 17 00:00:00 2001 From: Thong Kuah Date: Thu, 20 Jun 2019 14:25:31 +1200 Subject: Run least expensive method first - has_metrics? Success is relatively cheap compared to prometheus_adapter which can invoke deployment_platform which does a lot of work --- app/models/deployment.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/deployment.rb b/app/models/deployment.rb index 92c7311014a..ee6e830d3ec 100644 --- a/app/models/deployment.rb +++ b/app/models/deployment.rb @@ -179,7 +179,7 @@ class Deployment < ApplicationRecord end def has_metrics? - prometheus_adapter&.can_query? && success? + success? && prometheus_adapter&.can_query? end def metrics -- cgit v1.2.1