From 30c99f41d03baa7e540dc647463418c3758362b1 Mon Sep 17 00:00:00 2001 From: Alex Kalderimis Date: Fri, 24 May 2019 14:40:36 -0400 Subject: Better parameter name the `file` parameter is not a file, it is the file content. --- lib/gitlab/manifest_import/manifest.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/gitlab/manifest_import/manifest.rb b/lib/gitlab/manifest_import/manifest.rb index e18521fcdd4..df785e94d2e 100644 --- a/lib/gitlab/manifest_import/manifest.rb +++ b/lib/gitlab/manifest_import/manifest.rb @@ -18,8 +18,8 @@ module Gitlab class Manifest attr_reader :parsed_xml, :errors - def initialize(file) - @parsed_xml = Nokogiri::XML(file, &:strict) + def initialize(file_contents) + @parsed_xml = Nokogiri::XML(file_contents, &:strict) @errors = [] rescue Nokogiri::XML::SyntaxError @errors = ['The uploaded file is not a valid XML file.'] -- cgit v1.2.1