From 1c8fa70f9d0818e2a82089c8643a6e455bca47fd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 28 Feb 2020 18:09:07 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .haml-lint_todo.yml | 1 + .../pages/groups/settings/ci_cd/show/index.js | 3 + .../pages/projects/settings/ci_cd/show/index.js | 4 + .../registry/explorer/pages/details.vue | 260 +++++++++++---------- .../javascripts/registry/explorer/pages/list.vue | 141 ++++++----- .../registry/explorer/stores/actions.js | 13 +- .../registry/explorer/stores/getters.js | 6 + .../javascripts/registry/explorer/stores/index.js | 2 + app/assets/stylesheets/utilities.scss | 2 +- app/controllers/groups/deploy_tokens_controller.rb | 12 + .../groups/settings/ci_cd_controller.rb | 29 ++- .../projects/deploy_tokens_controller.rb | 2 +- .../projects/settings/ci_cd_controller.rb | 23 +- .../projects/settings/repository_controller.rb | 20 -- app/helpers/ci_variables_helper.rb | 16 ++ app/models/group.rb | 3 + app/models/group_deploy_token.rb | 2 +- app/models/project.rb | 8 + app/models/snippet_repository.rb | 65 ++++++ app/services/concerns/deploy_token_methods.rb | 11 + app/services/deploy_tokens/create_service.rb | 11 - .../groups/deploy_tokens/create_service.rb | 13 ++ .../projects/deploy_tokens/create_service.rb | 13 ++ app/services/snippets/create_service.rb | 51 +++- app/views/ci/variables/_index.html.haml | 2 +- app/views/groups/settings/ci_cd/show.html.haml | 3 + .../import/shared/_new_project_form.html.haml | 2 +- app/views/projects/deploy_tokens/_form.html.haml | 34 --- app/views/projects/deploy_tokens/_index.html.haml | 17 -- .../deploy_tokens/_new_deploy_token.html.haml | 18 -- .../projects/deploy_tokens/_revoke_modal.html.haml | 17 -- app/views/projects/deploy_tokens/_table.html.haml | 31 --- .../projects/registry/repositories/index.html.haml | 1 - app/views/projects/settings/ci_cd/show.html.haml | 3 + .../projects/settings/repository/show.html.haml | 1 - app/views/shared/deploy_tokens/_form.html.haml | 34 +++ app/views/shared/deploy_tokens/_index.html.haml | 18 ++ .../deploy_tokens/_new_deploy_token.html.haml | 18 ++ .../shared/deploy_tokens/_revoke_modal.html.haml | 15 ++ app/views/shared/deploy_tokens/_table.html.haml | 31 +++ .../unreleased/21765-group-token-refactor.yml | 5 + .../cat-fix-namespaceid-import-39078.yml | 5 + .../fj-39265-create-snippet-repository-content.yml | 5 + .../unreleased/insights-description-for-chart.yml | 5 + ...w-remove_logs_path_for_not_authorised_users.yml | 5 + .../remove-puma-notices-from-admin-area-banner.yml | 5 + config/routes/group.rb | 7 + config/routes/project.rb | 4 +- doc/development/sidekiq_style_guide.md | 57 +++++ doc/user/project/insights/index.md | 17 ++ .../merge_requests/accessibility_testing.md | 12 +- lib/gitlab/config_checker/puma_rugged_checker.rb | 24 +- locale/gitlab.pot | 23 +- qa/qa/page/project/settings/ci_cd.rb | 10 + qa/qa/page/project/settings/deploy_tokens.rb | 4 +- qa/qa/page/project/settings/repository.rb | 6 - qa/qa/resource/deploy_token.rb | 16 +- .../groups/settings/ci_cd_controller_spec.rb | 12 + .../projects/settings/ci_cd_controller_spec.rb | 8 + .../settings/repository_controller_spec.rb | 20 -- spec/features/groups/settings/ci_cd_spec.rb | 13 ++ .../projects/settings/ci_cd_settings_spec.rb | 24 ++ .../projects/settings/repository_settings_spec.rb | 33 --- .../user_sees_revoke_deploy_token_modal_spec.rb | 2 +- spec/frontend/behaviors/quick_submit_spec.js | 153 ++++++++++++ .../registry/explorer/pages/details_spec.js | 22 +- spec/frontend/registry/explorer/pages/list_spec.js | 10 +- .../registry/explorer/stores/actions_spec.js | 24 +- .../registry/explorer/stores/getters_spec.js | 34 +++ spec/javascripts/behaviors/quick_submit_spec.js | 143 ------------ .../config_checker/puma_rugged_checker_spec.rb | 34 +-- spec/models/snippet_repository_spec.rb | 150 +++++++++++- spec/requests/api/project_snippets_spec.rb | 38 +++ spec/requests/api/snippets_spec.rb | 32 ++- spec/routing/project_routing_spec.rb | 5 + spec/services/deploy_tokens/create_service_spec.rb | 63 ----- .../groups/deploy_tokens/create_service_spec.rb | 10 + .../projects/deploy_tokens/create_service_spec.rb | 10 + spec/services/snippets/create_service_spec.rb | 81 ++++++- .../services/deploy_token_shared_examples.rb | 60 +++++ .../controllers/deploy_token_shared_examples.rb | 22 ++ .../features/deploy_token_shared_examples.rb | 27 +++ .../import/gitlab_projects/new.html.haml_spec.rb | 7 +- 83 files changed, 1455 insertions(+), 748 deletions(-) create mode 100644 app/assets/javascripts/registry/explorer/stores/getters.js create mode 100644 app/controllers/groups/deploy_tokens_controller.rb create mode 100644 app/services/concerns/deploy_token_methods.rb delete mode 100644 app/services/deploy_tokens/create_service.rb create mode 100644 app/services/groups/deploy_tokens/create_service.rb create mode 100644 app/services/projects/deploy_tokens/create_service.rb delete mode 100644 app/views/projects/deploy_tokens/_form.html.haml delete mode 100644 app/views/projects/deploy_tokens/_index.html.haml delete mode 100644 app/views/projects/deploy_tokens/_new_deploy_token.html.haml delete mode 100644 app/views/projects/deploy_tokens/_revoke_modal.html.haml delete mode 100644 app/views/projects/deploy_tokens/_table.html.haml create mode 100644 app/views/shared/deploy_tokens/_form.html.haml create mode 100644 app/views/shared/deploy_tokens/_index.html.haml create mode 100644 app/views/shared/deploy_tokens/_new_deploy_token.html.haml create mode 100644 app/views/shared/deploy_tokens/_revoke_modal.html.haml create mode 100644 app/views/shared/deploy_tokens/_table.html.haml create mode 100644 changelogs/unreleased/21765-group-token-refactor.yml create mode 100644 changelogs/unreleased/cat-fix-namespaceid-import-39078.yml create mode 100644 changelogs/unreleased/fj-39265-create-snippet-repository-content.yml create mode 100644 changelogs/unreleased/insights-description-for-chart.yml create mode 100644 changelogs/unreleased/mwaw-remove_logs_path_for_not_authorised_users.yml create mode 100644 changelogs/unreleased/remove-puma-notices-from-admin-area-banner.yml create mode 100644 spec/features/projects/settings/ci_cd_settings_spec.rb create mode 100644 spec/frontend/behaviors/quick_submit_spec.js create mode 100644 spec/frontend/registry/explorer/stores/getters_spec.js delete mode 100644 spec/javascripts/behaviors/quick_submit_spec.js delete mode 100644 spec/services/deploy_tokens/create_service_spec.rb create mode 100644 spec/services/groups/deploy_tokens/create_service_spec.rb create mode 100644 spec/services/projects/deploy_tokens/create_service_spec.rb create mode 100644 spec/support/services/deploy_token_shared_examples.rb create mode 100644 spec/support/shared_examples/controllers/deploy_token_shared_examples.rb create mode 100644 spec/support/shared_examples/features/deploy_token_shared_examples.rb diff --git a/.haml-lint_todo.yml b/.haml-lint_todo.yml index 900dae7a3ab..3f0d3d8ddf8 100644 --- a/.haml-lint_todo.yml +++ b/.haml-lint_todo.yml @@ -374,6 +374,7 @@ linters: - 'app/views/shared/boards/components/sidebar/_due_date.html.haml' - 'app/views/shared/boards/components/sidebar/_labels.html.haml' - 'app/views/shared/boards/components/sidebar/_milestone.html.haml' + - 'app/views/shared/deploy_tokens/_revoke_modal.html.haml' - 'app/views/shared/empty_states/_priority_labels.html.haml' - 'app/views/shared/hook_logs/_content.html.haml' - 'app/views/shared/issuable/_assignees.html.haml' diff --git a/app/assets/javascripts/pages/groups/settings/ci_cd/show/index.js b/app/assets/javascripts/pages/groups/settings/ci_cd/show/index.js index 479c82265f2..1ef18b356f2 100644 --- a/app/assets/javascripts/pages/groups/settings/ci_cd/show/index.js +++ b/app/assets/javascripts/pages/groups/settings/ci_cd/show/index.js @@ -1,10 +1,13 @@ import initSettingsPanels from '~/settings_panels'; import AjaxVariableList from '~/ci_variable_list/ajax_variable_list'; import initVariableList from '~/ci_variable_list'; +import DueDateSelectors from '~/due_date_select'; document.addEventListener('DOMContentLoaded', () => { // Initialize expandable settings panels initSettingsPanels(); + // eslint-disable-next-line no-new + new DueDateSelectors(); if (gon.features.newVariablesUi) { initVariableList(); diff --git a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js index e08d0407245..c83e2bdbf38 100644 --- a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js +++ b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js @@ -3,6 +3,7 @@ import SecretValues from '~/behaviors/secret_values'; import AjaxVariableList from '~/ci_variable_list/ajax_variable_list'; import registrySettingsApp from '~/registry/settings/registry_settings_bundle'; import initVariableList from '~/ci_variable_list'; +import DueDateSelectors from '~/due_date_select'; document.addEventListener('DOMContentLoaded', () => { // Initialize expandable settings panels @@ -39,5 +40,8 @@ document.addEventListener('DOMContentLoaded', () => { autoDevOpsExtraSettings.classList.toggle('hidden', !target.checked); }); + // eslint-disable-next-line no-new + new DueDateSelectors(); + registrySettingsApp(); }); diff --git a/app/assets/javascripts/registry/explorer/pages/details.vue b/app/assets/javascripts/registry/explorer/pages/details.vue index bfb9b0f4688..0f4ed1550ce 100644 --- a/app/assets/javascripts/registry/explorer/pages/details.vue +++ b/app/assets/javascripts/registry/explorer/pages/details.vue @@ -1,5 +1,5 @@