From 1beb9a9fb0218b55c4338d4cc0d60f40bd053ac6 Mon Sep 17 00:00:00 2001 From: Joshua Lambert Date: Fri, 6 Apr 2018 14:26:23 -0400 Subject: Fix dashboard sorting --- app/assets/javascripts/monitoring/stores/monitoring_store.js | 2 +- changelogs/unreleased/fix-dashboard-sorting.yml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/fix-dashboard-sorting.yml diff --git a/app/assets/javascripts/monitoring/stores/monitoring_store.js b/app/assets/javascripts/monitoring/stores/monitoring_store.js index 854636e9a89..535c415cd6d 100644 --- a/app/assets/javascripts/monitoring/stores/monitoring_store.js +++ b/app/assets/javascripts/monitoring/stores/monitoring_store.js @@ -1,7 +1,7 @@ import _ from 'underscore'; function sortMetrics(metrics) { - return _.chain(metrics).sortBy('weight').sortBy('title').value(); + return _.chain(metrics).sortBy('title').sortBy('weight').value(); } function normalizeMetrics(metrics) { diff --git a/changelogs/unreleased/fix-dashboard-sorting.yml b/changelogs/unreleased/fix-dashboard-sorting.yml new file mode 100644 index 00000000000..62557e839a1 --- /dev/null +++ b/changelogs/unreleased/fix-dashboard-sorting.yml @@ -0,0 +1,5 @@ +--- +title: Prioritize weight over title when sorting charts +merge_request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18233 +author: joshlambert +type: fixed -- cgit v1.2.1