Add QA error when page class has no views defined

2 files changed, 21 insertions, 12 deletions

diff --git a/qa/spec/page/base_spec.rb b/qa/spec/page/base_spec.rb
index 63445d8f7bf..29b62cf758c 100644
--- a/qa/spec/page/base_spec.rb
+++ b/qa/spec/page/base_spec.rb
@@ -36,15 +36,28 @@ describe QA::Page::Base do
   describe '.errors' do
     let(:view) { double('view') }
 
-    before do
-      allow(described_class).to receive(:views)
-        .and_return([view])
+    context 'when page has views and elements defined' do
+      before do
+        allow(described_class).to receive(:views)
+          .and_return([view])
 
-      allow(view).to receive(:errors).and_return(['some error'])
+        allow(view).to receive(:errors).and_return(['some error'])
+      end
+
+      it 'iterates views composite and returns errors' do
+        expect(described_class.errors).to eq ['some error']
+      end
     end
 
-    it 'iterates views composite and returns errors' do
-      expect(described_class.errors).to eq ['some error']
+    context 'when page has no views and elements defined' do
+      before do
+        allow(described_class).to receive(:views).and_return([])
+      end
+
+      it 'appends an error about missing views / elements block' do
+        expect(described_class.errors)
+          .to include 'QA::Page::Base class does not have views / elements defined!'
+      end
     end
   end
 end
diff --git a/qa/spec/page/validator_spec.rb b/qa/spec/page/validator_spec.rb
index abee137f4a1..e13fb1eae5b 100644
--- a/qa/spec/page/validator_spec.rb
+++ b/qa/spec/page/validator_spec.rb
@@ -69,13 +69,9 @@ describe QA::Page::Validator do
       end
 
       describe '#validate!' do
-        it 'does raises an error with descriptive message' do
-          message = <<~EOS
-            We found validation errors!
-          EOS
-
+        it 'raises validation error' do
           expect { subject.validate! }
-            .to raise_error described_class::ValidationError, message
+            .to raise_error described_class::ValidationError
         end
       end
     end