Make it possible to define a QA-specific page element

1 files changed, 12 insertions, 9 deletions

diff --git a/qa/spec/page/element_spec.rb b/qa/spec/page/element_spec.rb
index 238c4d1ac66..c665267b90e 100644
--- a/qa/spec/page/element_spec.rb
+++ b/qa/spec/page/element_spec.rb
@@ -2,11 +2,11 @@ describe QA::Page::Element do
   context 'when pattern is an expression' do
     subject { described_class.new(:something, /button 'Sign in'/) }
 
-    it 'is correctly matches against a string' do
+    it 'matches when there is a match' do
       expect(subject.matches?("button 'Sign in'")).to be true
     end
 
-    it 'does not match if string does not match against a pattern' do
+    it 'does not match if pattern is not present' do
       expect(subject.matches?("button 'Sign out'")).to be false
     end
   end
@@ -14,21 +14,24 @@ describe QA::Page::Element do
   context 'when pattern is a string' do
     subject { described_class.new(:something, 'button') }
 
-    it 'is correctly matches against a string' do
+    it 'matches when there is match' do
       expect(subject.matches?('some button in the view')).to be true
     end
 
-    it 'does not match if string does not match against a pattern' do
+    it 'does not match if pattern is not present' do
       expect(subject.matches?('text_field :name')).to be false
     end
   end
 
-  context 'when pattern is not supported' do
-    subject { described_class.new(:something, [/something/]) }
+  context 'when pattern is not provided' do
+    subject { described_class.new(:some_name) }
 
-    it 'raises an error' do
-      expect { subject.matches?('some line') }
-        .to raise_error ArgumentError
+    it 'matches when QA specific selector is present' do
+      expect(subject.matches?('some qa-some-name selector')).to be true
+    end
+
+    it 'does not match if QA selector is not there' do
+      expect(subject.matches?('some_name selector')).to be false
     end
   end
 end