diff options
| author | Paco Guzman <pacoguzmanp@gmail.com> | 2016-06-16 09:56:58 +0200 |
|---|---|---|
| committer | Paco Guzman <pacoguzmanp@gmail.com> | 2016-06-16 14:13:29 +0200 |
| commit | ae6a54f73caaa0d9023d09f0820f3bee1e0cd0d4 (patch) | |
| tree | acc4cc36dfa11c238084405cccdb361c28a8a0b2 /lib/banzai | |
| parent | c369cc8bf42a680b2b0fc9721a9a7926dc5426f6 (diff) | |
| download | gitlab-ce-ae6a54f73caaa0d9023d09f0820f3bee1e0cd0d4.tar.gz | |
Banzai::Filter::ExternalLinkFilter use XPath18582-banzai-filter-external-link-filter
Diffstat (limited to 'lib/banzai')
| -rw-r--r-- | lib/banzai/filter/external_link_filter.rb | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/lib/banzai/filter/external_link_filter.rb b/lib/banzai/filter/external_link_filter.rb index f73ecfc9418..0a29c547a4d 100644 --- a/lib/banzai/filter/external_link_filter.rb +++ b/lib/banzai/filter/external_link_filter.rb @@ -3,17 +3,8 @@ module Banzai # HTML Filter to modify the attributes of external links class ExternalLinkFilter < HTML::Pipeline::Filter def call - doc.search('a').each do |node| - link = node.attr('href') - - next unless link - - # Skip non-HTTP(S) links - next unless link.start_with?('http') - - # Skip internal links - next if link.start_with?(internal_url) - + # Skip non-HTTP(S) links and internal links + doc.xpath("descendant-or-self::a[starts-with(@href, 'http') and not(starts-with(@href, '#{internal_url}'))]").each do |node| node.set_attribute('rel', 'nofollow noreferrer') node.set_attribute('target', '_blank') end |