diff options
| author | Dennis Tang <dtang@gitlab.com> | 2018-05-25 23:56:17 +0200 |
|---|---|---|
| committer | Dennis Tang <dtang@gitlab.com> | 2018-05-25 23:56:17 +0200 |
| commit | 95a63a881673533e3fd44243297d1a81e19396b6 (patch) | |
| tree | 9a3190b813e2d599043394b30afaa5a5c8f8e565 /doc/development/code_review.md | |
| parent | 48e46f959716c8915f5b59d1314b5e5781f3cd8d (diff) | |
| parent | 50c8ed2bf498c69d3d52ba1451274e3fbf438429 (diff) | |
| download | gitlab-ce-95a63a881673533e3fd44243297d1a81e19396b6.tar.gz | |
Merge remote-tracking branch 'origin/master' into 38759-fetch-available-parameters-directly-from-gke-when-creating-a-cluster
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 7165b8062a7..d03b7fa23ca 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -29,6 +29,10 @@ There are a few rules to get your merge request accepted: to ask one of the [Merge request coaches][team]. 1. The reviewer will assign the merge request to a maintainer once the reviewer is satisfied with the state of the merge request. +1. Keep in mind that maintainers are also going to perform a final code review. + The ideal scenario is that the reviewer has already addressed any concerns + the maintainer would have found, and the maintainer only has to perform the + merge, but be prepared for further review comments. For more guidance, see [CONTRIBUTING.md](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md). @@ -207,3 +211,4 @@ Largely based on the [thoughtbot code review guide]. [projects]: https://about.gitlab.com/handbook/engineering/projects/ [team]: https://about.gitlab.com/team/ [build handbook]: https://about.gitlab.com/handbook/build/handbook/build#how-to-work-with-build +[^1]: Please note that specs other than JavaScript specs are considered backend code. |