<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec, branch docs-pages-force-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch '63177-follow-up-from-use-scoped-routes-for-labels-and-milestones' into 'master'</title>
<updated>2019-06-25T15:51:48+00:00</updated>
<author>
<name>Filipa Lacerda</name>
<email>filipa@gitlab.com</email>
</author>
<published>2019-06-25T15:51:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8d10afb5ca4f1f8b68c3ba8a4d5db9ddc37d658f'/>
<id>8d10afb5ca4f1f8b68c3ba8a4d5db9ddc37d658f</id>
<content type='text'>
Resolve "Follow-up from "Use scoped routes for labels and milestones""

Closes #63177

See merge request gitlab-org/gitlab-ce!29983</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolve "Follow-up from "Use scoped routes for labels and milestones""

Closes #63177

See merge request gitlab-org/gitlab-ce!29983</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'require-pipeline-when-enabling-only-allow-merge-if-pipeline-succeeds' into 'master'</title>
<updated>2019-06-25T15:48:39+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzegorz@gitlab.com</email>
</author>
<published>2019-06-25T15:48:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d73b6d0f455c4b77dbea7e8b5d5a1574fd665fe0'/>
<id>d73b6d0f455c4b77dbea7e8b5d5a1574fd665fe0</id>
<content type='text'>
Pipeline must be present if "Pipeline must succeed" is set

See merge request gitlab-org/gitlab-ce!29926</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Pipeline must be present if "Pipeline must succeed" is set

See merge request gitlab-org/gitlab-ce!29926</pre>
</div>
</content>
</entry>
<entry>
<title>Move Vuex action helper spec to Jest</title>
<updated>2019-06-25T15:44:20+00:00</updated>
<author>
<name>Mark Florian</name>
<email>553096-markrian@users.noreply.gitlab.com</email>
</author>
<published>2019-06-25T15:44:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4e05f89413c603ee56774afc91903cb1f31d0541'/>
<id>4e05f89413c603ee56774afc91903cb1f31d0541</id>
<content type='text'>
This is largely a straight-forward copy of the Karma spec, with the
usual Karma-&gt;Jest necessary changes.

This also fixes a bug in the implementation that was causing the tests
to fail, when run on Jest/node, whereby actions that return rejected
promises would always fail the given test. This was due to those
rejections not being caught in the same call stack in which they were
created.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is largely a straight-forward copy of the Karma spec, with the
usual Karma-&gt;Jest necessary changes.

This also fixes a bug in the implementation that was causing the tests
to fail, when run on Jest/node, whereby actions that return rejected
promises would always fail the given test. This was due to those
rejections not being caught in the same call stack in which they were
created.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix broken worktree test</title>
<updated>2019-06-25T14:45:51+00:00</updated>
<author>
<name>GitalyBot</name>
<email>gitalybot@zjvandeweg.nl</email>
</author>
<published>2019-06-25T14:45:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e7b54b9cb8c494f97a48e170696e5d56065aea31'/>
<id>e7b54b9cb8c494f97a48e170696e5d56065aea31</id>
<content type='text'>
The setup was wrong, and due to Gitaly being a bit more strict it had to
match up. The test is now accurate and passing again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The setup was wrong, and due to Gitaly being a bit more strict it had to
match up. The test is now accurate and passing again.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-recover-ee-schema-backport-migration-failure' into 'master'</title>
<updated>2019-06-25T14:03:54+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-06-25T14:03:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34df0b303eed0cee83d8c0ec6178d3c575a0b555'/>
<id>34df0b303eed0cee83d8c0ec6178d3c575a0b555</id>
<content type='text'>
Prevent EE backport migrations from running if CE is not migrated

Closes #63612

See merge request gitlab-org/gitlab-ce!30002</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Prevent EE backport migrations from running if CE is not migrated

Closes #63612

See merge request gitlab-org/gitlab-ce!30002</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent EE backport migrations from running if CE is not migrated</title>
<updated>2019-06-25T12:42:10+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-06-24T21:07:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1b0637781205623547ed1ae7242125f78f7b0b31'/>
<id>1b0637781205623547ed1ae7242125f78f7b0b31</id>
<content type='text'>
If a user upgraded to any GitLab 11.x EE version but switched
back to CE, it's possible the state of the EE tables are not
in the right state for the EE backport migration to work properly.
In particular, there were three tables that had trouble:

* epics
* geo_event_log
* vulnerability_feedback

The EE backport migration would fail while trying to add foreign key
constraints because a key didn't exist in the table. This happens
because any EE migration that add or removed columns between v11.0.0 and
v11.11.3 are not guaranteed to be applied in an CE installation. The EE
backport schema does not individually backport these migrations.

We now check if certain columns are present to determine whether
the backport migration is in the proper state. CE users are required
to upgrade to v11.11.3 EE if they ever installed EE previously before
they can go back to v12.x CE.

Tested via:

```
git checkout -f v11.0.0-ee
bundle exec rake db:reset
git checkout .; git checkout -f v11.11.3
bundle exec rake db:migrate
git checkout .; git checkout -f v12.0.0
bundle exec rake db:migrate
&lt;failure happens&gt;
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a user upgraded to any GitLab 11.x EE version but switched
back to CE, it's possible the state of the EE tables are not
in the right state for the EE backport migration to work properly.
In particular, there were three tables that had trouble:

* epics
* geo_event_log
* vulnerability_feedback

The EE backport migration would fail while trying to add foreign key
constraints because a key didn't exist in the table. This happens
because any EE migration that add or removed columns between v11.0.0 and
v11.11.3 are not guaranteed to be applied in an CE installation. The EE
backport schema does not individually backport these migrations.

We now check if certain columns are present to determine whether
the backport migration is in the proper state. CE users are required
to upgrade to v11.11.3 EE if they ever installed EE previously before
they can go back to v12.x CE.

Tested via:

```
git checkout -f v11.0.0-ee
bundle exec rake db:reset
git checkout .; git checkout -f v11.11.3
bundle exec rake db:migrate
git checkout .; git checkout -f v12.0.0
bundle exec rake db:migrate
&lt;failure happens&gt;
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Keep empty folders in the tree list</title>
<updated>2019-06-25T10:32:35+00:00</updated>
<author>
<name>Denys Mishunov</name>
<email>dmishunov@gitlab.com</email>
</author>
<published>2019-06-05T10:28:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=875cba9d99b49ace61a5dfc52b4fe365893f4b37'/>
<id>875cba9d99b49ace61a5dfc52b4fe365893f4b37</id>
<content type='text'>
When removing the last file from a folder in WebIDE, do not remove the
folder from the view. We keep those to give users possibility to
re-upload files to the same folders.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60860
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When removing the last file from a folder in WebIDE, do not remove the
folder from the view. We keep those to give users possibility to
re-upload files to the same folders.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60860
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow autocompleting scoped labels</title>
<updated>2019-06-25T10:19:29+00:00</updated>
<author>
<name>Martin Hanzel</name>
<email>mhanzel@gitlab.com</email>
</author>
<published>2019-06-25T10:19:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=de7abc06511fef0342af256075987903f68567bd'/>
<id>de7abc06511fef0342af256075987903f68567bd</id>
<content type='text'>
The `:` key will no longer exit out of the autocomplete dialog,
allowing auto-completion of labels with colons in them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `:` key will no longer exit out of the autocomplete dialog,
allowing auto-completion of labels with colons in them.
</pre>
</div>
</content>
</entry>
<entry>
<title>Require pipeline if "Pipeline must succeed" is set</title>
<updated>2019-06-25T09:12:02+00:00</updated>
<author>
<name>Fabio Pitino</name>
<email>fpitino@gitlab.com</email>
</author>
<published>2019-06-21T08:46:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a26916d18cab6bc3ed2e6846d130fcd5e36fb313'/>
<id>a26916d18cab6bc3ed2e6846d130fcd5e36fb313</id>
<content type='text'>
When a user sets only_allow_merge_if_pipeline_succeeds, also named
as "Pipeline must succeed" project setting, we require the pipeline
to be present.

This solves race condition issues especially with external CI
providers when a build is triggered externally but no pipelines are
created in GitLab yet.

Document that a head pipeline is expected when using "Pipeline
must succeed" setting. Also explain limitations with the use of
only/except where there may not be any jobs created and the merge
request will not be allowed to be merged.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a user sets only_allow_merge_if_pipeline_succeeds, also named
as "Pipeline must succeed" project setting, we require the pipeline
to be present.

This solves race condition issues especially with external CI
providers when a build is triggered externally but no pipelines are
created in GitLab yet.

Document that a head pipeline is expected when using "Pipeline
must succeed" setting. Also explain limitations with the use of
only/except where there may not be any jobs created and the merge
request will not be allowed to be merged.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use project depended feature flag for pages ssl</title>
<updated>2019-06-25T08:30:12+00:00</updated>
<author>
<name>Vladimir Shushlin</name>
<email>v.shushlin@gmail.com</email>
</author>
<published>2019-06-13T11:37:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=432f2bbc9cf64d53418c1eb9bb701254803a0e1e'/>
<id>432f2bbc9cf64d53418c1eb9bb701254803a0e1e</id>
<content type='text'>
Also add ::Gitlab::LetsEncrypt.enabled? shortcut
and simplify it a lot
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also add ::Gitlab::LetsEncrypt.enabled? shortcut
and simplify it a lot
</pre>
</div>
</content>
</entry>
</feed>
