<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec, branch ce-detect-github-pull-requests</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>CE port for pipelines for external pull requests</title>
<updated>2019-09-05T14:53:48+00:00</updated>
<author>
<name>Fabio Pitino</name>
<email>fpitino@gitlab.com</email>
</author>
<published>2019-08-09T09:40:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ca6a1f33f91a8cceadebfb9c4e9ac6afa340f71d'/>
<id>ca6a1f33f91a8cceadebfb9c4e9ac6afa340f71d</id>
<content type='text'>
Detect if pipeline runs for a GitHub pull request

When using a mirror for CI/CD only we register a pull_request
webhook. When a pull_request webhook is received, if the
source branch SHA matches the actual head of the branch in the
repository we create immediately a new pipeline for the
external pull request. Otherwise we store the
pull request info for when the push webhook is received.

When using "only/except: external_pull_requests" we can detect
if the pipeline has a open pull request on GitHub and create or
not the job based on that.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Detect if pipeline runs for a GitHub pull request

When using a mirror for CI/CD only we register a pull_request
webhook. When a pull_request webhook is received, if the
source branch SHA matches the actual head of the branch in the
repository we create immediately a new pipeline for the
external pull request. Otherwise we store the
pull request info for when the push webhook is received.

When using "only/except: external_pull_requests" we can detect
if the pipeline has a open pull request on GitHub and create or
not the job based on that.
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid checking dns rebind protection in validation</title>
<updated>2019-09-05T09:11:14+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-09-05T09:11:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=537eb0bb2d4d8a2af9753850c4a85fc473b68d8d'/>
<id>537eb0bb2d4d8a2af9753850c4a85fc473b68d8d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '66966-convert-rails-env-stub-usages-to-use-railshelpers-stub_rails_env-instead' into 'master'</title>
<updated>2019-09-05T08:02:44+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-09-05T08:02:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=09bd5142335c0aa3146d3de22137dd608580660b'/>
<id>09bd5142335c0aa3146d3de22137dd608580660b</id>
<content type='text'>
Use stub_rails_env for Rails.env stubbing

Closes #66966

See merge request gitlab-org/gitlab-ce!32625</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use stub_rails_env for Rails.env stubbing

Closes #66966

See merge request gitlab-org/gitlab-ce!32625</pre>
</div>
</content>
</entry>
<entry>
<title>Allow not resolvable urls when rebinding setting is disabled</title>
<updated>2019-09-05T06:07:17+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-09-05T06:07:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b4ea71f9ed0b75b86b3e02181add2724d88e20c9'/>
<id>b4ea71f9ed0b75b86b3e02181add2724d88e20c9</id>
<content type='text'>
Now, when the dns rebinging setting is disabled, we will
allow urls that are not resolvable.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now, when the dns rebinging setting is disabled, we will
allow urls that are not resolvable.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use stub_rails_env for Rails.env stubbing</title>
<updated>2019-09-05T02:54:03+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-09-04T01:57:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=124bad7bd88e7c329583ec3757eb0ba5fcec66e6'/>
<id>124bad7bd88e7c329583ec3757eb0ba5fcec66e6</id>
<content type='text'>
RailsHelpers.stub_rails_env takes care of
stubbing Rails.env
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
RailsHelpers.stub_rails_env takes care of
stubbing Rails.env
</pre>
</div>
</content>
</entry>
<entry>
<title>Bring method back that was mistakenly removed</title>
<updated>2019-09-04T23:26:57+00:00</updated>
<author>
<name>João Cunha</name>
<email>j.a.cunha@gmail.com</email>
</author>
<published>2019-09-04T23:26:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2910f55aa2194af8d025f1ba8e382d7a649d53da'/>
<id>2910f55aa2194af8d025f1ba8e382d7a649d53da</id>
<content type='text'>
- We're also improving specs to avoid this could happen again
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- We're also improving specs to avoid this could happen again
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade graphql gem to 1.9.10</title>
<updated>2019-09-04T21:57:37+00:00</updated>
<author>
<name>Brett Walker</name>
<email>bwalker@gitlab.com</email>
</author>
<published>2019-09-04T21:57:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ec2b4bb65da6f5b6a5ab813349049806c1b3851e'/>
<id>ec2b4bb65da6f5b6a5ab813349049806c1b3851e</id>
<content type='text'>
- `edge_nodes` needs to get called on the object
- added `include GlobalID::Identification` in a couple places
- renamed `object` to `item` in spec due to conflict
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- `edge_nodes` needs to get called on the object
- added `include GlobalID::Identification` in a couple places
- renamed `object` to `item` in spec due to conflict
</pre>
</div>
</content>
</entry>
<entry>
<title>Update Pipelines Minutes expire banner (CE)</title>
<updated>2019-09-04T20:48:58+00:00</updated>
<author>
<name>Ammar Alakkad</name>
<email>aalakkad@gitlab.com</email>
</author>
<published>2019-09-04T20:48:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c2fb7f85b3bd48195200e7de9f2b380e282b306f'/>
<id>c2fb7f85b3bd48195200e7de9f2b380e282b306f</id>
<content type='text'>
- remove hiding the alert functionality
- use `danger` class instead of `warning`

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14786
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- remove hiding the alert functionality
- use `danger` class instead of `warning`

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14786
</pre>
</div>
</content>
</entry>
<entry>
<title>Show meaningful message on /due quick action with invalid date</title>
<updated>2019-09-04T20:13:39+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2019-09-04T20:13:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9c87275f6ef0b40d905929ce5bcd5480a6dfd369'/>
<id>9c87275f6ef0b40d905929ce5bcd5480a6dfd369</id>
<content type='text'>
When using /due quick action with an invalid date a meaninful error
message is shown.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When using /due quick action with an invalid date a meaninful error
message is shown.
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade GraphQL gem to 1.8.17</title>
<updated>2019-09-04T17:42:48+00:00</updated>
<author>
<name>Brett Walker</name>
<email>bwalker@gitlab.com</email>
</author>
<published>2019-09-04T17:42:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aa7b1cfc5b3319373a4b56c755b1fc1d4cbaff02'/>
<id>aa7b1cfc5b3319373a4b56c755b1fc1d4cbaff02</id>
<content type='text'>
- Due to https://github.com/exAspArk/batch-loader/pull/32,
we  changed BatchLoader.for into BatchLoader::GraphQL.for
- since our results are wrapped in a BatchLoader::GraphQL,
calling `sync` during authorization is required to get real object
- `graphql` now has it's own authorization system.  Our
`authorized?` method conflicted and required renaming
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Due to https://github.com/exAspArk/batch-loader/pull/32,
we  changed BatchLoader.for into BatchLoader::GraphQL.for
- since our results are wrapped in a BatchLoader::GraphQL,
calling `sync` during authorization is required to get real object
- `graphql` now has it's own authorization system.  Our
`authorized?` method conflicted and required renaming
</pre>
</div>
</content>
</entry>
</feed>
