delta/gitlab/gitlab-ce.git/spec, branch 58375-api-controller gitlab.com: gitlab-org/gitlab-ce.git Use environment_params when defining expected_params 2019-04-04T20:42:34+00:00 rpereira2 rpereira@gitlab.com 2019-04-04T13:46:45+00:00 20594de8cc3311ddc53b29ffdf60bcf4a580a5b3 






Do not hardcode project and namespace name in url
2019-04-04T20:42:34+00:00

rpereira2
rpereira@gitlab.com

2019-04-04T07:45:15+00:00

e89b07327166b2af8557d0f177264da25e4df0d3

The names can change in different runs of the spec.





The names can change in different runs of the spec.







Call permit! on params
2019-04-04T20:42:34+00:00

rpereira2
rpereira@gitlab.com

2019-04-03T14:00:22+00:00

5ee7c419ea97f9322dcaf6da02c85f2ac25f477d












Remove permitting of params
2019-04-04T20:42:33+00:00

rpereira2
rpereira@gitlab.com

2019-04-03T09:31:44+00:00

16772b91f0b71b47c8e72bfa2d11693aed58e3ba

- It is now being done in ProxyService class.





- It is now being done in ProxyService class.







Add spec for invalid environment id
2019-04-04T20:42:33+00:00

rpereira2
rpereira@gitlab.com

2019-04-03T08:02:45+00:00

eac3e2302c4155ed1890e39b7124672d79b795b6












Make filter params specs more readable
2019-04-04T20:42:33+00:00

Peter Leitzen
pleitzen@gitlab.com

2019-04-03T06:42:12+00:00

4a0c8b4a9c25257d9f0addfbc603f2bac80b63db












Streamline controller specs
2019-04-04T20:42:33+00:00

Peter Leitzen
pleitzen@gitlab.com

2019-04-02T16:38:49+00:00

1427ad4f5ce11d8327d9258eb3ffc62803c1a304












Add a Prometheus API per environment
2019-04-04T20:42:33+00:00

rpereira2
rpereira@gitlab.com

2019-04-02T06:26:09+00:00

e1a167ee234fbb8886ac1a882002b76adeb67edf

The api will proxy requests to the environment's prometheus server.
The Prometheus::ProxyService class can be reused when we add support for
group prometheus servers.





The api will proxy requests to the environment's prometheus server.
The Prometheus::ProxyService class can be reused when we add support for
group prometheus servers.







Some code improvements
2019-04-04T20:22:46+00:00

rpereira2
rpereira@gitlab.com

2019-04-04T10:44:08+00:00

5dd6e752c0c3d572c645ac56a79c6c5a3fbd5157

- Use strong_memoize for prometheus_adapter since it can be nil in some
cases.
- Do not phrase spec descriptions with 'should'.





- Use strong_memoize for prometheus_adapter since it can be nil in some
cases.
- Do not phrase spec descriptions with 'should'.







Use hash methods to filter params
2019-04-04T20:22:46+00:00

rpereira2
rpereira@gitlab.com

2019-04-03T12:54:52+00:00

833206abf833b0c43e35d97b3f2fea98d91d5572

- This is so that we don't have to check that params is of type
ActionController::Parameters in ProxyService.





- This is so that we don't have to check that params is of type
ActionController::Parameters in ProxyService.