<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec, branch 38239-update-toggle-design</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Update tests for toggle design change</title>
<updated>2017-12-15T16:38:04+00:00</updated>
<author>
<name>Kushal Pandya</name>
<email>kushal@gitlab.com</email>
</author>
<published>2017-12-15T13:24:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c796304e82f62fed5417eb91a855b6cf05ce1a10'/>
<id>c796304e82f62fed5417eb91a855b6cf05ce1a10</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix spec by avoiding monkeypatching</title>
<updated>2017-12-12T22:25:33+00:00</updated>
<author>
<name>Michael Kozono</name>
<email>mkozono@gmail.com</email>
</author>
<published>2017-12-12T21:13:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=acde0e3f5cee3a9a1bff4aadbf276b91f7c7272d'/>
<id>acde0e3f5cee3a9a1bff4aadbf276b91f7c7272d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'tmlee/gitlab-ce-28004-consider-refactoring-member-view-by-using-presenter' into 'master'</title>
<updated>2017-12-12T20:57:24+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2017-12-12T20:57:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2df1f4a515ab5cbfdd3116566ab9c8d786539041'/>
<id>2df1f4a515ab5cbfdd3116566ab9c8d786539041</id>
<content type='text'>
Refactor member view by using presenter

Closes #28004

See merge request gitlab-org/gitlab-ce!15715</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Refactor member view by using presenter

Closes #28004

See merge request gitlab-org/gitlab-ce!15715</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-memoization-mr-commits' into 'master'</title>
<updated>2017-12-12T18:29:41+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2017-12-12T18:29:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dc28ada00673a5d41a2ad36af824d563276ecc0a'/>
<id>dc28ada00673a5d41a2ad36af824d563276ecc0a</id>
<content type='text'>
Use memoization for commits on diffs

See merge request gitlab-org/gitlab-ce!15857</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use memoization for commits on diffs

See merge request gitlab-org/gitlab-ce!15857</pre>
</div>
</content>
</entry>
<entry>
<title>Present member collection at the controller level</title>
<updated>2017-12-12T17:14:58+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-12-05T14:03:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=50d7c356c2d1622203b518bf0f3d5cbf1860099a'/>
<id>50d7c356c2d1622203b518bf0f3d5cbf1860099a</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sophie-h/gitlab-ce-patch-15' into 'master'</title>
<updated>2017-12-12T16:45:49+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2017-12-12T16:45:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ad1c186ed386afab578668ccdc21cb02354c81bc'/>
<id>ad1c186ed386afab578668ccdc21cb02354c81bc</id>
<content type='text'>
Hide issues and MRs in labels list if disabled

See merge request gitlab-org/gitlab-ce!15863</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Hide issues and MRs in labels list if disabled

See merge request gitlab-org/gitlab-ce!15863</pre>
</div>
</content>
</entry>
<entry>
<title>Fix rubocop offence</title>
<updated>2017-12-12T16:40:54+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2017-12-12T16:40:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=428c38a2b19866956ab6af61fbaa121b3bb1584d'/>
<id>428c38a2b19866956ab6af61fbaa121b3bb1584d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'repo-write-ref-client-prep' into 'master'</title>
<updated>2017-12-12T16:36:58+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>robert@gitlab.com</email>
</author>
<published>2017-12-12T16:36:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b655a4a790b05f6023563b35a3823728480c33fc'/>
<id>b655a4a790b05f6023563b35a3823728480c33fc</id>
<content type='text'>
Move Repository#write_ref to Git::Repository#write_ref

Closes gitaly#793

See merge request gitlab-org/gitlab-ce!15712</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move Repository#write_ref to Git::Repository#write_ref

Closes gitaly#793

See merge request gitlab-org/gitlab-ce!15712</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'optimize-issues-avoid-noop-empty-cache-updates2' into 'master'</title>
<updated>2017-12-12T16:02:54+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2017-12-12T16:02:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2cbfc992c9005ed193b2d547a5537313dbf2ca0e'/>
<id>2cbfc992c9005ed193b2d547a5537313dbf2ca0e</id>
<content type='text'>
Treat empty markdown and html strings as valid cached text, not missing cache…

See merge request gitlab-org/gitlab-ce!15856</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Treat empty markdown and html strings as valid cached text, not missing cache…

See merge request gitlab-org/gitlab-ce!15856</pre>
</div>
</content>
</entry>
<entry>
<title>Use memoization for commits on diffs</title>
<updated>2017-12-12T15:28:26+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2017-12-11T15:38:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3ab026b7d69ec97796fe4bb409933d7a716eef19'/>
<id>3ab026b7d69ec97796fe4bb409933d7a716eef19</id>
<content type='text'>
The Gitaly CommitService is being hammered by n + 1 calls, mostly when
finding commits. This leads to this gRPC being turned of on production:
https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378

Hunting down where it came from, most of them were due to
MergeRequest#show. To prove this, I set a script to request the
MergeRequest#show page 50 times. The GDK was being scraped by
Prometheus, where we have metrics on controller#action and their Gitaly
calls performed. On both occations I've restarted the full GDK so all
caches had to be rebuild.

Current master, 806a68a81f1baee, needed 435 requests
After this commit, 154 requests
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Gitaly CommitService is being hammered by n + 1 calls, mostly when
finding commits. This leads to this gRPC being turned of on production:
https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378

Hunting down where it came from, most of them were due to
MergeRequest#show. To prove this, I set a script to request the
MergeRequest#show page 50 times. The GDK was being scraped by
Prometheus, where we have metrics on controller#action and their Gitaly
calls performed. On both occations I've restarted the full GDK so all
caches had to be rebuild.

Current master, 806a68a81f1baee, needed 435 requests
After this commit, 154 requests
</pre>
</div>
</content>
</entry>
</feed>
