Resolve "Clean up commit meta info view" Updates commit page design Before:  After:   Closes #20892 See merge request !6994
When we updated gitlab_git to 10.4.1, `tag.target` changed from pointing to the sha of the tag to the sha of the commit the tag points to. The problem is that only annotated tags have `object_sha`s, lightweight tags don't (it's nil), so (only) in their case we still need to use `tag.target`.
* upstream/master: (368 commits) Use root_url for issue boards user link removes extra line for empty milestone description code formatting corrected Fix reply-by-email not working due to queue name mismatch Remove duplicate code in repository cache clearing Expire and build repository cache after project import refactor(email): use setter method instead AR callbacks Move spec/mailers/shared/notify.rb to spec/support Fix status code expectation Stop clearing the database cache on rake cache:clear Fix error in generating labels Fix bug where e-mails were not being sent out via Sidekiq Document link syntax introduced by !5586 Fix documents and comments on Build API `scope`. #23146 #19131 adds entry in CHANGELOG removes extra line for empty issue description Re-organize queues to use for Sidekiq Fix wrong endpoint in api/users documentation, fix same typo in spec describe blocks Update CHANGELOG Fix object data to be sent to fetch analytics data ...
* upstream/master: (409 commits) Update endpoint to username validator change border color to variable Add todo for deprecated user routes and more information about deprecation to changelog Provide better error message to the user Apply better hierarchy to markdown headers and issue/mr titles Swapped button text manipulation outcomes for the toggle query Fixed find file keyboard navigation Update CHANGELOG for 8.12.7 Added download-button class and applied button margin Enable activerecord_sane_schema_dumper for test Updated logo from @luke Fix broken specs on MySQL after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6896 Fix Test Env (proper error handling when gitlab-shell is not clonned) Fix randomly crashing spinach test for merge request [Great spinach fix] Replace gsub with delete Remove carriage returns from commit description as summary is on a newline and will always include carriage returns Convert due_date_select.js filetype to es6. Stop directly parsing due_date with Date.parse, prefer parsing implicitly. Improve spec for pipeline metrics worker Add Pipeline metrics worker ...
* upstream/master: (327 commits) Formatted all app/assets/javascripts to underscore naming convention Add registry to skipped data in backup raketask docs Updating changes based on feedback from @connorshea Changes to make Git basics more intuitive - updated verbiage where appropriate - changed "git config" commands to include quotes for variables to be more in line with standard practive and to avoid issues with spaces - updated CHANGELOG as part of commit Remove Ci::ApplicationController HTMLEntityFilter -> HtmlEntityFilter Clarify which token should be used to delete a runner Changed 'Compare branches, tags or commit ranges' to 'Compare Git revisions' Changed placeholder to 'Commit hash' Add link to test coverage report to README Added copy file path button to diffs Fix wrong icon in CI build detail sidebar: right-arrow => arrow-right Prevent conflict b/w search field and its dropdown Make searching for commits case insensitive. Use user from let instead recreate in before reword html titles for merge requests and issues Fix a typo in doc/api/labels.md Check for transition loopback in commit status Add temporary fix for race condition in MWBS Improve transitions and run hooks after transaction ...