<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/views/help, branch docs/https-many-docs-links</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix specs to match route changes</title>
<updated>2019-05-20T12:21:37+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2019-05-20T12:21:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=70decdc2acb4da895bdd63bb15b46014045af661'/>
<id>70decdc2acb4da895bdd63bb15b46014045af661</id>
<content type='text'>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dmitriy Zaporozhets &lt;dmitriy.zaporozhets@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Update gitlab-styles to 2.5.1</title>
<updated>2019-01-11T22:59:35+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2019-01-11T20:10:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4361c92b6a41554ae8a8e4ad7204e8ed82ec7c5c'/>
<id>4361c92b6a41554ae8a8e4ad7204e8ed82ec7c5c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Show the commit-sha for pre-release versions</title>
<updated>2018-10-02T14:11:32+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-10-01T13:59:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b09e40624b9fc6a7b4a7b38f174bc66d996e3fd5'/>
<id>b09e40624b9fc6a7b4a7b38f174bc66d996e3fd5</id>
<content type='text'>
The pre-release tags are set at the beginning of a release, so it
would be impossible to figure out which version was running if we're
running nightlies.

In that case it's better to still link to the SHA. These versions
don't get deployed to .com.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The pre-release tags are set at the beginning of a release, so it
would be impossible to figure out which version was running if we're
running nightlies.

In that case it's better to still link to the SHA. These versions
don't get deployed to .com.
</pre>
</div>
</content>
</entry>
<entry>
<title>Link to the tag from a version instead of commit</title>
<updated>2018-10-01T09:59:48+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-10-01T08:43:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=18324261097de835628570696594f749e48d3747'/>
<id>18324261097de835628570696594f749e48d3747</id>
<content type='text'>
This will result in a 404 when running an unreleased security patch
while still allowing users to find the commit when it is made available.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will result in a 404 when running an unreleased security patch
while still allowing users to find the commit when it is made available.
</pre>
</div>
</content>
</entry>
<entry>
<title>Correct usage of the have_link matcher</title>
<updated>2018-09-14T20:36:40+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2018-09-14T20:36:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=14a27a4f40d837d5ce690107cf4f97b9907d2b2a'/>
<id>14a27a4f40d837d5ce690107cf4f97b9907d2b2a</id>
<content type='text'>
The second option to this matcher should be an options hash; anything
else is just ignored, which can lead to false positives in tests.

We see one such false positive in the "Learn more" link test in
`spec/features/projects/blobs/blob_show_spec.rb`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The second option to this matcher should be an options hash; anything
else is just ignored, which can lead to false positives in tests.

We see one such false positive in the "Learn more" link test in
`spec/features/projects/blobs/blob_show_spec.rb`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace Gitlab::REVISION with Gitlab.revision and handle installations without a .git directory</title>
<updated>2018-05-24T08:14:01+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-05-24T07:57:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d50a80a282b2ca145841774f4be154a977cccfd8'/>
<id>d50a80a282b2ca145841774f4be154a977cccfd8</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Added ssh fingerprint, gitlab ci and pages information in an instance configuration page</title>
<updated>2017-10-25T20:51:26+00:00</updated>
<author>
<name>Francisco Lopez</name>
<email>fjsanpedro@gmail.com</email>
</author>
<published>2017-08-24T14:34:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=294f40e2c8f51239bfa0e3514e7fe4f3c8ae00cb'/>
<id>294f40e2c8f51239bfa0e3514e7fe4f3c8ae00cb</id>
<content type='text'>
Closes #25142
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes #25142
</pre>
</div>
</content>
</entry>
<entry>
<title>`current_application_settings` belongs on `Gitlab::CurrentSettings`</title>
<updated>2017-08-31T12:38:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2017-08-31T09:47:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5883ce95efcc4cc04f949f9b4e66d73fbede94e2'/>
<id>5883ce95efcc4cc04f949f9b4e66d73fbede94e2</id>
<content type='text'>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make the revision on the `/help` page clickable</title>
<updated>2017-06-09T08:35:42+00:00</updated>
<author>
<name>Toon Claes</name>
<email>toon@gitlab.com</email>
</author>
<published>2017-06-08T13:43:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7188b4d83989dcfcc672f88e19d1ddb550b4917a'/>
<id>7188b4d83989dcfcc672f88e19d1ddb550b4917a</id>
<content type='text'>
For quicker access, add hyperlink to the gitlab.com commits page for the current
REVISION of GitLab.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For quicker access, add hyperlink to the gitlab.com commits page for the current
REVISION of GitLab.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow non-admin users to see version information</title>
<updated>2015-09-23T21:18:15+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2015-09-23T21:18:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=45824aabc634e06d9f7dd853e573c153b7bf9a78'/>
<id>45824aabc634e06d9f7dd853e573c153b7bf9a78</id>
<content type='text'>
We want users to know what features they have available (and to pressure
their admins to upgrade).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We want users to know what features they have available (and to pressure
their admins to upgrade).
</pre>
</div>
</content>
</entry>
</feed>
