delta/gitlab/gitlab-ce.git/spec/views/devise, branch patch-58 gitlab.com: gitlab-org/gitlab-ce.git Show a reCAPTCHA on signin page if custom header is set 2018-06-21T22:37:34+00:00 Stan Hu stanhu@gmail.com 2018-06-21T18:13:08+00:00 9b48d9f43f237ccf87594a944a00896996cadf55 This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP header. 
This will only be displayed if `X-GitLab-Show-Login-Captcha` is set as an HTTP
header.
`current_application_settings` belongs on `Gitlab::CurrentSettings` 2017-08-31T12:38:33+00:00 Sean McGivern sean@gitlab.com 2017-08-31T09:47:03+00:00 5883ce95efcc4cc04f949f9b4e66d73fbede94e2 The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form. 
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
Enable Style/DotPosition Rubocop :cop: 2017-06-21T13:48:12+00:00 Grzegorz Bizon grzegorz@gitlab.com 2017-06-21T13:48:12+00:00 0430b7644101fc70ed4be6bf69ccf05b900f4cdf 






Fix login tests for crowd to use #crowd.
2016-10-18T09:12:41+00:00

Bryce Johnson
bryce@gitlab.com

2016-10-17T17:53:33+00:00

60e6eca0d0b0926aeb248332c88be886f2f8e69f












Remove provider path, replace with dynamic path.
2016-08-03T17:50:38+00:00

Connor Shea
connor.james.shea@gmail.com

2016-07-25T17:40:40+00:00

602fe111912bac119e752b0dfa3b4b3cd81585ff












Move "I should see Crowd login form" feature to a view spec
2016-02-24T22:38:13+00:00

Robert Speicher
rspeicher@gmail.com

2016-02-02T22:23:34+00:00

b95ef77e233eab3b3d37a4a7dce545d9da36f8a0

We were doing all kinds of code gymnastics to "enable" Crowd in the
feature spec and this would sometimes cause a transient failure.

Really what it's testing is if the Crowd login form shows when Crowd's
enabled, so this is much better suited to a view spec.





We were doing all kinds of code gymnastics to "enable" Crowd in the
feature spec and this would sometimes cause a transient failure.

Really what it's testing is if the Crowd login form shows when Crowd's
enabled, so this is much better suited to a view spec.