<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/validators, branch 58375-api-controller</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix Bitbucket import</title>
<updated>2019-03-14T10:05:17+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-03-14T10:05:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=150f7c1e9c8d4a9d8134664d00a6385ac21a1939'/>
<id>150f7c1e9c8d4a9d8134664d00a6385ac21a1939</id>
<content type='text'>
In https://gitlab.com/gitlab-org/gitlab-ce/commit/ebf16ada856efb85424a98848c141f21e609886a
we introduced a SHA validator, to ensure that the data provided in
merge request diffs, was legit. Nevertheless, the validator
assumed that the SHA should be 40 chars long.

When we import a project from BitBucket, the retrieved SHA is
shorter (12 chars long). Therefore, this validator prevented to
create a valid MergeRequestDiff for ever MergeRequest (triggering
an exception).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In https://gitlab.com/gitlab-org/gitlab-ce/commit/ebf16ada856efb85424a98848c141f21e609886a
we introduced a SHA validator, to ensure that the data provided in
merge request diffs, was legit. Nevertheless, the validator
assumed that the SHA should be 40 chars long.

When we import a project from BitBucket, the retrieved SHA is
shorter (12 chars long). Therefore, this validator prevented to
create a valid MergeRequestDiff for ever MergeRequest (triggering
an exception).
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/email_validator' into 'master'</title>
<updated>2019-03-09T00:05:59+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-09T00:05:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6908c5f70eb4d5d7e8ef28b43d73d71da9b2a0c3'/>
<id>6908c5f70eb4d5d7e8ef28b43d73d71da9b2a0c3</id>
<content type='text'>
Align EmailValidator to validate_email gem implementation.

Closes #57352

See merge request gitlab-org/gitlab-ce!24971</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Align EmailValidator to validate_email gem implementation.

Closes #57352

See merge request gitlab-org/gitlab-ce!24971</pre>
</div>
</content>
</entry>
<entry>
<title>Align EmailValidator to validate_email gem implementation.</title>
<updated>2019-03-05T19:56:01+00:00</updated>
<author>
<name>Horatiu Eugen Vlad</name>
<email>horatiu@vlad.eu</email>
</author>
<published>2018-10-26T22:39:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c8c0ea6c52d46ce63d838d1e739355d4deace434'/>
<id>c8c0ea6c52d46ce63d838d1e739355d4deace434</id>
<content type='text'>
Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: regex.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: regex.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add frozen_string_literal to new files</title>
<updated>2019-03-05T07:19:19+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-03-05T07:19:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ad2f711adfe151f15f19559884cd84a8dd26e93e'/>
<id>ad2f711adfe151f15f19559884cd84a8dd26e93e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Arbitrary file read via MergeRequestDiff</title>
<updated>2019-03-04T18:36:34+00:00</updated>
<author>
<name>Francisco Javier López</name>
<email>fjlopez@gitlab.com</email>
</author>
<published>2019-03-04T18:36:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ebf16ada856efb85424a98848c141f21e609886a'/>
<id>ebf16ada856efb85424a98848c141f21e609886a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>remove newly supported regex feature from validation error test</title>
<updated>2019-01-14T12:42:27+00:00</updated>
<author>
<name>Roger Rüttimann</name>
<email>ror@panter.ch</email>
</author>
<published>2019-01-14T12:42:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3197cd9b6cffadee9e5d633bd7d1f7673d1b9229'/>
<id>3197cd9b6cffadee9e5d633bd7d1f7673d1b9229</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add table and model for error tracking settings</title>
<updated>2019-01-07T17:55:21+00:00</updated>
<author>
<name>Reuben Pereira</name>
<email>rpereira@gitlab.com</email>
</author>
<published>2019-01-07T17:55:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f40b5860d76a8ea5d964260834a6e83516b0f1fd'/>
<id>f40b5860d76a8ea5d964260834a6e83516b0f1fd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow URLs to be validated as ascii_only</title>
<updated>2018-12-06T15:18:18+00:00</updated>
<author>
<name>James Edwards-Jones</name>
<email>jedwardsjones@gitlab.com</email>
</author>
<published>2018-12-05T20:14:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=72c00594070dfd1a778c2e03ff400b478e6c3774'/>
<id>72c00594070dfd1a778c2e03ff400b478e6c3774</id>
<content type='text'>
Restricts unicode characters and IDNA deviations
which could be used in a phishing attack
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Restricts unicode characters and IDNA deviations
which could be used in a phishing attack
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-fj-crlf-injection' into 'master'</title>
<updated>2018-11-29T00:14:06+00:00</updated>
<author>
<name>Cindy Pallares</name>
<email>cindy@gitlab.com</email>
</author>
<published>2018-11-28T19:06:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c0e5d9afee57745a79c072b0f57fdcbe164312da'/>
<id>c0e5d9afee57745a79c072b0f57fdcbe164312da</id>
<content type='text'>
[master] Fix CRLF issue in UrlValidator

See merge request gitlab/gitlabhq!2627</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[master] Fix CRLF issue in UrlValidator

See merge request gitlab/gitlabhq!2627</pre>
</div>
</content>
</entry>
<entry>
<title>Allow UrlValidator to work with attr_encrypted</title>
<updated>2018-09-17T18:34:40+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2018-09-17T15:11:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b73f3ce58fa6bf0e75ae7f348000b7bce53da9b1'/>
<id>b73f3ce58fa6bf0e75ae7f348000b7bce53da9b1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
