<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/uploaders, branch gitlab-selenium-proxy-visual-regression-testing</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'feature/customizable-favicon' into 'master'</title>
<updated>2018-06-07T16:54:41+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-06-07T16:54:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=290ca339adc952bcd939d1782af95f90d3b88716'/>
<id>290ca339adc952bcd939d1782af95f90d3b88716</id>
<content type='text'>
Customizable favicon

Closes #15661

See merge request gitlab-org/gitlab-ce!14497</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Customizable favicon

Closes #15661

See merge request gitlab-org/gitlab-ce!14497</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix-fog-mocking' into 'master'</title>
<updated>2018-06-05T15:26:14+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-06-05T15:26:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0a5f3aa37833fe6365fc8ab7af8912d15b4d844a'/>
<id>0a5f3aa37833fe6365fc8ab7af8912d15b4d844a</id>
<content type='text'>
Fix Fog mocking

Closes #47300

See merge request gitlab-org/gitlab-ce!19425</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix Fog mocking

Closes #47300

See merge request gitlab-org/gitlab-ce!19425</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Fog mocking</title>
<updated>2018-06-05T14:48:42+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-06-05T14:17:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=53d1c87c8673fa6c9d83519490698b37d67572df'/>
<id>53d1c87c8673fa6c9d83519490698b37d67572df</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>create favicon overlay on the client</title>
<updated>2018-06-05T14:20:21+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>alexis.reigel.ext@siemens.com</email>
</author>
<published>2017-12-06T20:04:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9e14f437b6ed205744d916f5566ee2c11e52b734'/>
<id>9e14f437b6ed205744d916f5566ee2c11e52b734</id>
<content type='text'>
the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:

1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
   only need to store the original favion and generate the overlay versions
   dynamically.
   this change also enables (next step) to simplify the handling of the
   stock favicons as well, as we don't need to generate all the versions
   upfront.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:

1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
   only need to store the original favion and generate the overlay versions
   dynamically.
   this change also enables (next step) to simplify the handling of the
   stock favicons as well, as we don't need to generate all the versions
   upfront.
</pre>
</div>
</content>
</entry>
<entry>
<title>call Gitlab::Favicon.status in serializer</title>
<updated>2018-06-05T14:20:21+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>mail@koffeinfrei.org</email>
</author>
<published>2017-09-28T11:57:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=67fe0a17d87a7a5380b41e04ef23212d5da637ba'/>
<id>67fe0a17d87a7a5380b41e04ef23212d5da637ba</id>
<content type='text'>
this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.

also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.

also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.
</pre>
</div>
</content>
</entry>
<entry>
<title>favicon uploader generating ci status favicons</title>
<updated>2018-06-05T14:20:06+00:00</updated>
<author>
<name>Alexis Reigel</name>
<email>mail@koffeinfrei.org</email>
</author>
<published>2017-09-26T07:51:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c8a4d202c99c772822a2b9b09fa6da2c90b2ae81'/>
<id>c8a4d202c99c772822a2b9b09fa6da2c90b2ae81</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix an N+1 in avatar URLs</title>
<updated>2018-06-05T13:57:19+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-04-19T16:22:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6ecf819f73ae28547e1b816780de0d85c3a653cf'/>
<id>6ecf819f73ae28547e1b816780de0d85c3a653cf</id>
<content type='text'>
This is tricky: the query was being run in
`ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
just add batch loading there, because the `#upload=` method there would use the
result immediately, making the batch only have one item.

Instead, we can pre-emptively add an item to the batch whenever an avatarable
object is initialized, and then reuse that batch item in
`#retrieve_from_store!`. However, this also has problems:

1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
2. Some of that logic constructs a 'fake' model for the batch key. This should
   be fine, because of ActiveRecord's override of `#==`, but it relies on that
   staying the same.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is tricky: the query was being run in
`ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
just add batch loading there, because the `#upload=` method there would use the
result immediately, making the batch only have one item.

Instead, we can pre-emptively add an item to the batch whenever an avatarable
object is initialized, and then reuse that batch item in
`#retrieve_from_store!`. However, this also has problems:

1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
2. Some of that logic constructs a 'fake' model for the batch key. This should
   be fine, because of ActiveRecord's override of `#==`, but it relies on that
   staying the same.
</pre>
</div>
</content>
</entry>
<entry>
<title>Support presigned multipart uploads</title>
<updated>2018-06-04T11:04:29+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-05-09T15:27:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b8370c9f55843351b49073dafe84a2e9858c8c8a'/>
<id>b8370c9f55843351b49073dafe84a2e9858c8c8a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix missing timeout value in object storage pre-authorization call</title>
<updated>2018-05-29T17:01:05+00:00</updated>
<author>
<name>Alessio Caiazza</name>
<email>acaiazza@gitlab.com</email>
</author>
<published>2018-05-29T13:08:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a23ef89e576125740bd33aa64e434c38454790fc'/>
<id>a23ef89e576125740bd33aa64e434c38454790fc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix spec</title>
<updated>2018-05-28T01:44:26+00:00</updated>
<author>
<name>Shinya Maeda</name>
<email>shinya@gitlab.com</email>
</author>
<published>2018-05-28T01:44:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cb2802dbbcacd867336c9d1da214a1c7a9047089'/>
<id>cb2802dbbcacd867336c9d1da214a1c7a9047089</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
