<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/uploaders/workers, branch fix-codequality</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>apply feedback</title>
<updated>2018-06-12T15:22:35+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-06-12T15:22:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d42bab71ad293c99d029dfb4f0c9aa0378643d4'/>
<id>3d42bab71ad293c99d029dfb4f0c9aa0378643d4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>apply feedback</title>
<updated>2018-06-08T14:51:59+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-06-08T14:51:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e1589a5c584acae83d97d41494616be1f3981da7'/>
<id>e1589a5c584acae83d97d41494616be1f3981da7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>shave off another 20% query</title>
<updated>2018-06-07T14:01:47+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-06-07T14:01:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=44975f8a5ad9c40c615f47f683fb46c94aa0e130'/>
<id>44975f8a5ad9c40c615f47f683fb46c94aa0e130</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>shave off 30% of the query count</title>
<updated>2018-06-06T20:45:42+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-06-06T20:45:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=38c2e480bfa180241e94e77c049b1f5256d83bcf'/>
<id>38c2e480bfa180241e94e77c049b1f5256d83bcf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix an N+1 in avatar URLs</title>
<updated>2018-06-05T13:57:19+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-04-19T16:22:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6ecf819f73ae28547e1b816780de0d85c3a653cf'/>
<id>6ecf819f73ae28547e1b816780de0d85c3a653cf</id>
<content type='text'>
This is tricky: the query was being run in
`ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
just add batch loading there, because the `#upload=` method there would use the
result immediately, making the batch only have one item.

Instead, we can pre-emptively add an item to the batch whenever an avatarable
object is initialized, and then reuse that batch item in
`#retrieve_from_store!`. However, this also has problems:

1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
2. Some of that logic constructs a 'fake' model for the batch key. This should
   be fine, because of ActiveRecord's override of `#==`, but it relies on that
   staying the same.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is tricky: the query was being run in
`ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
just add batch loading there, because the `#upload=` method there would use the
result immediately, making the batch only have one item.

Instead, we can pre-emptively add an item to the batch whenever an avatarable
object is initialized, and then reuse that batch item in
`#retrieve_from_store!`. However, this also has problems:

1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
2. Some of that logic constructs a 'fake' model for the batch key. This should
   be fine, because of ActiveRecord's override of `#==`, but it relies on that
   staying the same.
</pre>
</div>
</content>
</entry>
<entry>
<title>apply feedback</title>
<updated>2018-05-09T19:57:08+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-05-09T19:57:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fdfc20c3ff62559d6ae860a5a25a2b211c5f0edb'/>
<id>fdfc20c3ff62559d6ae860a5a25a2b211c5f0edb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>remove the `Upload` redefinition in `MigrateUploadsWorker`</title>
<updated>2018-05-08T14:04:52+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-05-08T14:04:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=59d3e84f0aa09dc41f91e271e3128dfb9613abfa'/>
<id>59d3e84f0aa09dc41f91e271e3128dfb9613abfa</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>backport missing object storage worker specs</title>
<updated>2018-04-02T19:28:56+00:00</updated>
<author>
<name>Micaël Bergeron</name>
<email>mbergeron@gitlab.com</email>
</author>
<published>2018-04-02T19:27:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=10cc6cb56f7e7f72b9366b2f7edfa866dccca8f3'/>
<id>10cc6cb56f7e7f72b9366b2f7edfa866dccca8f3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
