delta/gitlab/gitlab-ce.git/spec/support/services, branch trigger-source

Backport of multiple_assignees_feature [ci skip]

2017-05-04T14:11:53+00:00

Move records to the ghost user in a transaction.

2017-04-24T06:46:10+00:00

- While deleting a user, some of the user's associated records are moved to the
  ghost user so they aren't deleted. The user is blocked before these records
  are moved, to prevent the user from creating new records while the migration
  is happening, and so preventing a data race.

- Previously, if the migration failed, the user would _remain_ blocked, which is
  not the expected behavior. On the other hand, we can't just stick the block +
  migration into a transaction, because we want the block to be committed before
  the migration starts (for the data race reason mentioned above).

- One solution (implemented in this commit) is to block the user in a parent
  transaction, migrate the associated records in a nested sub-transaction, and
  then unblock the user in the parent transaction if the sub-transaction fails.

Implement review comments from @DouweM for !10467.

2017-04-06T17:09:40+00:00

1. Have `MigrateToGhostUser` be a service rather than a mixed-in module, to keep
   things explicit. Specs testing the behavior of this class are moved into a
   separate service spec file.

2. Add a `user.reported_abuse_reports` association to make the
   `migrate_abuse_reports` method more consistent with the other `migrate_`
   methods.

Move a user's award emoji to the ghost user

2017-04-06T13:29:17+00:00

... when the user is destroyed.

1. Normally, for a given awardable and award emoji name, a user is only allowed
   to create a single award emoji.

2. This validation needs to be removed for ghost users, since:

   - User A and User B have created award emoji - with the same name and against
     the same awardable
   - User A is deleted. Their award emoji is moved to the ghost user
   - User B is deleted. Their award emoji needs to be moved to the ghost user.
     However, this breaks the uniqueness validation, since the ghost user is
     only allowed to have one award emoji of a given name for a given awardable

Move a user's notes to the ghost user

2017-04-06T13:28:59+00:00

... when the user is destroyed.

Move a user's merge requests to the ghost user.

2017-04-06T13:28:57+00:00

1. When the user is deleted.

2. Refactor out code relating to "migrating records to the ghost user" into a
   `MigrateToGhostUser` concern, which is tested using a shared example.

Don't use FFaker in factories, use sequences instead

2017-04-03T16:54:48+00:00

FFaker can generate data that randomly break our test suite. This
simplifies our factories and use sequences which are more predictive.

Signed-off-by: Rémy Coutable

Use `:empty_project` where possible in service specs

2017-03-28T00:44:09+00:00

Enable Style/SpaceInsideBrackets

2017-02-23T15:31:56+00:00

fix issue creation from milestone doesn't assign the milestone

2017-02-12T02:02:03+00:00