delta/gitlab/gitlab-ce.git/spec/support/cycle_analytics_helpers, branch convdev-docs gitlab.com: gitlab-org/gitlab-ce.git Reduce the number of loops that Cycle Analytics specs use 2017-02-01T21:14:20+00:00 Robert Speicher rspeicher@gmail.com 2017-01-29T22:53:48+00:00 dd1c410ea4478400e2650f4102726f2ab1a906bd See https://gitlab.com/gitlab-org/gitlab-ce/issues/27402 
See https://gitlab.com/gitlab-org/gitlab-ce/issues/27402
Use `:empty_project` where possible in model specs 2017-01-26T22:44:59+00:00 Robert Speicher rspeicher@gmail.com 2017-01-26T22:44:58+00:00 fcb37542e746d69f20094e2918e498564bbcd863 






refactor fetcher and fixed specs
2017-01-17T10:32:55+00:00

James Lopez
james@jameslopez.es

2016-12-01T11:44:35+00:00

69ecd951a9e0acbc31f0a4b9b02e8a1981ceff1e












fix tricky test failure to do with private method
2017-01-17T10:32:55+00:00

James Lopez
james@jameslopez.es

2016-11-23T14:35:47+00:00

8183e848648bc737e4a09f76f4f55ee1cf106b26












more refactoring and fixing old specs
2017-01-17T10:32:54+00:00

James Lopez
james@jameslopez.es

2016-11-22T13:29:25+00:00

02e1e4819234662faddd7d8eb5c54d9bfdf9e7e6












Implement a second round of review comments from @DouweM.
2016-09-20T19:17:37+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T19:17:37+00:00

918e589c2b29c18d9fe3a8e6c93a3f490c86beb1

- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.





- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
  `Issue#closed_by_merge_requests`  associations. They were either
  shadowing or were too similar to existing methods. They are not being
  used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
  need it.
- Other minor refactorings.







Fix all cycle analytics specs.
2016-09-20T07:53:14+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-20T05:47:36+00:00

d0e101e997347b0b52d4ef3a945a0f26571546a2

A number of failures were introduced due to performance
improvements (like pre-calculating metrics).





A number of failures were introduced due to performance
improvements (like pre-calculating metrics).







Fix rubocop spec.
2016-09-07T09:21:09+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-07T09:21:09+00:00

72b9b87ca93615640dcc022f324b2af16ceaa4eb












Consolidate all cycle analytics helper methods.
2016-09-07T08:59:12+00:00

Timothy Andrew
mail@timothyandrew.net

2016-09-07T08:59:12+00:00

0a767f7b618161278b66f7e1d842a51c8cab37b3

1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration`

2. Move all helper methods (previously placed in each individual spec
   file) to `CycleAnalyticsHelpers`





1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration`

2. Move all helper methods (previously placed in each individual spec
   file) to `CycleAnalyticsHelpers`