<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services, branch api-notes-entity-fields</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'issue_28051_2' into 'master'</title>
<updated>2017-02-22T10:13:33+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2017-02-22T10:13:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7bf28a4adaabac7b974ef7d829e604d77eb9d9df'/>
<id>7bf28a4adaabac7b974ef7d829e604d77eb9d9df</id>
<content type='text'>
Create compare object with default branch when target branch is missing

Closes #28051

See merge request !9263</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Create compare object with default branch when target branch is missing

Closes #28051

See merge request !9263</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '28093-snippet-and-issue-spam-check-on-edit' into 'master'</title>
<updated>2017-02-22T10:13:20+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2017-02-22T10:13:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7e8a6a63af2138c5f3f2030ef8c65e8d4815eed3'/>
<id>7e8a6a63af2138c5f3f2030ef8c65e8d4815eed3</id>
<content type='text'>
Spam check and reCAPTCHA improvements

Closes #28093

See merge request !9248</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Spam check and reCAPTCHA improvements

Closes #28093

See merge request !9248</pre>
</div>
</content>
</entry>
<entry>
<title>Create compare object with default branch when target branch is missing</title>
<updated>2017-02-21T20:11:52+00:00</updated>
<author>
<name>Felipe Artur</name>
<email>felipefac@gmail.com</email>
</author>
<published>2017-02-15T15:01:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=31409030d67858d21281fc72b654246b32f7c6eb'/>
<id>31409030d67858d21281fc72b654246b32f7c6eb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Spam check and reCAPTCHA improvements</title>
<updated>2017-02-21T16:32:49+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2017-02-14T19:07:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2ace39f2420abf018ceef6aaad52e4917bcbab7d'/>
<id>2ace39f2420abf018ceef6aaad52e4917bcbab7d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add user deletion permission check in `Users::DestroyService`</title>
<updated>2017-02-20T16:19:11+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2017-02-04T08:14:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e23c803769955d6728ed048112f8ca21e9b58a47'/>
<id>e23c803769955d6728ed048112f8ca21e9b58a47</id>
<content type='text'>
We saw from a recent incident that the `Users::DestroyService` would
attempt to delete a user over and over. Revoking the permissions
from the current user did not help. We should ensure that the
current user does, in fact, have permissions to delete the user.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We saw from a recent incident that the `Users::DestroyService` would
attempt to delete a user over and over. Revoking the permissions
from the current user did not help. We should ensure that the
current user does, in fact, have permissions to delete the user.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent project team from being truncated too early during project destruction</title>
<updated>2017-02-19T13:00:27+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2017-02-19T13:00:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=45f94ea78cf85a58e71e9a8ae62adc7e3f86bc99'/>
<id>45f94ea78cf85a58e71e9a8ae62adc7e3f86bc99</id>
<content type='text'>
There are two issues with truncating the project team early:

1. `Projects::UnlinkForkService` may not close merge requests properly since
   permissions may be revoked early.

2. If an error is encountered during flushing of caches, then the user will
   lose all privileges, possibly causing an issue on deletion on retry.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are two issues with truncating the project team early:

1. `Projects::UnlinkForkService` may not close merge requests properly since
   permissions may be revoked early.

2. If an error is encountered during flushing of caches, then the user will
   lose all privileges, possibly causing an issue on deletion on retry.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '25465-todo-done-clicking-is-kind-of-unsafe' into 'master'</title>
<updated>2017-02-18T09:06:22+00:00</updated>
<author>
<name>Clement Ho</name>
<email>clemmakesapps@gmail.com</email>
</author>
<published>2017-02-18T09:06:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6eb45df2fd62c85920c3ef025d7dacadcda05bf4'/>
<id>6eb45df2fd62c85920c3ef025d7dacadcda05bf4</id>
<content type='text'>

Todo done clicking is kind of unusable.

Closes #25465

See merge request !8691</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Todo done clicking is kind of unusable.

Closes #25465

See merge request !8691</pre>
</div>
</content>
</entry>
<entry>
<title>Todo done clicking is kind of unusable.</title>
<updated>2017-02-17T21:12:19+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2017-01-16T13:11:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=26160459b56019f445a7d29abc0b72f591e1d2a9'/>
<id>26160459b56019f445a7d29abc0b72f591e1d2a9</id>
<content type='text'>
The Done button will change to an Undo button and the line item will be greyed out.
Bold links will be unbolded.
The user can undo the task by clicking the Undo button.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Done button will change to an Undo button and the line item will be greyed out.
Bold links will be unbolded.
The user can undo the task by clicking the Undo button.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' into fix/gb/pipeline-retry-builds-started</title>
<updated>2017-02-17T13:31:00+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-02-17T13:31:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5f271a9fa2f54f766fc9bd04720c65d2145228d4'/>
<id>5f271a9fa2f54f766fc9bd04720c65d2145228d4</id>
<content type='text'>
* master: (313 commits)
  Allow slashes in slash command arguments
  Add API endpoint to get all milestone merge requests
  remove trailing comma
  Restore pagination to admin abuse reports
  replace deprecated NoErrorsPlugin with NoEmitOnErrorsPlugin
  only compress assets in production
  Reduce number of pipelines created to test pagination
  add CHANGELOG.md entry for !8761
  prevent diff unfolding link from appearing for deleted files
  fix build failures
  only show diff unfolding link if there are more lines to show
  fix typo in node section
  Only yield valid references in ReferenceFilter.references_in
  Cache js selectors; fix css
  move "Install node modules" step before "Migrate DB" within update process
  Renders pagination again for pipelines table
  update migration docs for 8.17 to include minimum node version
  Add CHANGELOG file
  Fix positioning of top scroll button
  Remove comments in migration
  ...
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* master: (313 commits)
  Allow slashes in slash command arguments
  Add API endpoint to get all milestone merge requests
  remove trailing comma
  Restore pagination to admin abuse reports
  replace deprecated NoErrorsPlugin with NoEmitOnErrorsPlugin
  only compress assets in production
  Reduce number of pipelines created to test pagination
  add CHANGELOG.md entry for !8761
  prevent diff unfolding link from appearing for deleted files
  fix build failures
  only show diff unfolding link if there are more lines to show
  fix typo in node section
  Only yield valid references in ReferenceFilter.references_in
  Cache js selectors; fix css
  move "Install node modules" step before "Migrate DB" within update process
  Renders pagination again for pipelines table
  update migration docs for 8.17 to include minimum node version
  Add CHANGELOG file
  Fix positioning of top scroll button
  Remove comments in migration
  ...
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'use-update-runner-service' into 'master'</title>
<updated>2017-02-17T13:03:12+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2017-02-17T13:03:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f662bc5a866dc24580caa48952f25061bae60d1a'/>
<id>f662bc5a866dc24580caa48952f25061bae60d1a</id>
<content type='text'>

Prefer service object over after_save hook

Closes #26921

See merge request !8664</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Prefer service object over after_save hook

Closes #26921

See merge request !8664</pre>
</div>
</content>
</entry>
</feed>
