delta/gitlab/gitlab-ce.git/spec/services, branch ability-batch-issue-checking gitlab.com: gitlab-org/gitlab-ce.git Merge branch 'fix-data-integrity-issue-with-repository-downloads-path' into 'master' 2016-07-21T21:44:53+00:00 Douwe Maan douwe@gitlab.com 2016-07-21T21:44:53+00:00 d2598f6273d4a714134c26ee520b99a40579e8fa Avoid data-integrity issue when cleaning up repository archive cache ## What does this MR do? Sets the default value for `repository_downloads_path` if someone has it configured incorrectly, and it points to the path where repositories are stored. It's also replace invocation of `find` with Ruby code that matches old cached files in a better, and safe way to avoid data-integrity issues. ## Why was this MR needed? The `repository_downloads_path` is used by the `RepositoryArchiveCacheWorker` to remove outdated repository archives, if it points to the wrong directory can cause some data-integrity issue. ## What are the relevant issue numbers? Closes #14222 See merge request !5285 

Avoid data-integrity issue when cleaning up repository archive cache

## What does this MR do?
Sets the default value for `repository_downloads_path` if someone has it configured incorrectly, and it points to the path where repositories are stored. It's also replace invocation of `find` with Ruby code that matches old cached files in a better, and safe way to avoid data-integrity issues.

## Why was this MR needed?
The `repository_downloads_path` is used by the `RepositoryArchiveCacheWorker` to remove outdated repository archives, if it points to the wrong directory can cause some data-integrity issue.

## What are the relevant issue numbers?
Closes #14222

See merge request !5285
 Merge branch 'rs-bulk-issues-update-spec' into 'master' 2016-07-21T19:51:58+00:00 Robert Speicher robert@gitlab.com 2016-07-21T19:51:58+00:00 3f03699e971b513ecf2bee5a91cf4149cdc122e6 Refactor Issues::BulkUpdateService spec - Create fewer Issue objects; 2 is as good as 5 for these cases. This gives us a nice little speed improvement. - Don't `describe` Symbols. - Simplify object creation. - Lessen "mystery guest" antipattern See merge request !5380 

Refactor Issues::BulkUpdateService spec

- Create fewer Issue objects; 2 is as good as 5 for these cases. This
  gives us a nice little speed improvement.
- Don't `describe` Symbols.
- Simplify object creation.
- Lessen "mystery guest" antipattern

See merge request !5380
 Extract helper methods to clean up RepositoryArchiveCleanUpService spec 2016-07-21T14:47:28+00:00 Douglas Barbosa Alexandre dbalexandre@gmail.com 2016-07-21T14:42:44+00:00 2053d89172b5edfa56c7f4e0451fcff74a5e26b5 






Use Dir.mktmpdir instead of FileUtils.mkdir_p in the spec
2016-07-21T14:47:27+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-07-20T23:57:34+00:00

92ee8c5e6489a91d672f51a8807d755e52db4c05












Use find instead Ruby to remove files due to performance reasons
2016-07-21T13:31:49+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-07-20T23:29:25+00:00

79983afbbf052476eee3d86e0b970326e64f8514












Cover the behavior RepositoryArchiveCleanUpService with tests
2016-07-21T13:31:49+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-07-19T23:45:31+00:00

1bda45178977f613a9f4adc1d00e2694ca3963b5












Add service to clean up repository archive cache
2016-07-21T13:31:49+00:00

Douglas Barbosa Alexandre
dbalexandre@gmail.com

2016-07-18T19:38:36+00:00

a6de806498c405355380be4b80f63d134658b779

Replace invocation of `find` with Ruby code that matches old cached
files in a better, and safe way to avoid data-integrity issues.





Replace invocation of `find` with Ruby code that matches old cached
files in a better, and safe way to avoid data-integrity issues.







Refactor Issues::BulkUpdateService spec
2016-07-20T23:59:34+00:00

Robert Speicher
rspeicher@gmail.com

2016-07-20T22:45:19+00:00

97c4a1dceab97cd1388f5bdb1d3f4fd3d228f94b

- Create fewer Issue objects; 2 is as good as 5 for these cases. This
  gives us a nice little speed improvement.
- Don't `describe` Symbols.
- Simplify object creation.
- Lessen "mystery guest" antipattern





- Create fewer Issue objects; 2 is as good as 5 for these cases. This
  gives us a nice little speed improvement.
- Don't `describe` Symbols.
- Simplify object creation.
- Lessen "mystery guest" antipattern







Get rid of `is_image` in FileUploader
2016-07-19T16:51:09+00:00

Rémy Coutable
remy@rymai.me

2016-07-08T16:30:32+00:00

356b2d2bd782289b6130a22531523562514aa7f6

Signed-off-by: Rémy Coutable <remy@rymai.me>





Signed-off-by: Rémy Coutable <remy@rymai.me>







Merge branch 'caironoleto/gitlab-ce-cn-issue-19747'
2016-07-18T21:44:58+00:00

Douwe Maan
douwe@selenight.nl

2016-07-18T21:44:58+00:00

aba558a4a8c7e9e3c691c0e689a0926d4604a26a