delta/gitlab/gitlab-ce.git/spec/services/users/destroy_service_spec.rb, branch scripts-differences

Upgrade Rails to 5.1.6.1

2019-04-23T00:31:23+00:00

Model.new.attributes now also returns encrypted attributes.

Add frozen_string_literal to spec/services

2019-04-11T22:14:54+00:00

Probably useful as we often move these files to "new" files.

[CE] Support multiple assignees for merge requests

2019-04-08T21:40:00+00:00

Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).

Fix: Project deletion may not log audit events during user deletion

2018-08-17T09:23:27+00:00

Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'

2018-07-23T04:34:54+00:00

`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].

This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.

[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle

Use expect_next_instance_of to replace expect_any_instance_of

2018-06-21T15:02:36+00:00

Gitlab::Shell works on shard name, not path

2018-04-25T11:36:22+00:00

Direct disk access is done through Gitaly now, so the legacy path was
deprecated. This path was used in Gitlab::Shell however. This required
the refactoring in this commit.

Added is the removal of direct path access on the project model, as that
lookup wasn't needed anymore is most cases.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1111

Use hashed storage in the specs

2018-02-07T13:40:46+00:00

Remove soft removals related code

2018-01-08T16:04:45+00:00

This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447

Fix user membership destroy relation

2018-01-02T15:06:44+00:00