<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services/suggestions, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Remove 2nd stub expectation of #last_diff_file</title>
<updated>2019-06-05T23:19:45+00:00</updated>
<author>
<name>Kerri Miller</name>
<email>kerrizor@kerrizor.com</email>
</author>
<published>2019-06-04T14:50:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bd624741a170a30c965ff1a2bcf9a0ae1bc763e3'/>
<id>bd624741a170a30c965ff1a2bcf9a0ae1bc763e3</id>
<content type='text'>
It looks to be a stub/mock rather than strictly an expectation of the
system, so dropping this to only a single invocation expected, as we've
removed one of the two places #last_diff_file would be invoked.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It looks to be a stub/mock rather than strictly an expectation of the
system, so dropping this to only a single invocation expected, as we've
removed one of the two places #last_diff_file would be invoked.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix removing empty lines via suggestions</title>
<updated>2019-05-28T07:12:29+00:00</updated>
<author>
<name>Igor</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2019-05-28T07:12:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c92db3db71dc261d547bb08873fdafeff9be98dc'/>
<id>c92db3db71dc261d547bb08873fdafeff9be98dc</id>
<content type='text'>
Before this fix, a suggestion which just removes
an empty line wasn't appliable
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before this fix, a suggestion which just removes
an empty line wasn't appliable
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed test specs</title>
<updated>2019-04-04T13:08:34+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-04-04T13:08:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e540c0d71e00c4ce031b94cf11ec3de905e87da7'/>
<id>e540c0d71e00c4ce031b94cf11ec3de905e87da7</id>
<content type='text'>
- added suggestions to mock data
- fixed props to be not required
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- added suggestions to mock data
- fixed props to be not required
</pre>
</div>
</content>
</entry>
<entry>
<title>Prepare suggestion implementation for multi-line</title>
<updated>2019-03-27T15:26:53+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-03-15T17:35:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=03e0604d5ded6402c7fddc4001ab23d9712c98de'/>
<id>03e0604d5ded6402c7fddc4001ab23d9712c98de</id>
<content type='text'>
Adds the groundwork needed in order to persist multi-line suggestions,
while providing the parsing strategy which will be reused for the
**Preview** as well.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds the groundwork needed in order to persist multi-line suggestions,
while providing the parsing strategy which will be reused for the
**Preview** as well.
</pre>
</div>
</content>
</entry>
<entry>
<title>Always fetch MR latest version when creating suggestions</title>
<updated>2019-02-26T20:19:17+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-02-20T21:20:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e116fcab4151d61087afae17b6bf6cac58be29fc'/>
<id>e116fcab4151d61087afae17b6bf6cac58be29fc</id>
<content type='text'>
This is an issue that can only be seen through EE. Further
details can be seen on
https://gitlab.com/gitlab-org/gitlab-ee/issues/9876. In general
we should always use the latest diff version of a file in order
to both create and apply suggestions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is an issue that can only be seen through EE. Further
details can be seen on
https://gitlab.com/gitlab-org/gitlab-ee/issues/9876. In general
we should always use the latest diff version of a file in order
to both create and apply suggestions.
</pre>
</div>
</content>
</entry>
<entry>
<title>Adjusts suggestions unable to be applied</title>
<updated>2019-01-25T13:30:44+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-01-23T14:42:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1b93b3b640c6dd6377bdddb8beb77f7c3d0da3fc'/>
<id>1b93b3b640c6dd6377bdddb8beb77f7c3d0da3fc</id>
<content type='text'>
1. Presents the system error message when available,
when applying suggestions

2. Adjusts target branch updates affecting MRs pointing
to it when there are previously created suggestions in
the MR. We just need to compare the HEAD shas from
position and MR source branch.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1. Presents the system error message when available,
when applying suggestions

2. Adjusts target branch updates affecting MRs pointing
to it when there are previously created suggestions in
the MR. We just need to compare the HEAD shas from
position and MR source branch.
</pre>
</div>
</content>
</entry>
<entry>
<title>Adjust applied suggestion reverting previous changes</title>
<updated>2019-01-11T23:35:07+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2019-01-10T12:38:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6e293681180870e16cb102817dd588b0357cabca'/>
<id>6e293681180870e16cb102817dd588b0357cabca</id>
<content type='text'>
1. Avoid suggestions being applied on the same file
from reverting previous changes
2. Gracefully use and handle file changes error
when updating the file (though, it does not totally
solves the sync problem for multiple suggestion
applications at once)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1. Avoid suggestions being applied on the same file
from reverting previous changes
2. Gracefully use and handle file changes error
when updating the file (though, it does not totally
solves the sync problem for multiple suggestion
applications at once)
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow suggesting single line changes in diffs</title>
<updated>2018-12-13T19:17:19+00:00</updated>
<author>
<name>Oswaldo Ferreira</name>
<email>oswaldo@gitlab.com</email>
</author>
<published>2018-12-13T19:17:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ed3034bbb71d43b12944a9da29b5264cb3ff3312'/>
<id>ed3034bbb71d43b12944a9da29b5264cb3ff3312</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
