<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services/projects, branch ce-detect-github-pull-requests</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add service to transfer group milestones</title>
<updated>2019-09-04T16:19:31+00:00</updated>
<author>
<name>Eugenia Grieff</name>
<email>egrieff@gitlab.com</email>
</author>
<published>2019-09-04T16:19:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7a3234c68ffa84893333f00021b6dac6453f20cd'/>
<id>7a3234c68ffa84893333f00021b6dac6453f20cd</id>
<content type='text'>
- Add new service that transfers milestones
from a group to a project
- Include new service in Projects transfer service
- Include FromUnion module in Milestone model
to use in transfer service
- Add specs for new milestones service
- Add specs for transferring milestones in
project transfer service
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Add new service that transfers milestones
from a group to a project
- Include new service in Projects transfer service
- Include FromUnion module in Milestone model
to use in transfer service
- Add specs for new milestones service
- Add specs for transferring milestones in
project transfer service
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq</title>
<updated>2019-08-29T22:17:37+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2019-08-29T22:17:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7698d405506bc10dfd7fb2e6e02b419dd5925725'/>
<id>7698d405506bc10dfd7fb2e6e02b419dd5925725</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'security-project-import-bypass' into 'master'</title>
<updated>2019-08-29T21:34:04+00:00</updated>
<author>
<name>GitLab Release Tools Bot</name>
<email>robert+release-tools@gitlab.com</email>
</author>
<published>2019-08-29T21:34:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7d6edff6f3c7483ac588160bdf4e43ec8d0ad5d9'/>
<id>7d6edff6f3c7483ac588160bdf4e43ec8d0ad5d9</id>
<content type='text'>
Project visibility restriction bypass

See merge request gitlab/gitlabhq!3306</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Project visibility restriction bypass

See merge request gitlab/gitlabhq!3306</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-lfs-object-batches' into 'master'</title>
<updated>2019-08-28T11:14:23+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2019-08-28T11:14:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e8bcabb4a735ecb84b5bc65269fffc21a72b6da6'/>
<id>e8bcabb4a735ecb84b5bc65269fffc21a72b6da6</id>
<content type='text'>
Makes LFS object link process OIDs in batches

Closes #66274

See merge request gitlab-org/gitlab-ce!32268</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Makes LFS object link process OIDs in batches

Closes #66274

See merge request gitlab-org/gitlab-ce!32268</pre>
</div>
</content>
</entry>
<entry>
<title>Makes LFS object linker process OIDs in batches</title>
<updated>2019-08-27T22:52:33+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2019-08-27T13:07:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2022e6799bcbf119ea80145e4993ffdb7bb108e3'/>
<id>2022e6799bcbf119ea80145e4993ffdb7bb108e3</id>
<content type='text'>
During a project import, `LfsLinkService` attempts to link `LfsObjects`
that have not already been associated with a project.  It's possible for
a large repo to have thousands of OIDs, which can cause long database
query and parsing times.  By processing a batch of 1000 at a time, we
can reduce that time at the expense of a few more SQL queries.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66274
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
During a project import, `LfsLinkService` attempts to link `LfsObjects`
that have not already been associated with a project.  It's possible for
a large repo to have thousands of OIDs, which can cause long database
query and parsing times.  By processing a batch of 1000 at a time, we
can reduce that time at the expense of a few more SQL queries.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66274
</pre>
</div>
</content>
</entry>
<entry>
<title>CE-specific changes for designs `user_notes_count`</title>
<updated>2019-08-27T20:50:26+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@gitlab.com</email>
</author>
<published>2019-08-27T20:50:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a0b14c40dcb53ddaa247bdfa92fe91e225bcaba6'/>
<id>a0b14c40dcb53ddaa247bdfa92fe91e225bcaba6</id>
<content type='text'>
Notes call `#after_note_created` and `#after_note_destroyed` on their
noteable in callbacks, so the noteable can perform tasks particular to
them, like cache expiry.

This is in preparation of the EE-specific class
`DesignManagement::Design` clearing its `user_notes_count` cache when
its note are created or destroyed.

Refactoring Rspec behaviour testing of a counter caching service into a
shared example.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13353
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Notes call `#after_note_created` and `#after_note_destroyed` on their
noteable in callbacks, so the noteable can perform tasks particular to
them, like cache expiry.

This is in preparation of the EE-specific class
`DesignManagement::Design` clearing its `user_notes_count` cache when
its note are created or destroyed.

Refactoring Rspec behaviour testing of a counter caching service into a
shared example.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13353
</pre>
</div>
</content>
</entry>
<entry>
<title>Add service classes for mutating AwardEmoji</title>
<updated>2019-08-20T23:39:41+00:00</updated>
<author>
<name>Luke Duncalfe</name>
<email>lduncalfe@eml.cc</email>
</author>
<published>2019-06-18T01:44:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=37b17fa61a1fb5efe5942ab2cb27b15685bf905e'/>
<id>37b17fa61a1fb5efe5942ab2cb27b15685bf905e</id>
<content type='text'>
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow disabling group/project email notifications</title>
<updated>2019-08-15T17:37:36+00:00</updated>
<author>
<name>Brett Walker</name>
<email>bwalker@gitlab.com</email>
</author>
<published>2019-08-15T17:37:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3489dc3d7277bf478f68e1b3e0353b702f652acc'/>
<id>3489dc3d7277bf478f68e1b3e0353b702f652acc</id>
<content type='text'>
- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix project import restricted visibility bypass</title>
<updated>2019-08-15T09:30:47+00:00</updated>
<author>
<name>George Koltsov</name>
<email>gkoltsov@gitlab.com</email>
</author>
<published>2019-08-06T13:05:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=06eddc3edfa739c0c685d461a58621b43c4ecd5d'/>
<id>06eddc3edfa739c0c685d461a58621b43c4ecd5d</id>
<content type='text'>
Add Gitlab::VisibilityLevelChecker that verifies
selected project visibility level (or overridden param)
is not restricted when creating or importing a project
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add Gitlab::VisibilityLevelChecker that verifies
selected project visibility level (or overridden param)
is not restricted when creating or importing a project
</pre>
</div>
</content>
</entry>
<entry>
<title>Rework retry strategy for remote mirrors</title>
<updated>2019-08-13T20:52:01+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@gitlab.com</email>
</author>
<published>2019-08-13T20:52:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=452bc36d603ed89d3fa5e3409338dd905230bd2f'/>
<id>452bc36d603ed89d3fa5e3409338dd905230bd2f</id>
<content type='text'>
**Prevention of running 2 simultaneous updates**

Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.

When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.

If the mirror already ran since it was scheduled, the job will be
skipped.

**Error handling: Remote side**

When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.

In this case, we'll try 3 times scheduled 1 or 5 minutes apart.

In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.

After 3 tries we'll mark the mirror as failed and notify the user.

We won't track this error in sentry, as it's not likely we can help
it.

The next event that would trigger a new refresh.

**Error handling: our side**

If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to

The error would be reported in sentry, since its likely we need to do
something about it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
**Prevention of running 2 simultaneous updates**

Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.

When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.

If the mirror already ran since it was scheduled, the job will be
skipped.

**Error handling: Remote side**

When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.

In this case, we'll try 3 times scheduled 1 or 5 minutes apart.

In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.

After 3 tries we'll mark the mirror as failed and notify the user.

We won't track this error in sentry, as it's not likely we can help
it.

The next event that would trigger a new refresh.

**Error handling: our side**

If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to

The error would be reported in sentry, since its likely we need to do
something about it.
</pre>
</div>
</content>
</entry>
</feed>
