delta/gitlab/gitlab-ce.git/spec/services/notification_service_spec.rb, branch diff-notes-refactor

Fix notification when global=disabled, group=watch

2017-01-30T17:21:54+00:00

Signed-off-by: Rémy Coutable

Merge branch 'get-rid-of-water-from-notification_service_spec-to-make-it-DRY' into 'master'

2017-01-27T13:57:13+00:00

Make notification_service spec DRYer by making some tests reusable

See merge request !7794

make mentions working when project not specified

2017-01-18T23:38:17+00:00

Support notes without project

2017-01-18T23:38:17+00:00

Make notification_service spec DRYer by making some tests reusable

2016-12-12T11:36:36+00:00

The spec for 'participatns' notifications in notification_service for both
issue and merge_request is pretty simple but it was fully copied without sagnificant changes
8 times (!!!) for EVERY situation you need to notify this group of user which caused to file
to extra growth and not being very DRY. And I love DRY. Since the spec is already too messy  and
most likely gonna to increase the size nearest time, I decided to refactor those parts.

Only include EmailHelpers in mailer specs and specs using them

2016-12-01T04:17:33+00:00

Add shortcuts for adding users to a project team with a specific role

2016-11-18T12:55:04+00:00

This also updates _some_ specs to use these new methods, just to serve
as an example for others going forward, but by no means is this
exhaustive.

Original implementations at !5992 and !6012.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20944

Allow subscriptions to be created without a project

2016-11-17T17:10:13+00:00

Remove default value for `project` argument on subscribable concern

2016-11-17T17:10:13+00:00

Refactoring notification service to find subscriptions per project

2016-11-17T17:10:13+00:00