<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services/keys, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add frozen_string_literal to spec/services</title>
<updated>2019-04-11T22:14:54+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-11T12:17:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=85b29c1c2fa3b94d7371cf454c485457a0756cb1'/>
<id>85b29c1c2fa3b94d7371cf454c485457a0756cb1</id>
<content type='text'>
Probably useful as we often move these files to "new" files.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Probably useful as we often move these files to "new" files.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rails5 fix MySQL milliseconds problem in specs</title>
<updated>2018-06-27T16:49:22+00:00</updated>
<author>
<name>Jasper Maes</name>
<email>jaspermaes.jm@gmail.com</email>
</author>
<published>2018-06-27T16:25:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f0eaf225538b40db5d0b2a6110378b65a240eac8'/>
<id>f0eaf225538b40db5d0b2a6110378b65a240eac8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce a new Keys::DestroyService service</title>
<updated>2018-05-16T18:26:22+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-05-16T18:26:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6d81905fafb23f20520eb5ffa46c94b18ccc8686'/>
<id>6d81905fafb23f20520eb5ffa46c94b18ccc8686</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Simplify a test</title>
<updated>2017-09-21T12:19:05+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2017-09-21T12:19:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=5af846539678a6a6a8959559a069da4243029720'/>
<id>5af846539678a6a6a8959559a069da4243029720</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Stop using Sidekiq for updating Key#last_used_at</title>
<updated>2017-09-20T12:24:14+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-09-20T12:21:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b3566a01049cdfbde2a9221319601d8949c12a5a'/>
<id>b3566a01049cdfbde2a9221319601d8949c12a5a</id>
<content type='text'>
This makes things simpler as no scheduling is involved. Further we
remove the need for running a SELECT + UPDATE just to get the key and
update it, whereas we only need an UPDATE when setting last_used_at
directly in a request.

The added service class takes care of updating Key#last_used_at without
using Sidekiq. Further it makes sure we only try to obtain a Redis lease
if we're confident that we actually need to do so, instead of always
obtaining it. We also make sure to _only_ update last_used_at instead of
also updating updated_at.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes things simpler as no scheduling is involved. Further we
remove the need for running a SELECT + UPDATE just to get the key and
update it, whereas we only need an UPDATE when setting last_used_at
directly in a request.

The added service class takes care of updating Key#last_used_at without
using Sidekiq. Further it makes sure we only try to obtain a Redis lease
if we're confident that we actually need to do so, instead of always
obtaining it. We also make sure to _only_ update last_used_at instead of
also updating updated_at.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
</pre>
</div>
</content>
</entry>
<entry>
<title>created services for keys</title>
<updated>2017-09-15T15:35:24+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@gmail.com</email>
</author>
<published>2017-09-15T15:35:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cc2daa74d83c98dc05dd92f0950a122b46b83c96'/>
<id>cc2daa74d83c98dc05dd92f0950a122b46b83c96</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
