<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services/issues, branch remove-commit-tree</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch '36782-replace-team-user-role-with-add_role-user-in-specs' into 'master'</title>
<updated>2017-12-23T14:09:42+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-12-23T14:09:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6c967c2b5b9760d0df6bcff70c059858abf971ec'/>
<id>6c967c2b5b9760d0df6bcff70c059858abf971ec</id>
<content type='text'>
Resolve "Replace '.team &lt;&lt; [user, role]' with 'add_role(user)' in specs"

Closes #36782

See merge request gitlab-org/gitlab-ce!16069</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolve "Replace '.team &lt;&lt; [user, role]' with 'add_role(user)' in specs"

Closes #36782

See merge request gitlab-org/gitlab-ce!16069</pre>
</div>
</content>
</entry>
<entry>
<title>Execute project hooks and services after commit when moving an issue</title>
<updated>2017-12-22T16:19:50+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@selenight.nl</email>
</author>
<published>2017-12-22T10:38:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=16b8297e77501134cd93a74c3d5c60712930e7fd'/>
<id>16b8297e77501134cd93a74c3d5c60712930e7fd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace '.team &lt;&lt; [user, role]' with 'add_role(user)' in specs</title>
<updated>2017-12-22T08:18:28+00:00</updated>
<author>
<name>blackst0ne</name>
<email>blackst0ne.ru@gmail.com</email>
</author>
<published>2017-12-22T08:18:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=27c95364b52f4e93054c45211010aeb22e40a2b2'/>
<id>27c95364b52f4e93054c45211010aeb22e40a2b2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't create todos for old issue assignees</title>
<updated>2017-10-09T13:12:39+00:00</updated>
<author>
<name>Jarka Kadlecova</name>
<email>jarka@gitlab.com</email>
</author>
<published>2017-10-04T16:24:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6612fbcee7245325ee9799f49b5ea46a5037308'/>
<id>d6612fbcee7245325ee9799f49b5ea46a5037308</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'origin/master' into 18608-lock-issues</title>
<updated>2017-09-20T14:23:00+00:00</updated>
<author>
<name>Luke "Jared" Bennett</name>
<email>lbennett@gitlab.com</email>
</author>
<published>2017-09-20T14:23:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ff7b545c8e462b909af92a5bea58de779c3f438b'/>
<id>ff7b545c8e462b909af92a5bea58de779c3f438b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix refreshing of issues/MR count caches</title>
<updated>2017-09-19T15:16:45+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-09-19T11:55:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=57b96eb6db9b860991b035714e65ffd557327b6f'/>
<id>57b96eb6db9b860991b035714e65ffd557327b6f</id>
<content type='text'>
This ensures the open issues/MR count caches are refreshed properly when
creating new issues or MRs. This MR also includes a change to the cache
keys to ensure all caches are rebuilt on the fly.

This particular problem was not caught in the test suite due to a null
cache being used, resulting in all calls that would use a cache using
the underlying data directly. In production the code would fail because
a newly saved record returns an empty hash in #changes meaning checks
such as `state_changed? || confidential_changed?` would return false for
new rows, thus never updating the counters.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This ensures the open issues/MR count caches are refreshed properly when
creating new issues or MRs. This MR also includes a change to the cache
keys to ensure all caches are rebuilt on the fly.

This particular problem was not caught in the test suite due to a null
cache being used, resulting in all calls that would use a cache using
the underlying data directly. In production the code would fail because
a newly saved record returns an empty hash in #changes meaning checks
such as `state_changed? || confidential_changed?` would return false for
new rows, thus never updating the counters.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
</pre>
</div>
</content>
</entry>
<entry>
<title>Create system notes for MR too, improve doc + clean up code</title>
<updated>2017-09-14T12:50:32+00:00</updated>
<author>
<name>Jarka Kadlecova</name>
<email>jarka@gitlab.com</email>
</author>
<published>2017-09-01T12:03:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=994e7d135947ca162c147c5e0992a0190de22808'/>
<id>994e7d135947ca162c147c5e0992a0190de22808</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Support discussion locking in the backend</title>
<updated>2017-09-14T12:50:32+00:00</updated>
<author>
<name>Jarka Kadlecova</name>
<email>jarka@gitlab.com</email>
</author>
<published>2017-08-30T14:57:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9287208523e1a5c05939fe0db038df51a9082fc'/>
<id>b9287208523e1a5c05939fe0db038df51a9082fc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ee_issue_928_backport</title>
<updated>2017-09-06T04:35:58+00:00</updated>
<author>
<name>Simon Knox</name>
<email>psimyn@gmail.com</email>
</author>
<published>2017-09-06T04:35:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b9aa55e1ea2ba226bd9bf4c6fb08fdec30e046c5'/>
<id>b9aa55e1ea2ba226bd9bf4c6fb08fdec30e046c5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a spec failure dependent on load order</title>
<updated>2017-09-01T22:13:00+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2017-09-01T22:13:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7cc19cd5abb4ae8649e960c71d531adccb880a89'/>
<id>7cc19cd5abb4ae8649e960c71d531adccb880a89</id>
<content type='text'>
We were incorrectly stubbing `Issues::MoveService#execute`. This only
caused a failure when another spec caused it to be autoloaded --
`spec/controllers/projects/issues_controller_spec.rb` in this case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We were incorrectly stubbing `Issues::MoveService#execute`. This only
caused a failure when another spec caused it to be autoloaded --
`spec/controllers/projects/issues_controller_spec.rb` in this case.
</pre>
</div>
</content>
</entry>
</feed>
