delta/gitlab/gitlab-ce.git/spec/services/groups, branch patch-14 gitlab.com: gitlab-org/gitlab-ce.git Include nested group into destroy_service_spec 2017-02-27T12:28:02+00:00 Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com 2017-02-27T12:28:02+00:00 334591dd766ca31ab087475bfefbb5eb9dd1a0cf Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Fix a number of race conditions that can occur during namespace deletion 2017-02-16T07:56:40+00:00 Stan Hu stanhu@gmail.com 2017-02-16T07:50:05+00:00 6606a45030ecd4035b095d33d32f1372c3562b02 There are two problems in the current implementation: 1. If a project is marked for deletion via the `pending_delete` flag and then the namespace was quickly deleted, it's possible that the namespace skips over that project and leaves that project in an orphaned state. 2. Before namespace deletion, the namespace attempts to clean up all the relevant storage paths. However, if all projects have been removed synchronously, then the namespace will not be able to clean anything. To prevent this, we should load the paths to be deleted before actually destroying projects. The specs were missing this second case due to a permission issue that caused project removal never to happen. 
There are two problems in the current implementation:

1. If a project is marked for deletion via the `pending_delete` flag
and then the namespace was quickly deleted, it's possible that the
namespace skips over that project and leaves that project in
an orphaned state.

2. Before namespace deletion, the namespace attempts to clean up
all the relevant storage paths. However, if all projects have been
removed synchronously, then the namespace will not be able to clean anything.
To prevent this, we should load the paths to be deleted before
actually destroying projects.

The specs were missing this second case due to a permission issue
that caused project removal never to happen.
Fix inconsistent naming for services that delete things 2017-02-08T08:16:43+00:00 dixpac dino.onex@gmail.com 2016-08-13T12:45:31+00:00 0dacf3c169a85e6f3a1c70f3f5e377d47f770d19 * Changed name of delete_user_service and worker to destroy * Move and change delete_group_service to Groups::DestroyService * Rename Notes::DeleteService to Notes::DestroyService 
* Changed name of delete_user_service and worker to destroy
* Move and change delete_group_service to Groups::DestroyService
* Rename Notes::DeleteService to Notes::DestroyService
Use random group name to prevent conflicts 2017-02-07T04:09:07+00:00 Douwe Maan douwe@selenight.nl 2017-02-07T04:08:51+00:00 f5a798c7434bf236f36b399347c49fa3edf1f04e 






Add nested groups support to the Groups::CreateService
2016-12-26T09:56:19+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-12-26T09:56:19+00:00

9410f215eab0ba49051d2a00f0b4174f5dc13a6f

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







added more specs
2016-12-21T12:29:27+00:00

James Lopez
james@jameslopez.es

2016-12-21T12:29:27+00:00

4c3ec579e5660daab23d48bd4b3e21050735f726












Fix error 500 renaming group. Also added specs and changelog.
2016-12-20T16:52:27+00:00

James Lopez
james@jameslopez.es

2016-12-20T16:52:27+00:00

b82fdf6257255b720526ccef716759892e88de09












Update tests for the current_application_settings request store changes
2016-05-28T02:05:52+00:00

DJ Mountney
david@twkie.net

2016-05-28T02:05:52+00:00

7d57b110934f50225142789a93a0d4f54cf446f7












Enable RSpec/NotToNot cop and auto-correct offenses
2016-05-24T19:40:29+00:00

Robert Speicher
rspeicher@gmail.com

2016-05-23T23:37:59+00:00

75739e54be0fca389c05d3d9d3de69737c0ff3ab

Also removes the note from the development/testing.md guide





Also removes the note from the development/testing.md guide







Fix specs
2016-03-20T22:26:58+00:00

Douwe Maan
douwe@selenight.nl

2016-03-20T22:26:58+00:00

45e8650c4f987f0a25d829bf8ac189b023f1eaa3