<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/services/clusters/create_service_spec.rb, branch scripts-differences</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Add frozen_string_literal to spec/services</title>
<updated>2019-04-11T22:14:54+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2019-04-11T12:17:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=85b29c1c2fa3b94d7371cf454c485457a0756cb1'/>
<id>85b29c1c2fa3b94d7371cf454c485457a0756cb1</id>
<content type='text'>
Probably useful as we often move these files to "new" files.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Probably useful as we often move these files to "new" files.
</pre>
</div>
</content>
</entry>
<entry>
<title>Abstract out project out of ClustersController</title>
<updated>2018-11-01T06:36:58+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2018-10-19T01:42:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=88800abcd8741b07114c2850e00b74fbecfbf90e'/>
<id>88800abcd8741b07114c2850e00b74fbecfbf90e</id>
<content type='text'>
To the extent possible swap out `project` with `clusterable`

- Abstract paths for showing cluster or clusters. This will allow us to
swap in alternative paths for group level cluster

- Push :project_id and :namespace_id params from the URL to the POST
body.

- Create a nice helper for to generate links for the destroy
action

For some reason, spec :project_id and :namespace_id param are not going
through `to_param` for a JSON format. Manually call `to_param` to fix
specs.

- Move :layout to BaseController
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
To the extent possible swap out `project` with `clusterable`

- Abstract paths for showing cluster or clusters. This will allow us to
swap in alternative paths for group level cluster

- Push :project_id and :namespace_id params from the URL to the POST
body.

- Create a nice helper for to generate links for the destroy
action

For some reason, spec :project_id and :namespace_id param are not going
through `to_param` for a JSON format. Manually call `to_param` to fix
specs.

- Move :layout to BaseController
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch 'refactor-cluster-create-service-spec' into 'master'"</title>
<updated>2018-10-22T20:12:26+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2018-10-22T20:12:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=305ab0405aca2270e6db24f9b53a0aa1ec9aa92e'/>
<id>305ab0405aca2270e6db24f9b53a0aa1ec9aa92e</id>
<content type='text'>
This reverts merge request !22407</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !22407</pre>
</div>
</content>
</entry>
<entry>
<title>Move shared examples into the only file where used</title>
<updated>2018-10-16T21:43:14+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2018-10-16T08:05:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c3c22cb210dd1545b1a4ef500643480836245bae'/>
<id>c3c22cb210dd1545b1a4ef500643480836245bae</id>
<content type='text'>
This will make it easier to perform in place adjustments, etc for future
MRs involving group clusters.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will make it easier to perform in place adjustments, etc for future
MRs involving group clusters.
</pre>
</div>
</content>
</entry>
<entry>
<title>Pass in project as kwarg for CreateService</title>
<updated>2018-10-14T22:01:09+00:00</updated>
<author>
<name>Thong Kuah</name>
<email>tkuah@gitlab.com</email>
</author>
<published>2018-10-10T23:15:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=19e1024bb874cdb9d912dd7de3cbc8f26daad048'/>
<id>19e1024bb874cdb9d912dd7de3cbc8f26daad048</id>
<content type='text'>
This enables us to have other options in the future such as passing in
`group:`.

Also, remove project arg from UpdateService, as un-used.

This will help group cluster controller to re-use this services.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enables us to have other options in the future such as passing in
`group:`.

Also, remove project arg from UpdateService, as un-used.

This will help group cluster controller to re-use this services.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract shared components from Clusters::CreateService spec</title>
<updated>2018-05-13T12:17:34+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-05-13T12:17:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f96552c7c78836877f982eb9b66359e05c0dbb58'/>
<id>f96552c7c78836877f982eb9b66359e05c0dbb58</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rearrange DeploymentPlatform methods</title>
<updated>2018-03-22T20:52:33+00:00</updated>
<author>
<name>Mayra Cabrera</name>
<email>mcabrera@gitlab.com</email>
</author>
<published>2018-03-21T14:59:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ca59bfdc6657fc20a27e93f41fc9e38c41498389'/>
<id>ca59bfdc6657fc20a27e93f41fc9e38c41498389</id>
<content type='text'>
- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove redundant empty line in CreateService spec</title>
<updated>2017-12-05T23:54:26+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2017-12-05T23:54:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0ef16b272002013bbdb44517e62f0a1d15046cf5'/>
<id>0ef16b272002013bbdb44517e62f0a1d15046cf5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor Clusters::CreateService spec</title>
<updated>2017-12-05T23:09:03+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2017-12-05T22:40:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dbb8644c240615f8a264b3b0f49fa9936d69fd3d'/>
<id>dbb8644c240615f8a264b3b0f49fa9936d69fd3d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Raise error when trying to create second cluster</title>
<updated>2017-12-03T16:33:38+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2017-12-03T16:33:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=363c57468dc6f656c6c345f0b9eda32029571201'/>
<id>363c57468dc6f656c6c345f0b9eda32029571201</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
