<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/rubocop/cop, branch parallel-db-migrations</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'update-large-tables-cop' into 'master'</title>
<updated>2018-06-22T13:22:15+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzegorz@gitlab.com</email>
</author>
<published>2018-06-22T13:22:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d30596226d11fdb1d306f1563417a52425f95951'/>
<id>d30596226d11fdb1d306f1563417a52425f95951</id>
<content type='text'>
Disallow methods that copy data on large tables

See merge request gitlab-org/gitlab-ce!20021</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Disallow methods that copy data on large tables

See merge request gitlab-org/gitlab-ce!20021</pre>
</div>
</content>
</entry>
<entry>
<title>Add a cop for `FinderMethods`</title>
<updated>2018-06-20T16:13:13+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@vanlanduyt.co</email>
</author>
<published>2018-06-18T08:31:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=f3f1df1476ba7fe223e5d8d6707a7675dc9fa597'/>
<id>f3f1df1476ba7fe223e5d8d6707a7675dc9fa597</id>
<content type='text'>
This notifies developers when calling `find(_by!)` chained on
`execute`. And suggests using the methods from `FinderMethods`. These
will perform the correct authorization checks on the resource when it
is found.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This notifies developers when calling `find(_by!)` chained on
`execute`. And suggests using the methods from `FinderMethods`. These
will perform the correct authorization checks on the resource when it
is found.
</pre>
</div>
</content>
</entry>
<entry>
<title>Disallow methods that copy data on large tables</title>
<updated>2018-06-19T16:18:15+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-06-19T16:18:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eb086a4bfd2495168483a2652571f247e6b768a5'/>
<id>eb086a4bfd2495168483a2652571f247e6b768a5</id>
<content type='text'>
{change_column_type,rename_column}_concurrently both copy data from one column
to another during a migration, which should not be done on GitLab.com. Instead,
we should use background migrations.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
{change_column_type,rename_column}_concurrently both copy data from one column
to another during a migration, which should not be done on GitLab.com. Instead,
we should use background migrations.
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow comment after if/unless clause</title>
<updated>2018-05-29T08:38:59+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-05-28T13:00:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1c5106fadfe59ec4af7235b94d424e4367185c2e'/>
<id>1c5106fadfe59ec4af7235b94d424e4367185c2e</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert the addition of goldiloader</title>
<updated>2018-04-18T13:51:39+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-04-18T13:41:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6f292eaa69c771cec8a81d2edaad19a26ab3eae6'/>
<id>6f292eaa69c771cec8a81d2edaad19a26ab3eae6</id>
<content type='text'>
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts the addition of the "goldiloader" Gem and all use of it.
While this Gem is very promising it's causing a variety of problems on
GitLab.com due to it eager-loading too much data in places where we
don't expect/can handle this. At least for the time being this means we
have to go back to manually fixing N+1 query problems, but at least
those should not cause a negative impact on availability.
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve "Make a Rubocop that forbids returning from a block"</title>
<updated>2018-04-18T09:19:40+00:00</updated>
<author>
<name>🙈  jacopo beschi 🙉</name>
<email>intrip@gmail.com</email>
</author>
<published>2018-04-18T09:19:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e'/>
<id>c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add cop for has_many :through without disabled autoloading</title>
<updated>2018-04-09T11:47:04+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@gitlab.com</email>
</author>
<published>2018-04-09T11:19:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24'/>
<id>4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24</id>
<content type='text'>
Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce a new FactoriesInMigrationSpecs cop</title>
<updated>2018-04-06T15:41:52+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2018-03-30T15:18:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4b035896c4ed188c0b4ab0e0b5d1d97e4fef9886'/>
<id>4b035896c4ed188c0b4ab0e0b5d1d97e4fef9886</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fj-15329-services-callbacks-ssrf' into 'security-10-6'</title>
<updated>2018-03-21T14:39:21+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2018-03-13T22:38:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=95ced3bb5fa52e166aa03ee592f63180601cbde7'/>
<id>95ced3bb5fa52e166aa03ee592f63180601cbde7</id>
<content type='text'>
Server Side Request Forgery in Services and Web Hooks

See merge request gitlab/gitlabhq!2337</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Server Side Request Forgery in Services and Web Hooks

See merge request gitlab/gitlabhq!2337</pre>
</div>
</content>
</entry>
<entry>
<title>Make sure it's not offending to use local ||= val</title>
<updated>2018-01-12T16:24:12+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2018-01-12T16:17:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6c69373e54b76232f361aa631e7b6283d3c71ef'/>
<id>d6c69373e54b76232f361aa631e7b6283d3c71ef</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
