<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/requests/ci, branch multi-line-inline-diff</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Use describe rather than context for this:</title>
<updated>2016-07-04T15:05:05+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-04T15:05:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=36a73929df7cb47a428fb04740ee81f497327edb'/>
<id>36a73929df7cb47a428fb04740ee81f497327edb</id>
<content type='text'>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964/diffs#note_12867416

Guidelines:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/testing.md#general-guidelines

&gt; Use `context` to test branching logic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964/diffs#note_12867416

Guidelines:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/testing.md#general-guidelines

&gt; Use `context` to test branching logic.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use describe rather than context, feedback from:</title>
<updated>2016-07-04T11:06:34+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-04T11:06:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=79d7e71487db07926065f17c0430df2e8a9fc574'/>
<id>79d7e71487db07926065f17c0430df2e8a9fc574</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12861588
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12861588
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename to "successful artifacts upload", feedback:</title>
<updated>2016-07-04T11:04:51+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-04T11:04:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7cc6a703f6fdec3aba3dfe857624dc3ad54ad7cf'/>
<id>7cc6a703f6fdec3aba3dfe857624dc3ad54ad7cf</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12861577
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12861577
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename shared_examples, feedback:</title>
<updated>2016-07-01T06:30:39+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-07-01T06:30:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ef960286e552007a8c4e039de9ea5b3aa71e4669'/>
<id>ef960286e552007a8c4e039de9ea5b3aa71e4669</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12817406
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12817406
</pre>
</div>
</content>
</entry>
<entry>
<title>Use nil for non-existing files rather than 0</title>
<updated>2016-06-30T16:00:35+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-30T16:00:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=7b06acea1c13b7fa9067902faaed73c7210f4bb3'/>
<id>7b06acea1c13b7fa9067902faaed73c7210f4bb3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use AR callbacks as suggested by:</title>
<updated>2016-06-29T09:44:39+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-29T09:44:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9d8dca08e440ccb730f20dcd79b3b47aef8aeb2e'/>
<id>9d8dca08e440ccb730f20dcd79b3b47aef8aeb2e</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12744656
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12744656
</pre>
</div>
</content>
</entry>
<entry>
<title>Also remove ci_builds.artifacts_size when erased</title>
<updated>2016-06-28T12:37:46+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T12:37:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1bc0d732f604d7a4a616ba34b8ccbb1987038951'/>
<id>1bc0d732f604d7a4a616ba34b8ccbb1987038951</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Just save the size in total rather than individual files</title>
<updated>2016-06-28T11:16:48+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T11:16:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0a294698db01112c407575e690a8a368be6b15f8'/>
<id>0a294698db01112c407575e690a8a368be6b15f8</id>
<content type='text'>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12741046
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4964#note_12741046
</pre>
</div>
</content>
</entry>
<entry>
<title>Introduce ci_builds.artifacts_sizes as JSON:</title>
<updated>2016-06-28T10:14:21+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T10:14:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fe0c59d2e61238e1241be448a37be0e3e702a5ce'/>
<id>fe0c59d2e61238e1241be448a37be0e3e702a5ce</id>
<content type='text'>
We store the sizes as a hash from path to bytes like:

``` ruby
{'ci_artifacts.txt' =&gt; 27,
 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' =&gt;
71759,
 'other_artifacts_0.1.2/doc_sample.txt' =&gt; 1314,
 'rails_sample.jpg' =&gt; 35255,
 'tests_encoding/utf8 test dir ✓/regular_file_2' =&gt; 7}
```

So that it's easier to access than reading gzip file again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We store the sizes as a hash from path to bytes like:

``` ruby
{'ci_artifacts.txt' =&gt; 27,
 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' =&gt;
71759,
 'other_artifacts_0.1.2/doc_sample.txt' =&gt; 1314,
 'rails_sample.jpg' =&gt; 35255,
 'tests_encoding/utf8 test dir ✓/regular_file_2' =&gt; 7}
```

So that it's easier to access than reading gzip file again.
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup the tests a bit in order to extend it</title>
<updated>2016-06-28T08:46:16+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2016-06-28T08:46:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aa3a3fd12fc7152020ffbe54faa36a4f17eb94b2'/>
<id>aa3a3fd12fc7152020ffbe54faa36a4f17eb94b2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
