delta/gitlab/gitlab-ce.git/spec/requests/api/projects_spec.rb, branch feature/project-export gitlab.com: gitlab-org/gitlab-ce.git Restrict starred projects to viewable ones 2016-05-10T17:13:52+00:00 Sean McGivern sean@gitlab.com 2016-05-10T17:03:55+00:00 97424ea544d0954e582a356586270e983d3bbb7a `User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects. 
`User#starred_projects` doesn't perform any visibility checks. This has
a couple of problems:

1. It assumes a user can always view all of their starred projects in
   perpetuity (project not changed to private, access revoked, etc.).
2. It assumes that we'll only ever allow a user to star a project they
   can view. This is currently the case, but bugs happen.

Add `User#viewable_starred_projects` to filter the starred projects by
those the user either has explicit access to, or are public or
internal. Then use that in all places where we list the user's starred
projects.
Prevent private snippets in public/internal projects from being leaked via API 2016-04-25T19:02:06+00:00 Stan Hu stanhu@gmail.com 2016-04-25T04:45:26+00:00 d5267dfd0dac8e4cab4919bf8aca611de3a5497b Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15580 
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15580
Styling changes to code and docs 2016-04-13T14:25:24+00:00 Robert Schilling rschilling@student.tugraz.at 2016-04-13T10:50:00+00:00 54231aa4e036179d035ddd3641bc15a5b31883f2 






Make staring API more restful
2016-04-13T12:26:41+00:00

Robert Schilling
rschilling@student.tugraz.at

2016-04-12T16:52:43+00:00

3ab9ea8dae1edc6ab8c8563843342890736eb24c












API: Star and unstar a project
2016-04-13T12:26:40+00:00

Robert Schilling
rschilling@student.tugraz.at

2016-04-06T13:52:16+00:00

ea2193aaeb1127746dc78d2dda7037d998911662












PUT becomes POST on archiving endpoints
2016-03-24T17:58:42+00:00

Zeger-Jan van de Weg
zegerjan@gitlab.com

2016-03-24T12:36:45+00:00

3549d7c1d402c10c567c239b006132c45b0c0d1e

Also the specs have a minor improvement. Mainly the access right spec.
Changes are reflected in the docs





Also the specs have a minor improvement. Mainly the access right spec.
Changes are reflected in the docs







Add endpoints for archiving and unarchiving
2016-03-23T21:36:35+00:00

Zeger-Jan van de Weg
zegerjan@gitlab.com

2016-03-23T21:36:35+00:00

2c5bcf2e1b5b5574238555657296a8831b989d1e












Fix specs
2016-03-19T00:04:53+00:00

Felipe Artur
felipefac@gmail.com

2016-03-19T00:04:53+00:00

8b830b8c3b32774e8ccf562b8bc9dbce3ecf3073












Bring share project with group API from EE
2016-03-13T10:52:43+00:00

Dmitriy Zaporozhets
dmitriy.zaporozhets@gmail.com

2016-03-13T10:46:16+00:00

e8b3b92ddebc47595fe4b69dc5b5a3a6dd1365ab

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>





Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>







Add traits for each access_level to ProjectMember factory
2016-03-06T21:53:22+00:00

Robert Speicher
rspeicher@gmail.com

2016-03-06T21:53:22+00:00

de944c914b2a780a5e968cc32ef64cddd2b82c9b