delta/gitlab/gitlab-ce.git/spec/models/protectable_dropdown_spec.rb, branch remove-commit-tree

Whitelist or fix additional `Gitlab/PublicSend` cop violations

2017-08-14T16:14:11+00:00

An upcoming update to rubocop-gitlab-security added additional
violations.

Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true

2017-07-27T12:31:53+00:00

Signed-off-by: Rémy Coutable

Protected Tags backend review changes

2017-04-06T09:56:21+00:00

Added changelog

Extracted ProtectableDropdown to clean up Project#open_branches

2017-04-03T16:19:53+00:00

Makes it clear this is only used in dropdowns, instead of cluttering up Project class. Since we only care about branch names, it is also possible to refactor out a lot of the set/reject logic.

A benchmark on Array/Set subtraction favoured using Arrays. This was with 5000 ‘branches’ and 2000 ‘protections’ to ensure a similar comparison to the commit which introduced using Set for intersection.

Comparison:
   array subtraction:      485.8 i/s
     set subtraction:      128.7 i/s - 3.78x slower