<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/models/note_spec.rb, branch commit-message-contribution</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'rs-note-active-spec' into 'master'</title>
<updated>2016-03-14T16:53:15+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-14T16:53:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b782e7c9732275175d79b485fcddc85e575d48dd'/>
<id>b782e7c9732275175d79b485fcddc85e575d48dd</id>
<content type='text'>
Add unit specs for `Note#active?`

See merge request !3133
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add unit specs for `Note#active?`

See merge request !3133
</pre>
</div>
</content>
</entry>
<entry>
<title>Add unit specs for `Note#active?`</title>
<updated>2016-03-11T23:16:34+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-09T01:04:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a63eba9a2bebd6e33c3d1051a0d2fd08e024f546'/>
<id>a63eba9a2bebd6e33c3d1051a0d2fd08e024f546</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Disallow blank (non-null) values for a Note's `line_code` attribute</title>
<updated>2016-03-11T22:46:50+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-11T22:46:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=01f6db4f643380d143772958b22d3f318b1db3a7'/>
<id>01f6db4f643380d143772958b22d3f318b1db3a7</id>
<content type='text'>
It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use ILIKE/LIKE for searching notes</title>
<updated>2016-03-11T20:25:21+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-01T14:43:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=508b6b46fea6b4bae9ce19c0337bafdb694edda8'/>
<id>508b6b46fea6b4bae9ce19c0337bafdb694edda8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove redundant integration tests</title>
<updated>2016-03-07T20:33:26+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-07T20:24:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=56c4f22c80b0555d5d7cfbc7f443122a8b70072c'/>
<id>56c4f22c80b0555d5d7cfbc7f443122a8b70072c</id>
<content type='text'>
These three tests were essentially checking that adding a note to
something updated its `noteable`'s `updated_at` attribute.

This is well-tested Rails behavior and we shouldn't feel the need to
write an integration test to verify it. At most we should be ensuring
that the association definition adds the `touch: true` option, which we
now do in Note's unit test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These three tests were essentially checking that adding a note to
something updated its `noteable`'s `updated_at` attribute.

This is well-tested Rails behavior and we shouldn't feel the need to
write an integration test to verify it. At most we should be ensuring
that the association definition adds the `touch: true` option, which we
now do in Note's unit test.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename Tasks to Todos</title>
<updated>2016-02-20T14:39:27+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2016-02-20T13:59:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3d52e139b13ad077286f2f9f46b7e98f43ad9564'/>
<id>3d52e139b13ad077286f2f9f46b7e98f43ad9564</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use destroy, in case we ever have before_destroy callbacks on Task</title>
<updated>2016-02-20T14:12:05+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2016-02-18T18:36:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a74a69db689b7e36c0e275a1094b1ad757bd6e86'/>
<id>a74a69db689b7e36c0e275a1094b1ad757bd6e86</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create a pending task when a user is mentioned on a note</title>
<updated>2016-02-20T14:12:05+00:00</updated>
<author>
<name>Douglas Barbosa Alexandre</name>
<email>dbalexandre@gmail.com</email>
</author>
<published>2016-02-17T19:45:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1d476b0656b3ec24e264d7a7c30bdca83704b3bd'/>
<id>1d476b0656b3ec24e264d7a7c30bdca83704b3bd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Improve #set_award! on the Note model</title>
<updated>2016-02-19T09:10:55+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>zegerjan@gitlab.com</email>
</author>
<published>2016-02-19T09:10:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aba1aa49a986230d697106117b5e9b0efa97467c'/>
<id>aba1aa49a986230d697106117b5e9b0efa97467c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Emoji reponses on diffs aren't award emoji</title>
<updated>2016-02-19T09:04:38+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>zegerjan@gitlab.com</email>
</author>
<published>2016-02-18T09:26:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=11ed1cbbb7b777a4883af6ec5b79b958881fab67'/>
<id>11ed1cbbb7b777a4883af6ec5b79b958881fab67</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
