delta/gitlab/gitlab-ce.git/spec/models/network, branch patch-61 gitlab.com: gitlab-org/gitlab-ce.git Autocorrect with RSpec/ExampleWording cop 2019-04-05T08:43:27+00:00 Thong Kuah tkuah@gitlab.com 2019-04-05T08:43:27+00:00 4ec16912b8f4eba9cc70dd21afb65c441f857da0 - rewords examples starting with 'should' - rewords examples starting with 'it' Note: I had to manually fixup "onlies" to "only" 
- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"
Add # frozen_string_literal to spec/models 2019-04-01T01:37:54+00:00 Thong Kuah tkuah@gitlab.com 2019-03-30T07:23:56+00:00 a2cfc150cec677b27728a4758e5e40fff5b4c284 Adds `# frozen_string_literal: true` to spec/models ruby files 
Adds `# frozen_string_literal: true` to spec/models ruby files
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true 2017-07-27T12:31:53+00:00 Rémy Coutable remy@rymai.me 2017-07-10T14:24:02+00:00 ddccd24c1388dadc057ac3c4c0a49f3fea847292 Signed-off-by: Rémy Coutable <remy@rymai.me> 
Signed-off-by: Rémy Coutable <remy@rymai.me>
Sort the network graph both by commit date and topographically. 2017-05-04T04:21:12+00:00 Timothy Andrew mail@timothyandrew.net 2017-05-03T09:29:49+00:00 b44eaf8e0772d4ab076bd0df10b13085483e5e66 - Previously, we sorted commits by date, which seemed to work okay. - The one edge case where this failed was when multiple commits have the same commit date (for example: when a range of commits are cherry picked with a single command, they all have the same commit date [and different author dates]). - Commits with the same commit date would be sorted arbitrarily, and usually break the network graph. - This commit solves the problem by both sorting by date, and by sorting topographically (parents aren't displayed until all their children are displayed) - Include review comments from @adamniedzielski A more detailed explanation is present here: https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230 
- Previously, we sorted commits by date, which seemed to work okay.

- The one edge case where this failed was when multiple commits have the same
  commit date (for example: when a range of commits are cherry picked with a
  single command, they all have the same commit date [and different author
  dates]).

- Commits with the same commit date would be sorted arbitrarily, and usually
  break the network graph.

- This commit solves the problem by both sorting by date, and by sorting
  topographically (parents aren't displayed until all their children are
  displayed)

- Include review comments from @adamniedzielski

A more detailed explanation is present here:
https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230
Fix ordering of commits in the network graph. 2017-04-27T13:09:54+00:00 Timothy Andrew mail@timothyandrew.net 2017-04-26T09:23:22+00:00 a7e67604b3c64a4a9e0cea6e0f9b1fa85d1c30af - We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1 - Prior to this upgrade, the default sort order for commits returned by `Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the graph relied on. - While upgrading `rugged`, the MR also changed this default to `Rugged::SORT_NONE`, which broke commit ordering in the graph. - This commit adds an option to `Gitlab::Git::Repository#find_commits` to sort by date, and changes the graph builder `Network::Graph` so it explictly requests the `:date` sort order 
- We upgraded `rugged` to 0.25.1.1 in !10286 for %9.1

- Prior to this upgrade, the default sort order for commits returned by
  `Gitlab::Git::Repository#find_commits` was `Rugged::SORT_DATE`, which the
  graph relied on.

- While upgrading `rugged`, the MR also changed this default to
  `Rugged::SORT_NONE`, which broke commit ordering in the graph.

- This commit adds an option to `Gitlab::Git::Repository#find_commits` to sort
  by date, and changes the graph builder `Network::Graph` so it explictly
  requests the `:date` sort order
Use `:empty_project` where possible in model specs 2017-01-26T22:44:59+00:00 Robert Speicher rspeicher@gmail.com 2017-01-26T22:44:58+00:00 fcb37542e746d69f20094e2918e498564bbcd863 






Fix Error 500 resulting when loading network graph
2016-08-20T16:57:20+00:00

Stan Hu
stanhu@gmail.com

2016-08-20T16:18:06+00:00

5cb488e8a1a10432c1c5a322b2d4748cb754277f

`discussion_id` may not be present when the SELECT call for notes
does not include this attribute. Don't attempt to set the discussion ID
unless the model contains the attribute.

Closes #21119, #21128





`discussion_id` may not be present when the SELECT call for notes
does not include this attribute. Don't attempt to set the discussion ID
unless the model contains the attribute.

Closes #21119, #21128