<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/spec/models/key_spec.rb, branch remove-commit-tree</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Cache the number of user SSH keys</title>
<updated>2017-11-16T13:59:38+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-11-15T14:47:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3e561736b2eb4866b75c57c01769586f058a2f8d'/>
<id>3e561736b2eb4866b75c57c01769586f058a2f8d</id>
<content type='text'>
By caching the number of personal SSH keys we reduce the number of
queries necessary on pages such as ProjectsController#show (which can
end up querying this data multiple times).

The cache is refreshed/flushed whenever an SSH key is added, removed, or
when a user is removed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By caching the number of personal SSH keys we reduce the number of
queries necessary on pages such as ProjectsController#show (which can
end up querying this data multiple times).

The cache is refreshed/flushed whenever an SSH key is added, removed, or
when a user is removed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure key fingerprints are generated correctly when modified</title>
<updated>2017-10-03T17:45:01+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2017-10-03T17:31:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=eaa1ce4fbed93cc1af95e96c3ff435ff0ec59863'/>
<id>eaa1ce4fbed93cc1af95e96c3ff435ff0ec59863</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Stop using Sidekiq for updating Key#last_used_at</title>
<updated>2017-09-20T12:24:14+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-09-20T12:21:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b3566a01049cdfbde2a9221319601d8949c12a5a'/>
<id>b3566a01049cdfbde2a9221319601d8949c12a5a</id>
<content type='text'>
This makes things simpler as no scheduling is involved. Further we
remove the need for running a SELECT + UPDATE just to get the key and
update it, whereas we only need an UPDATE when setting last_used_at
directly in a request.

The added service class takes care of updating Key#last_used_at without
using Sidekiq. Further it makes sure we only try to obtain a Redis lease
if we're confident that we actually need to do so, instead of always
obtaining it. We also make sure to _only_ update last_used_at instead of
also updating updated_at.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes things simpler as no scheduling is involved. Further we
remove the need for running a SELECT + UPDATE just to get the key and
update it, whereas we only need an UPDATE when setting last_used_at
directly in a request.

The added service class takes care of updating Key#last_used_at without
using Sidekiq. Further it makes sure we only try to obtain a Redis lease
if we're confident that we actually need to do so, instead of always
obtaining it. We also make sure to _only_ update last_used_at instead of
also updating updated_at.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
</pre>
</div>
</content>
</entry>
<entry>
<title>created services for keys</title>
<updated>2017-09-15T15:35:24+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@gmail.com</email>
</author>
<published>2017-09-15T15:35:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cc2daa74d83c98dc05dd92f0950a122b46b83c96'/>
<id>cc2daa74d83c98dc05dd92f0950a122b46b83c96</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rework the permissions model for SSH key restrictions</title>
<updated>2017-08-30T19:50:44+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2017-08-25T13:08:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6847060266792471c9c14518a5106e0f622cd6c5'/>
<id>6847060266792471c9c14518a5106e0f622cd6c5</id>
<content type='text'>
`allowed_key_types` is removed and the `minimum_&lt;type&gt;_bits` fields are
renamed to `&lt;tech&gt;_key_restriction`. A special sentinel value (`-1`) signifies
that the key type is disabled.

This also feeds through to the UI - checkboxes per key type are out, inline
selection of "forbidden" and "allowed" (i.e., no restrictions) are in.

As with the previous model, unknown key types are disallowed, even if the
underlying ssh daemon happens to support them. The defaults have also been
changed from the lowest known bit size to "no restriction". So if someone
does happen to have a 768-bit RSA key, it will continue to work on upgrade, at
least until the administrator restricts them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`allowed_key_types` is removed and the `minimum_&lt;type&gt;_bits` fields are
renamed to `&lt;tech&gt;_key_restriction`. A special sentinel value (`-1`) signifies
that the key type is disabled.

This also feeds through to the UI - checkboxes per key type are out, inline
selection of "forbidden" and "allowed" (i.e., no restrictions) are in.

As with the previous model, unknown key types are disallowed, even if the
underlying ssh daemon happens to support them. The defaults have also been
changed from the lowest known bit size to "no restriction". So if someone
does happen to have a 768-bit RSA key, it will continue to work on upgrade, at
least until the administrator restricts them.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add settings for minimum key strength and allowed key type</title>
<updated>2017-08-30T19:50:44+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2017-08-21T10:30:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b0f982fbdf69c292ab4530c0aaaf1ab42f4e7a01'/>
<id>b0f982fbdf69c292ab4530c0aaaf1ab42f4e7a01</id>
<content type='text'>
This is an amalgamation of:

* Cory Hinshaw: Initial implementation !5552
* Rémy Coutable: Updates !9350
* Nick Thomas: Resolve conflicts and add ED25519 support !13712
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is an amalgamation of:

* Cory Hinshaw: Initial implementation !5552
* Rémy Coutable: Updates !9350
* Nick Thomas: Resolve conflicts and add ED25519 support !13712
</pre>
</div>
</content>
</entry>
<entry>
<title>Backport changes in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE</title>
<updated>2017-08-07T18:17:11+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2017-08-03T12:19:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=da5262f4e6d9524b2af2ad8f6c8ebe10edf17169'/>
<id>da5262f4e6d9524b2af2ad8f6c8ebe10edf17169</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'use-rspec-support-helper' into 'master'</title>
<updated>2017-08-03T16:42:02+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-08-03T16:42:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=29f1fa8250407067683cc0a58350ab4ef5ee3189'/>
<id>29f1fa8250407067683cc0a58350ab4ef5ee3189</id>
<content type='text'>
Don't include EmailHelpers manually, pick with rspec

See merge request !13257</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't include EmailHelpers manually, pick with rspec

See merge request !13257</pre>
</div>
</content>
</entry>
<entry>
<title>fix #35133 strip new lines from ssh keys</title>
<updated>2017-08-03T16:39:10+00:00</updated>
<author>
<name>haseeb</name>
<email>haseebeqx@gmail.com</email>
</author>
<published>2017-08-03T16:39:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ae99f05b059f613296c39dfa45c37dbcab40f4cd'/>
<id>ae99f05b059f613296c39dfa45c37dbcab40f4cd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't include EmailHelpers manually, pick with rspec</title>
<updated>2017-08-03T13:55:48+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2017-08-02T16:43:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bb5f79d43e0bb20bacd5ecd8b66832d9857bd079'/>
<id>bb5f79d43e0bb20bacd5ecd8b66832d9857bd079</id>
<content type='text'>
`:mailer` is needed to pick it easily, while
`type: :mailer` is needed for picking it automatically for
tests located in spec/mailers/*_spec.rb

It's a bit complicated in spec/services/notification_service_spec.rb
but we'll leave it alone for now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`:mailer` is needed to pick it easily, while
`type: :mailer` is needed for picking it automatically for
tests located in spec/mailers/*_spec.rb

It's a bit complicated in spec/services/notification_service_spec.rb
but we'll leave it alone for now.
</pre>
</div>
</content>
</entry>
</feed>
